Re: [dpdk-dev] [PATCH v1 1/3] app/test-eventdev: fix issues with clang 21.1.4

[David Marchand <david.marchand@redhat.com>]

On Tue, 28 Oct 2025 at 18:24, <jerinj@marvell.com> wrote:
>
> From: Jerin Jacob <jerinj@marvell.com>
>
> Fix the following error seen with clang 21.1.4
>
> app/test-eventdev/test_perf_common.c:1340:30: error: variable
> 'event' is uninitialized when passed as a const pointer argument
> here [-Werror,-Wuninitialized-const-pointer]
>
> Fixes: b25a66c49e8d ("app/eventdev: add DMA adapter performance test")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
>  app/test-eventdev/test_perf_common.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c
> index 2ad451e457..2bbc17ae96 100644
> --- a/app/test-eventdev/test_perf_common.c
> +++ b/app/test-eventdev/test_perf_common.c
> @@ -1335,13 +1335,14 @@ perf_event_dma_adapter_setup(struct test_perf *t, struct prod_data *p)
>                 return -ENOTSUP;
>         }
>
> -       if (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND)
> +       if (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND) {

struct rte_event event declaration can be moved in this block.

> +               event.queue_id = p->queue_id;
>                 ret = rte_event_dma_adapter_vchan_add(TEST_PERF_DA_ID, p->da.dma_dev_id,
>                                                       p->da.vchan_id, &event);
> -       else
> +       } else {
>                 ret = rte_event_dma_adapter_vchan_add(TEST_PERF_DA_ID, p->da.dma_dev_id,
>                                                       p->da.vchan_id, NULL);
> -
> +       }
>         return ret;
>  }

Otherwise, this lgtm.
I tested with Fedora 43.


-- 
David Marchand