From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53DC9A04C2 for ; Mon, 25 Nov 2019 11:57:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 451EC2952; Mon, 25 Nov 2019 11:57:48 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 7BAF728EE for ; Mon, 25 Nov 2019 11:57:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574679465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9t3JBx2IdAir6Ohox6xLg25/kRTkCP+qGd8G87y85ek=; b=CWuW8J6et+0rdWDEDvaxxmGaH/nQReSoUEoRxPYqlcCf11jonrlXVSUjiokkC4Nd4obqUB DL4J6EDyl2PDcvUUeWugB80wsVPnpi4JI5wFyM3+IEi8VIghcjxDqSM/FbK052K8sejJNY D9pdDH+qH4NXzDG+X7+0tey0HT9528g= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-55-Dyw7z-QYM4-mUBFlbYSShA-1; Mon, 25 Nov 2019 05:57:44 -0500 Received: by mail-vk1-f197.google.com with SMTP id v188so7197201vkv.18 for ; Mon, 25 Nov 2019 02:57:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MPS5WWS75ERaFu6nEbUjWt8qSQYnkm/f3NZTW7ZbbEw=; b=ZrZp1/n59vcegvib5RhXkSdzSLuARDir9vAllgDIEyWoDUBuqykTaI0QfEVIw96N+r Ymp89mbAaal0yVTIi+sV3Skhh6BTuVPIbnYvIWf4JfPeimTUSwg6kq/Mckojir3gxdpZ OKDJxeyf3THm4ROajpiN8BWUguOpJ2KdYJ/5bpk6SA/fWuz8idujcMzQxaPIqgRS0jfZ X2uPIWjFNoMRZs9TG3a5kR3MJ1zTtiwN+3UhRea2x5rHjoIWUdpli/qy0egi6HL+IzyK 6SUf35VzIfEESKBvWxYf9sHjxsj6MCi8mreYIAP9uwwrYnzEW2EqMasSDNXRcMDfJSj8 jutw== X-Gm-Message-State: APjAAAUx51OzcROWS0sFO1Qh/p+LxQ5YZQODWx6C4JAVy6eEEhala9X4 Nsn3Z5xN9aRw5tuk2syFz2rJCaVmvybXDn6JbxaC2SYP+8MutGNj3cEelMIvEsS9i8gS3TcmaWe lfLWHl4pB9tpO0j7KGMtV4HQ= X-Received: by 2002:a67:f3c7:: with SMTP id j7mr18474981vsn.141.1574679463962; Mon, 25 Nov 2019 02:57:43 -0800 (PST) X-Google-Smtp-Source: APXvYqyp6W3NGE2YlY3cnWBUAlj0ejTaYgFKGILvK+v2NzHzSFtaTg7BuUP8RUNWz+xD6lOy1zLhYn2qnlpHol3CANw= X-Received: by 2002:a67:f3c7:: with SMTP id j7mr18474967vsn.141.1574679463656; Mon, 25 Nov 2019 02:57:43 -0800 (PST) MIME-Version: 1.0 References: <20191125081007.12396-1-david.marchand@redhat.com> <20191125081007.12396-2-david.marchand@redhat.com> <52d83c50-ec1e-c7d2-f757-bfa8482bf968@solarflare.com> In-Reply-To: <52d83c50-ec1e-c7d2-f757-bfa8482bf968@solarflare.com> From: David Marchand Date: Mon, 25 Nov 2019 11:57:32 +0100 Message-ID: To: Andrew Rybchenko Cc: dev , Thomas Monjalon , dpdk stable , Neil Horman X-MC-Unique: Dyw7z-QYM4-mUBFlbYSShA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [PATCH 2/2] buildtools: fix build with coverage enabled X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Nov 25, 2019 at 9:29 AM Andrew Rybchenko wrote: > > On 11/25/19 11:10 AM, David Marchand wrote: > > A compiler can reuse a variable name and prefix it when instrumenting > > with coverage. > > > > Example: > > $ make defconfig T=3Dx86_64-native-linux-gcc O=3Dmaster > > $ make EXTRA_CFLAGS=3D'--coverage' O=3Dmaster > > [...] > > CC rte_flow.o > > rte_flow_dynf_metadata_offs is not flagged as experimental but is list= ed > > in version map > > Please add __rte_experimental to the definition of > > rte_flow_dynf_metadata_offs > > > > $ objdump -t master/build/lib/librte_ethdev/rte_flow.o |grep _offs$ > > 0000000000000000 l F .text.startup 000000000000000a > > _GLOBAL__sub_I_65535_0_rte_flow_dynf_metadata_offs > > 0000000000000620 g O .data 0000000000000004 > > rte_flow_dynf_metadata_offs > > > > Protect against this by adding a space character in the pattern. > > > > Fixes: a4bcd61de82d ("buildtools: add script to check experimental API = exports") > > Cc: stable@dpdk.org > > > > Reported-by: Andrew Rybchenko > > Signed-off-by: David Marchand > > David, > > thanks a lot, it solves build problem. > > It does not solve experimental symbol inconsistency problem in > markup and map file, but it is a separate less critical > problem. We have lived with this situation on experimental variables. So yes, the priority is to fix compilation. I will see if you can do/need something about the variables. Thanks for the tests Andrew. --=20 David Marchand