From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E5498A0096 for ; Mon, 3 Jun 2019 18:14:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7AF7D1B956; Mon, 3 Jun 2019 18:14:14 +0200 (CEST) Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id B5D8A1B94D for ; Mon, 3 Jun 2019 18:14:10 +0200 (CEST) Received: by mail-vs1-f66.google.com with SMTP id m8so2504257vsj.0 for ; Mon, 03 Jun 2019 09:14:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NGc/BItWHs8U5pwhBRLbcL7OZAaMS7bflFsdzjG8m80=; b=csKbkDmJQL3xzB70YwBLRbp23ILxUKc+M2K1UW61WxDXGWesm8RpRbh+DRXpB2dJJJ I96jVHLDhR6Wx/55wyRij9m6OdWZkcu4dn2NBwAROHwt18yxJcAv4Qq2CmBCxv4LWOWB G+oiYm6HCraABTPWVSO/CyaKtUXH96XCOdiOyEiEqmTesxK8tKR0j1562t0OgIxdXDr/ R6Y8hvacONTUMYHxPvH2pIVdrHY/HZ+5q6/MxL8tBZiOCRBqEwUt4O+OOrA1CWiioNAr 4O6AvUyF8sPNT7Z2VKTHJR2kJlfB34nNcIjS1YpoLwuVDrmwXSETmec7vRaecPoMydEL TR7Q== X-Gm-Message-State: APjAAAXn51pxurEa4nsNYOvmqLs2O9fSfhO1RlRu9ovH2bYFJhqcrfC6 m1W04l2suToglhOl+la9QONy13iZe7LcGOUG5xH3bQ== X-Google-Smtp-Source: APXvYqx3h19uxnf3NHpPN1hthOLlfUDW2KWLiieZcvZMVktM2Tn4nz821hiHxHJSoV0Agr3prH/UOx2ro66fnTNQIyg= X-Received: by 2002:a67:1885:: with SMTP id 127mr7083332vsy.39.1559578450134; Mon, 03 Jun 2019 09:14:10 -0700 (PDT) MIME-Version: 1.0 References: <20190530132526.3496-1-i.maximets@samsung.com> <4dd83792-1418-dc82-9e98-a993438faab9@samsung.com> In-Reply-To: <4dd83792-1418-dc82-9e98-a993438faab9@samsung.com> From: David Marchand Date: Mon, 3 Jun 2019 18:13:58 +0200 Message-ID: To: Ilya Maximets Cc: dev , Thomas Monjalon , Anatoly Burakov , Jan Blunck , Qi Zhang , Kevin Traynor , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [PATCH] eal: fix positive error codes from probe/remove X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Jun 3, 2019 at 5:37 PM Ilya Maximets wrote: > On 03.06.2019 11:50, David Marchand wrote: > > > > > > On Thu, May 30, 2019 at 3:26 PM Ilya Maximets > wrote: > > > > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' and their > > 'hotplug' equivalents must return 0 or negative error code. Bus code > > > > > > About this first part, existing callers in dpdk are not consistent with > the api which might explain why this was not seen earlier. > > How about fixing the existing callers? > > Do you mean replacing all the 'rte_dev_probe() != 0' with 'rte_dev_probe() > < 0' > around the codebase? > Yes. It is not necessary to this patch so I can handle it if you don't have time. But dpdk should show a good example by respecting its own apis description. -- David Marchand