From: David Marchand <david.marchand@redhat.com>
To: Aman Singh <aman.deep.singh@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
Qi Zhang <qi.z.zhang@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ice/base: fix build error for GCC 4.8.5
Date: Tue, 5 Oct 2021 15:57:27 +0200 [thread overview]
Message-ID: <CAJFAV8xhf889dF2gGmoRymA+DQr_oi9LZdFhgZ7EMXx85NnaBw@mail.gmail.com> (raw)
In-Reply-To: <20211005115754.34117-1-aman.deep.singh@intel.com>
On Tue, Oct 5, 2021 at 2:07 PM Aman Singh <aman.deep.singh@intel.com> wrote:
>
> Code changes done for build issue as reported in Bug 817
> error: dereferencing type-punned pointer will break strict-aliasing rules.
> added union to avoid pointer dereferencing
>
About the title, Ali reproduced the issue with other versions of gcc.
This patch touches base/ code, is Intel ok with this?
Else, we could consider disabling strict aliasing for the base driver, like
$ git grep alias '**/base/meson.build'
drivers/net/fm10k/base/meson.build: '-Wno-strict-aliasing',
'-Wno-format-extra-args',
drivers/net/i40e/base/meson.build: '-Wno-strict-aliasing',
'-Wno-unused-but-set-variable',
drivers/net/qede/base/meson.build: '-Wno-strict-aliasing',
Bugzilla ID: 817
> Fixes: 39925373a333 ("net/ice/base: add parser execution main loop")
No Cc: stable, this is a regression in main.
> Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
Tested-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2021-10-05 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 11:57 [dpdk-stable] " Aman Singh
2021-10-05 13:57 ` David Marchand [this message]
2021-10-05 14:19 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xhf889dF2gGmoRymA+DQr_oi9LZdFhgZ7EMXx85NnaBw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).