patches for DPDK stable branches
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>,
	stable@dpdk.org
Subject: Re: [PATCH v1 1/1] fbarray: fix find_next_n for unaligned length
Date: Fri, 12 Jul 2024 10:53:09 +0200	[thread overview]
Message-ID: <CAJFAV8xiXjFA2gDnpJrz0fRkpBq6qma1jr33QAN5FEszHu1tLA@mail.gmail.com> (raw)
In-Reply-To: <229663bd30b1f64accf51bdefa20f6abf9ee8ad0.1720612158.git.anatoly.burakov@intel.com>

Hello,

On Wed, Jul 10, 2024 at 1:49 PM Anatoly Burakov
<anatoly.burakov@intel.com> wrote:
>
> When array length is not aligned on a power of 2, we need to mask out the
> unaligned bits from the mask whenever we reach the last mask. However, when both
> ignore mask (e.g. due to starting at unaligned bit) and last index ignore mask
> are specified, we combine them with an OR, which is incorrect. Fix it to combine
> them with AND instead, and add a unit test covering this case.
>
> The reverse function does not suffer from this issue because it does not have to
> deal with array end, and array beginning is always aligned.
>
> Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Please don't forget to run checkpatch before submitting.
I reformatted the commitlog and applied, thanks Anatoly.


-- 
David Marchand


      reply	other threads:[~2024-07-12  8:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-10 11:49 Anatoly Burakov
2024-07-12  8:53 ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8xiXjFA2gDnpJrz0fRkpBq6qma1jr33QAN5FEszHu1tLA@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=roretzla@linux.microsoft.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).