From: David Marchand <david.marchand@redhat.com>
To: longli@linuxonhyperv.com
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>,
dev@dpdk.org, Malcolm Bumgardner <mbumgard@cisco.com>,
stable@dpdk.org, Long Li <longli@microsoft.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] eal: fix device unregister for event registered with device_name NULL
Date: Thu, 10 Oct 2024 12:00:15 +0200 [thread overview]
Message-ID: <CAJFAV8xjW1SXyOh5QiwTr8VEfjpu847tzoT8d1ZOMNsYdKtWOg@mail.gmail.com> (raw)
In-Reply-To: <1721331448-9225-1-git-send-email-longli@linuxonhyperv.com>
On Thu, Jul 18, 2024 at 9:37 PM <longli@linuxonhyperv.com> wrote:
>
> From: Malcolm Bumgardner <mbumgard@cisco.com>
>
> In the device event unregister code, it unconditionally remove all
> callbacks which are registered with device_name set to NULL. This results
> in many callbacks uncorrectly removed.
>
> Fix this by only removing callbacks with matching cb_fn and cb_arg.
>
> Fixes: a753e53d517b ("eal: add device event monitor framework")
> Cc: stable@dpdk.org
>
> Signed-off-by: Malcolm Bumgardner <mbumgard@cisco.com>
> Signed-off-by: Long Li <longli@microsoft.com>
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2024-10-10 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 19:37 longli
2024-09-24 15:50 ` Stephen Hemminger
2024-10-10 10:00 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xjW1SXyOh5QiwTr8VEfjpu847tzoT8d1ZOMNsYdKtWOg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=mbumgard@cisco.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).