From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3FC2EA0096 for ; Mon, 3 Jun 2019 21:32:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 144951B9C8; Mon, 3 Jun 2019 21:32:04 +0200 (CEST) Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com [209.85.217.67]) by dpdk.org (Postfix) with ESMTP id E50061B9AF for ; Mon, 3 Jun 2019 21:31:59 +0200 (CEST) Received: by mail-vs1-f67.google.com with SMTP id g24so9944227vso.8 for ; Mon, 03 Jun 2019 12:31:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5tMXlbwoBah84mSrHxDYrHPvJCASIRNZwIUAQaQ517A=; b=Jbyo33lwl22Vdletlojyt6t5I4ddPQF5PtNreV9bR1lSO2HYBzymrBESe4J/ap0c+n NLcl5ALtkqvdDYoh4gABUOpeJv6xnZZCF4mEHYkmZWkEQ6OTk2alqmhhRvqTy6Cg4moq TAw/Mrvjpxto5n3VMejhUBfZCYSVx+reJ0wZcuVRYOVg14GvjVZNjugAI9Ecq3X3FUgp 2eeoZsPxswLOVg5v0qhRtxP6c/fzMes3GbL/uDxpzmXp/Ag6HKqFN0lSpYuQbFXtbP2d XmzA5YzCM2UC1ONs9qN/IilakJvPLc0FhSeQfCk9MtdJTxRbwwwrABDa1tlcgL/m8QuF eViw== X-Gm-Message-State: APjAAAUxTl4kzF//jk0xVAtzjYtOC5+ThBdu20/oj27NRbmfwTxwdcya hE3LN+XCVU34ca3/FNF4/wX8j4hpzKE92a8FHdYgNQ== X-Google-Smtp-Source: APXvYqwYeW3KjvG5E+RhZWK8RINv7RBEzapwAUbI6CDmAOX95ue+91q9RpUYqdPScsFPkxkIo2jU4SvrEcYdFIUPnQs= X-Received: by 2002:a67:f998:: with SMTP id b24mr3268092vsq.180.1559590319335; Mon, 03 Jun 2019 12:31:59 -0700 (PDT) MIME-Version: 1.0 References: <20190531232723.2030-1-dharmik.thakkar@arm.com> <89DD5489-BABD-4BAA-8815-68F9D18BF301@arm.com> In-Reply-To: <89DD5489-BABD-4BAA-8815-68F9D18BF301@arm.com> From: David Marchand Date: Mon, 3 Jun 2019 21:31:48 +0200 Message-ID: To: Dharmik Thakkar Cc: Yipeng Wang , Sameh Gobriel , Bruce Richardson , Pablo de Lara , dev , dpdk stable , Michael Santana , nd Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [PATCH] test/hash: rectify slaveid to point to valid cores X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Jun 3, 2019 at 6:57 PM Dharmik Thakkar wrote: > > On Jun 1, 2019, at 10:59 AM, David Marchand > wrote: > > I would change the Fixes: tag, fix the checkpatch warning, and send it > next week. > I am not sure about this. Do we simply go by 'git blame' or insert the > commit that truly introduced the error? > http://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body See the part about Fixes:. The purpose of this tag is to point at the commit that introduced an issue so that stable maintainers can catch it with scripts and backport it in the relevant branches. -- David Marchand