From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 553E14339E
for <public@inbox.dpdk.org>; Wed, 22 Nov 2023 17:56:34 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 4AEE042670;
Wed, 22 Nov 2023 17:56:34 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mails.dpdk.org (Postfix) with ESMTP id 739E0410F2
for <stable@dpdk.org>; Wed, 22 Nov 2023 17:56:31 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1700672190;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=GzEpCELQl8HIoYrIsKNIHSXqC1TOF4yI6+u7HM5niVw=;
b=OOFR7PNKldkrRRU557fAiLrMpWZNDU3x7llEmCA++YKCFxuNhz21V9ANu6hJmUqhnDDajh
sIMNo4MTfGotxxDlLFstuu87chpOOVmkCE1z47JSwXHfC8bGQ6zsvbqOgWOlzGzQUz1wps
qWOcQ6Yo1X++Bvm+AUffEivL91n2LGg=
Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com
[209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
us-mta-591-aREnCbPEPm2tub0Cp06AGg-1; Wed, 22 Nov 2023 11:56:28 -0500
X-MC-Unique: aREnCbPEPm2tub0Cp06AGg-1
Received: by mail-lj1-f198.google.com with SMTP id
38308e7fff4ca-2c5194d4e98so58913961fa.3
for <stable@dpdk.org>; Wed, 22 Nov 2023 08:56:28 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1700672187; x=1701276987;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=GzEpCELQl8HIoYrIsKNIHSXqC1TOF4yI6+u7HM5niVw=;
b=OLrWcuO3LMGAmbeRD1XYfrcWHymYv7p5ea7HuECMhjQXskUISjWKkrg8MoWHfz7kD1
lK2l/6gWM9kuLjhhxutTMGeKa8qAUPQK8IgNUA2YQCHo89EhOEaQ6OC0KIRyKjfKNIx8
JBPaiCrhYfhYWDnnPQ2MKtFBxI+tc6YE+Mm68hPUfxxTlqesS1ri0fN4W0Oy/NLgzNiy
ONdCGhJ9w1Cxa+W08vA7algje5Q5Yh5MghukdLV0efG384a0yOK14lgTHqgxp1Bsuehr
HWA6Ljhes6NN1LxJIFd/PH6LfMANMhh+1Aedqk6FcYEgu6PC8WVSlYK59MQLdJpHlNqa
OECA==
X-Gm-Message-State: AOJu0Yw1i7mcS+q6K/vKELtlGgLdbs6qj5mW66L/r3fuR769/G4pjY47
xsvrfQ74B7O7TxsqPKQ4p+2RFUz1WO1iXqCFXeS5ucDtSINuKH2MhJADZaJhpsTZ4Dlxe6+TQK/
qPYi7QBmC8dmZevdJ4i+jNK4=
X-Received: by 2002:a05:651c:2129:b0:2c6:ed45:8c94 with SMTP id
a41-20020a05651c212900b002c6ed458c94mr2494699ljq.51.1700672186969;
Wed, 22 Nov 2023 08:56:26 -0800 (PST)
X-Google-Smtp-Source: AGHT+IEC2/gQetX4+kVFSv4kHoCDJFn/6JCDAzSUxUe7IDwPb5IVbZ0AQgiADFEUtZtMvYlz99mZNvhlcVomPJDlVfs=
X-Received: by 2002:a05:651c:2129:b0:2c6:ed45:8c94 with SMTP id
a41-20020a05651c212900b002c6ed458c94mr2494684ljq.51.1700672186654; Wed, 22
Nov 2023 08:56:26 -0800 (PST)
MIME-Version: 1.0
References: <20231114170529.176665-1-getelson@nvidia.com>
In-Reply-To: <20231114170529.176665-1-getelson@nvidia.com>
From: David Marchand <david.marchand@redhat.com>
Date: Wed, 22 Nov 2023 17:56:15 +0100
Message-ID: <CAJFAV8xqdMYFagLSm6nRS2inY-suruML=6+dw+JEb_yY4jX4sw@mail.gmail.com>
Subject: Re: [PATCH] eal/windows: fix memory management macros usage
To: Gregory Etelson <getelson@nvidia.com>
Cc: dev@dpdk.org, mkashani@nvidia.com, thomas@monjalon.net, stable@dpdk.org,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
On Tue, Nov 14, 2023 at 6:06=E2=80=AFPM Gregory Etelson <getelson@nvidia.co=
m> wrote:
>
> Windows compilation with cross-mingw on Fedora 39 failed
> because MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER were
> already defined in the compiler environment:
>
> eal_memory.c:77: error: "MEM_REPLACE_PLACEHOLDER" redefined
> /usr/x86_64-w64-mingw32/sys-root/mingw/include/winnt.h:5710: note:
> this is the location of the previous definition
>
> eal_memory.c:78: error: "MEM_RESERVE_PLACEHOLDER" redefined
> /usr/x86_64-w64-mingw32/sys-root/mingw/include/winnt.h:5715: note:
> this is the location of the previous definition
>
> The patch masks MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER
> macros if they were pre-defined by compiler.
>
> The patch also masks MEM_COALESCE_PLACEHOLDERS and
> MEM_PRESERVE_PLACEHOLDER to prevent similar errors.
>
> Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
For the record, the same issue has been reported with Ubuntu 23.10.
Applied, thanks.
--=20
David Marchand