From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 130B5A0551 for ; Fri, 21 Feb 2020 11:13:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E4AEC1BFBE; Fri, 21 Feb 2020 11:13:33 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 572371BFAD for ; Fri, 21 Feb 2020 11:13:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582280009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZlxJyB34tJyP9HxrLPIZTNJXLfJgiUyWr08G2eFHgic=; b=WCfk1WyRSWVhiMA5YmQQEb0RBkh34KlmrJeY9BnwDxuxHJ+xgDsKBN54bLKrUoHXbq1I+Y a7dV6f2EtY/BT9OBtCJ2spCAqHdEocoBTIhkaDwT1VJwkMlecb5zEgVqE0soIgHvFD4Axk /JpgPhkM+ni7mX/GyQihXqIVG0sTr7g= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-356-llzrEs3FOiW7dxSMbZVfhA-1; Fri, 21 Feb 2020 05:13:27 -0500 X-MC-Unique: llzrEs3FOiW7dxSMbZVfhA-1 Received: by mail-vk1-f200.google.com with SMTP id t126so738671vkg.6 for ; Fri, 21 Feb 2020 02:13:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZlxJyB34tJyP9HxrLPIZTNJXLfJgiUyWr08G2eFHgic=; b=byC8aqFTbbA8oPYOHLJvhh+uVZNkpF4cMpDst3vpCk8iTZd0l4H9/4tMawI032dc6u gmNhW+AeZAfCEGAU+r/6J+sv3/uuBQ5AT3zERKg/y0XDeJPKqTn93dXhVKyAi3DG1cZc Ksdwt/9cFUumR4ThZlrcYyw6xolzaMUCjucU0wzIw4+6Q284hyunbvDDGqQ3zRUL+KBz uMsuHRo6foJxCOYMGrXJqpSJvfKi1YcKPk5mE/w/0zkvCgyyypF5wZU/dZzT8cVik2rn Ve4azYk74taJ5NnmnW7bKBpYZvfAyKPQHRQ5FRs5eYoJDgxFRG5s1F8sWehi7ZoSB4/v e2BA== X-Gm-Message-State: APjAAAXWNWEvHoqwGNKZv5QS2g0ZQMlrCMHKSW8AXRLfG5nSM2LIn7Rt xxli15Zw2bEAEIh51gYATfCyUwOWYI6vTzjh8cB5Lp4lpuAJNSrq5pj9FbVU4xMDssdgXMHk1WL XkgASr3clkopPg3+GGMW59T4= X-Received: by 2002:ab0:6796:: with SMTP id v22mr18360592uar.41.1582280006967; Fri, 21 Feb 2020 02:13:26 -0800 (PST) X-Google-Smtp-Source: APXvYqxxk62Zjy/reuj9pWRTWPyam3A8H2Dg+HEzQD8lpMV8ONgK/MhP5XEnuSgT3mygS0BLBuKyz68v27rS9bBdBKk= X-Received: by 2002:ab0:6796:: with SMTP id v22mr18360573uar.41.1582280006500; Fri, 21 Feb 2020 02:13:26 -0800 (PST) MIME-Version: 1.0 References: <20200210030757.11426-1-xiaoyun.li@intel.com> <20200217014115.26572-1-xiaoyun.li@intel.com> In-Reply-To: <20200217014115.26572-1-xiaoyun.li@intel.com> From: David Marchand Date: Fri, 21 Feb 2020 11:13:15 +0100 Message-ID: To: Xiaoyun Li Cc: Xiaolong Ye , dev , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [PATCH v3] examples/tep_term: remove redundant info get X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Feb 17, 2020 at 2:41 AM Xiaoyun Li wrote: > > Removed redundant function call of 'rte_eth_dev_info_get()' since it has > already been called earlier. > > Coverity issue: 349922 > Fixes: 2bb43bd4350a ("examples/tep_term: add TSO offload configuration") > Cc: stable@dpdk.org > > Signed-off-by: Xiaoyun Li Little comment, this patch solves a coverity issue. Upon inspection of this example code, I can see no check on device capability when sending packets. So I suppose it is broken when user asks for TSO, but the devices do not support TSO. Can you investigate and fix this in the next release? Reviewed-by: Xiaolong Ye Acked-by: David Marchand Applied, thanks. -- David Marchand