From: David Marchand <david.marchand@redhat.com>
To: dev <dev@dpdk.org>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: stable@dpdk.org, alialnu@nvidia.com,
Bruce Richardson <bruce.richardson@intel.com>,
Luca Boccassi <bluca@debian.org>,
"Xueming(Steven) Li" <xuemingl@nvidia.com>,
Patrick Robb <probb@iol.unh.edu>,
Kevin Traynor <ktraynor@redhat.com>
Subject: Re: [PATCH 21.11] ring: squash gcc 12.2.1 warnings
Date: Thu, 16 Mar 2023 12:00:54 +0100 [thread overview]
Message-ID: <CAJFAV8xsQ2r86n-fUJd1v5VSAZmXcL54xcqr2KS7DE9AOF+LJg@mail.gmail.com> (raw)
In-Reply-To: <20221220123754.239802-1-ktraynor@redhat.com>
On Tue, Dec 20, 2022 at 1:38 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>
> gcc 12.2.1 on Fedora 37 is giving stringop-overread and
> stringop-overflow warnings when compiled with --buildtype=debug
> e.g. [1].
>
> These are not yet fixed on main branch. They look similar
> to the overflow issues previously squashed in rte_memcpy with
> commit b5b3ea803e47 ("eal/x86: ignore gcc 10 stringop-overflow warnings")
>
> In order to ensure DPDK 21.11.3 compiles on Fedora 37, squash these
> warnings. If a subsequent cleaner fix becomes available on from main
> branch it can be backported to later DPDK 21.11 LTS release.
>
> [1]
> lib/ring/rte_ring_elem_pvt.h:100:25: error:
> ‘memcpy’ reading 32 bytes from a region of size 4
> [-Werror=stringop-overread]
> 100 | memcpy((void *)(ring + idx),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 101 | (const void *)(obj + i), 32);
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> lib/ring/rte_ring_elem_pvt.h:234:25: error:
> ‘memcpy’ writing 32 bytes into a region of size 4 overflows the destination
> [-Werror=stringop-overflow=]
> 234 | memcpy((void *)(obj + i), (void *)(ring + idx), 32);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
As mentionned in this thread:
https://inbox.dpdk.org/dev/ZBLqF6c3ujMic45N@bricha3-MOBL.ger.corp.intel.com/T/#me1c8f06a9ca2cf2a4ed4a028d373a3e3ce5146d1
I intend to pull this change in the main repository and mark this
change for backports in other stable branches.
I'll do this for -rc3, expected tomorrow, unless someone objects.
--
David Marchand
next prev parent reply other threads:[~2023-03-16 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 12:37 Kevin Traynor
2022-12-20 17:18 ` Kevin Traynor
2023-03-16 11:00 ` David Marchand [this message]
2023-03-16 14:08 ` Konstantin Ananyev
2023-03-16 15:52 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xsQ2r86n-fUJd1v5VSAZmXcL54xcqr2KS7DE9AOF+LJg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=alialnu@nvidia.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=konstantin.ananyev@intel.com \
--cc=ktraynor@redhat.com \
--cc=probb@iol.unh.edu \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).