From: David Marchand <david.marchand@redhat.com>
To: Ali Alnubani <alialnu@nvidia.com>, Kevin Traynor <ktraynor@redhat.com>
Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
Bruce Richardson <bruce.richardson@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] patch 'eal: remove useless makefiles' has been queued to LTS release 18.11.11
Date: Thu, 29 Oct 2020 13:10:02 +0100 [thread overview]
Message-ID: <CAJFAV8xtJU20_JJ+dZVDSh3ER8LrA+cCqqKuBYHwi2SX3GbfKw@mail.gmail.com> (raw)
In-Reply-To: <DM6PR12MB4618287BA3F1E6D408FA7F2DDA180@DM6PR12MB4618.namprd12.prod.outlook.com>
On Sun, Oct 25, 2020 at 12:53 PM Ali Alnubani <alialnu@nvidia.com> wrote:
>
> Hi,
>
> > -----Original Message-----
> > From: stable <stable-bounces@dpdk.org> On Behalf Of Kevin Traynor
> > Sent: Tuesday, October 6, 2020 3:08 PM
> > To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
> > Cc: Bruce Richardson <bruce.richardson@intel.com>; David Marchand
> > <david.marchand@redhat.com>; dpdk stable <stable@dpdk.org>
> > Subject: [dpdk-stable] patch 'eal: remove useless makefiles' has been
> > queued to LTS release 18.11.11
> >
> > Hi,
> >
> > FYI, your patch has been queued to LTS release 18.11.11
> >
> <removed>
> > ---
> > From 4a2be43591df63d55d9665389ff41fcba19db85a Mon Sep 17 00:00:00
> > 2001
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Date: Fri, 27 Mar 2020 02:15:33 +0100
> > Subject: [PATCH] eal: remove useless makefiles
> >
> > [ upstream commit 4448a202b61e1a373c647aa4638093d092b3f5de ]
> >
> > When moving files to the directory kernel/, the file BSDmakefile.meson was
> > left in eal/.
> >
> > Also the intermediate makefiles in linuxapp/ and bsdapp/ became useless.
> >
> > Fixes: acaa9ee991b5 ("move kernel modules directories")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > Acked-by: David Marchand <david.marchand@redhat.com>
> >
> <removed>
>
> Backporting this patch to 18.11 started causing the following build failure with older gcc versions on RHEL and CentOS with make:
> """
> ...
> SYMLINK-FILE include/rte_pci_dev_features.h
> CC eal_memory.o
> CC eal_thread.o
> SYMLINK-FILE include/rte_malloc.h
> CC eal_log.o
> CC eal_vfio.o
> SYMLINK-FILE include/rte_keepalive.h
> lib/librte_eal/linuxapp/eal/eal_cpuflags.c:19:26: fatal error: rte_cpuflags.h: No such file or directory
> #include <rte_cpuflags.h>
> ^
> compilation terminated.
> SYMLINK-FILE include/rte_time.h
> lib/librte_eal/linuxapp/eal/eal_thread.c:16:24: fatal error: rte_atomic.h: No such file or directory
> #include <rte_atomic.h>
> ^
> compilation terminated.
> In file included from x86_64-native-linuxapp-gcc/include/rte_eal_memconfig.h:12:0,
> from lib/librte_eal/linuxapp/eal/eal.c:35:
> x86_64-native-linuxapp-gcc/include/rte_malloc_heap.h:10:26: fatal error: rte_spinlock.h: No such file or directory
> #include <rte_spinlock.h>
> ^
> compilation terminated.
> ...
> """
I can reproduce with parallel compilation.
There is a dependency on installing EAL headers that got broken with
this backport.
--
David Marchand
next prev parent reply other threads:[~2020-10-29 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 12:07 Kevin Traynor
2020-10-06 12:07 ` [dpdk-stable] patch 'net/mlx5: fix netlink buffer allocation from stack' " Kevin Traynor
2020-10-25 11:53 ` [dpdk-stable] patch 'eal: remove useless makefiles' " Ali Alnubani
2020-10-29 11:23 ` Kevin Traynor
2020-10-29 12:10 ` David Marchand [this message]
2020-10-29 12:18 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xtJU20_JJ+dZVDSh3ER8LrA+cCqqKuBYHwi2SX3GbfKw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=alialnu@nvidia.com \
--cc=bruce.richardson@intel.com \
--cc=ktraynor@redhat.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).