From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A97AA04B5 for ; Thu, 29 Oct 2020 13:10:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 24ADFCAB5; Thu, 29 Oct 2020 13:10:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 14FE8CAB5 for ; Thu, 29 Oct 2020 13:10:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603973417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ofhUf/qTq7/FYTtQLX9wsG8poT6lawQduEnuPDLeuBM=; b=CAOdpIBcoukdtIBzcqS/OGVfEFpOtydjgd+2DsZic9jElxjQiw0a+A91lHw2ONdw1szlqy l055xPkufKilJqMhyeg81Nq7Hum68e6Zcr6LVwYCizyiaiSazmIUAea+dfJ+qB55H9Y5O2 ITuKYJ1H3OQVpUDrOhKF3oC0Ey6mMII= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-39-q8S9jBh0PvSauqabJe_viw-1; Thu, 29 Oct 2020 08:10:15 -0400 X-MC-Unique: q8S9jBh0PvSauqabJe_viw-1 Received: by mail-vk1-f197.google.com with SMTP id l21so659786vka.22 for ; Thu, 29 Oct 2020 05:10:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ofhUf/qTq7/FYTtQLX9wsG8poT6lawQduEnuPDLeuBM=; b=uD8HCWRFi9j+Tl6mp/beHB6LupAsEZ5lmtGGImlJoc/7Pun4MeExUsn3cdfD7uM5aN SHvXji8lq3Y1nyoyEta+fhyTmRrsyGcJY38bTcgUBOaak5wNXCCWwTVnGjUcMfxOl2nD f6hlh4fkaR9ZhnpQO/sKf3jZ+wlpdLKyKRx3nAVNHs/KfFqBBMOCS3w/YskK09nWJc/A Hnqj4euubDbOGoF/f4pBvQXVycympI0NwYizH3qsad9NuAGoQgx1hUzit+hxBzi5HtxA y1JTcj83Gy2UtH93PYz59I+k9uLNKKPjrU5I6xYFzk9PTfXEdgxQ56Sh0uHwGhrzP3B1 +oYg== X-Gm-Message-State: AOAM530BfX+4WrtTdtc2UuKh3g4mRBAw7yPbf3CSBM1NCM/K4pBL6wIp avYxSbMkeGzhHrcyFsAIRKYfNfaHC58A61IOQclxBHNZzWYr53sQOuKzOVvSizPYIgoA22VgOfs V25KBM1XN1RCcsyNglil3i9s= X-Received: by 2002:a1f:38d2:: with SMTP id f201mr2636658vka.17.1603973413978; Thu, 29 Oct 2020 05:10:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyi0oSCOMIzj7SzqYreeyyLgLFXxG9lkZj6RoeVwbb0eDeKjvFJX0jq0KyZOaPRj/WnBe45prokHSUNYzYltIU= X-Received: by 2002:a1f:38d2:: with SMTP id f201mr2636632vka.17.1603973413750; Thu, 29 Oct 2020 05:10:13 -0700 (PDT) MIME-Version: 1.0 References: <20201006120738.29125-1-ktraynor@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 29 Oct 2020 13:10:02 +0100 Message-ID: To: Ali Alnubani , Kevin Traynor Cc: NBU-Contact-Thomas Monjalon , Bruce Richardson , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] patch 'eal: remove useless makefiles' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Sun, Oct 25, 2020 at 12:53 PM Ali Alnubani wrote: > > Hi, > > > -----Original Message----- > > From: stable On Behalf Of Kevin Traynor > > Sent: Tuesday, October 6, 2020 3:08 PM > > To: NBU-Contact-Thomas Monjalon > > Cc: Bruce Richardson ; David Marchand > > ; dpdk stable > > Subject: [dpdk-stable] patch 'eal: remove useless makefiles' has been > > queued to LTS release 18.11.11 > > > > Hi, > > > > FYI, your patch has been queued to LTS release 18.11.11 > > > > > --- > > From 4a2be43591df63d55d9665389ff41fcba19db85a Mon Sep 17 00:00:00 > > 2001 > > From: Thomas Monjalon > > Date: Fri, 27 Mar 2020 02:15:33 +0100 > > Subject: [PATCH] eal: remove useless makefiles > > > > [ upstream commit 4448a202b61e1a373c647aa4638093d092b3f5de ] > > > > When moving files to the directory kernel/, the file BSDmakefile.meson was > > left in eal/. > > > > Also the intermediate makefiles in linuxapp/ and bsdapp/ became useless. > > > > Fixes: acaa9ee991b5 ("move kernel modules directories") > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Bruce Richardson > > Acked-by: David Marchand > > > > > Backporting this patch to 18.11 started causing the following build failure with older gcc versions on RHEL and CentOS with make: > """ > ... > SYMLINK-FILE include/rte_pci_dev_features.h > CC eal_memory.o > CC eal_thread.o > SYMLINK-FILE include/rte_malloc.h > CC eal_log.o > CC eal_vfio.o > SYMLINK-FILE include/rte_keepalive.h > lib/librte_eal/linuxapp/eal/eal_cpuflags.c:19:26: fatal error: rte_cpuflags.h: No such file or directory > #include > ^ > compilation terminated. > SYMLINK-FILE include/rte_time.h > lib/librte_eal/linuxapp/eal/eal_thread.c:16:24: fatal error: rte_atomic.h: No such file or directory > #include > ^ > compilation terminated. > In file included from x86_64-native-linuxapp-gcc/include/rte_eal_memconfig.h:12:0, > from lib/librte_eal/linuxapp/eal/eal.c:35: > x86_64-native-linuxapp-gcc/include/rte_malloc_heap.h:10:26: fatal error: rte_spinlock.h: No such file or directory > #include > ^ > compilation terminated. > ... > """ I can reproduce with parallel compilation. There is a dependency on installing EAL headers that got broken with this backport. -- David Marchand