From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4179A10DA for ; Sat, 3 Aug 2019 11:51:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 122C91BF4B; Sat, 3 Aug 2019 11:51:45 +0200 (CEST) Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com [209.85.222.67]) by dpdk.org (Postfix) with ESMTP id 7C5081BF4B for ; Sat, 3 Aug 2019 11:51:43 +0200 (CEST) Received: by mail-ua1-f67.google.com with SMTP id 34so30599422uar.8 for ; Sat, 03 Aug 2019 02:51:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H6qWZuscix+SZWPLFzaty28RnMOQhwA9j5YeMwFTre0=; b=XLZypJC0ZrTXtLJcg/ss4EDBBInXnnv1fYET36ZLALb/UYLSRksT6Kb9elWy6ukE2h qJ0j8IK6uFa50iWfMRWBKjnmWvN2Z90WG7XvusDGuPVoRMMLdW5Y4b6lqEb1MgpukZ07 xj0/ATSw1HMmkOGvEwIEkFgr7ys1+y7S8AroGADYfaq8gcrkVlhCD9i0Ib6jKbwgXoua iT02IzmY9YICdsiURQYHliSRzBwEc4x5zMGQCp87aWKAyvdJDTzFIEnRhsGvoT1D2PIt mlDZYWb+JEtDsR/5SojxDDPyuBncZKM8+bc3pPSbAmxgMsuXDdE+pwZtTvCaV+U54vDo erhw== X-Gm-Message-State: APjAAAWswM3t1V2aIGU0ySmCpOuECfsRXFQ28gw3FJJEHLlLVYW1hTrk 8AeJiU7wHKgYovbbj77q9c9VVhxJDOebtdExXoPYNA== X-Google-Smtp-Source: APXvYqziu0BXBjBEwChyrGCL4MYMKRHWurX3JmqW2huk9YH6LdsNceGLeXOwYL5d70juOzmfL/hVvq10RiaATQybh1w= X-Received: by 2002:ab0:6198:: with SMTP id h24mr24100415uan.41.1564825902768; Sat, 03 Aug 2019 02:51:42 -0700 (PDT) MIME-Version: 1.0 References: <1564662465-2925-1-git-send-email-david.marchand@redhat.com> <2288744.0SrN437FYt@xps> In-Reply-To: <2288744.0SrN437FYt@xps> From: David Marchand Date: Sat, 3 Aug 2019 11:51:31 +0200 Message-ID: To: Thomas Monjalon Cc: dpdk stable , dev , Aaron Conole , Michael Santana Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH] test/eal: do not scan PCI devices for memory tests X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, Aug 2, 2019 at 10:57 PM Thomas Monjalon wrote: > > 01/08/2019 14:27, David Marchand: > > The memory tests currently check that, for normal mode (not legacy mode), > > there is no memory left behind when exiting. > > I think this is the real bug: > we are checking a behaviour that we cannot achieve currently. > > > The problem is that if a ethdev port is allocated when scanning pci > > devices (even if the driver probe fails like when you have a virtio > > management interface attached to the kernel), on exit, dpdk won't free > > the associated memory since ethdev never frees the ethdev memzone. > > As you said in this thread, we could think about how to free it properly > in a future release. > For 19.08, I would suggest to disable the test with a comment > explaining the reason. For 19.08, as long as we test shared builds in the CI, then it just "works", because the net drivers are not loaded. No net driver, no ethdev leak ;-) -- David Marchand