From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id B7504A0C47
for <public@inbox.dpdk.org>; Wed, 3 Nov 2021 21:37:05 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 9445F40689;
Wed, 3 Nov 2021 21:37:05 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mails.dpdk.org (Postfix) with ESMTP id 3D6E240689
for <stable@dpdk.org>; Wed, 3 Nov 2021 21:37:04 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1635971823;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=zPxsK3/IXuO6IWwaXWq5AvbOIeIWUBeqHqVfpB20Jts=;
b=Azbr9z5tJbtkCsPwWiKeinZbH5WoUHOt1zrunpPua2rc3kmtUEAcNedQ7tZpCKKkoK4pZ0
hsZaflzqCSjrRPJhwBaYD2g5i/XivN9tFbYrGkaOfAptChmFguGj2aX8U0OXwwY+FOR/uO
CBgK57wa8m6DjUI5FgzWdz2HzZy4bEE=
Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com
[209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-39-ytwS-3UIN8uQT63VkRtyNg-1; Wed, 03 Nov 2021 16:37:02 -0400
X-MC-Unique: ytwS-3UIN8uQT63VkRtyNg-1
Received: by mail-lf1-f71.google.com with SMTP id
s18-20020ac25c52000000b004016bab6a12so1027806lfp.21
for <stable@dpdk.org>; Wed, 03 Nov 2021 13:37:02 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=zPxsK3/IXuO6IWwaXWq5AvbOIeIWUBeqHqVfpB20Jts=;
b=khQo3arkdIi1dDBBT0dXWhnkxRhn5JzME0lOsNqNqpDE75drxK+VvE3OfOURlXmck+
MhjJv2sVEaVcYXBeWXVvZqHNKnkAVt6FIlwR15Og4Bfo+u+IfVfXp6lgd8bOgz+sk4cr
AZVzWRiz2YGoFL5EnTA8OTnKkW1KvqojbBAPZ4BJ/M8MRjhvDYlO08VahVDhN2JXKdbf
ir50UWuta/FrCkPfBPRx68VFQlciw2s3i/HlCy5lP+RCq352txFlhsVIWh5SBG6WrBT+
WrLKadLMtI8LINdHUatTsuJvPstMQZLLIF5b5rFO50azsH718bmpyzozUhH+h1lr22TN
GpXQ==
X-Gm-Message-State: AOAM5324AZGQe8kQPopHiqY+rakjUK+F7KEydPqxgXFAV+OHWgbk5RP8
WeDfbGFx5b40hWPJsVVaILsEOPJsoTGTowDKTFXYTGs8aV0rzFHthLW3zDjJTr81D6iCrdzIA1L
EnNPS7Y5mzJ+xAeM5boxc0wU=
X-Received: by 2002:a2e:7f1b:: with SMTP id a27mr47763316ljd.55.1635971820962;
Wed, 03 Nov 2021 13:37:00 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzP4+F8/7KTe1MXECEL2x32QhurM/l+l5BnraDSxLOWVf7KYpalsH49KyZHsQP/qioUsHUmr/L+ysbQpyDJeEI=
X-Received: by 2002:a2e:7f1b:: with SMTP id a27mr47763295ljd.55.1635971820768;
Wed, 03 Nov 2021 13:37:00 -0700 (PDT)
MIME-Version: 1.0
References: <20211026090610.10823-1-houssem.bouhlel@6wind.com>
<YXfHk0mGy8xU3LEH@platinum> <YXu0hT8VmzYrOvv4@platinum>
In-Reply-To: <YXu0hT8VmzYrOvv4@platinum>
From: David Marchand <david.marchand@redhat.com>
Date: Wed, 3 Nov 2021 21:36:49 +0100
Message-ID: <CAJFAV8y16+XMUx4ZMasH6tdqRcAKM+OPB0dPNxWkq0UGuUNBOg@mail.gmail.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: Houssem Bouhlel <houssem.bouhlel@6wind.com>, dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>, "Burakov,
Anatoly" <anatoly.burakov@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-stable] [PATCH] bus/pci: fix selection of default device
NUMA node
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
On Fri, Oct 29, 2021 at 10:45 AM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> +CC David
>
> On Tue, Oct 26, 2021 at 11:17:08AM +0200, Olivier Matz wrote:
> > On Tue, Oct 26, 2021 at 11:06:10AM +0200, Houssem Bouhlel wrote:
> > > There can be dev binding issue when no hugepages
> > > are allocated for socket 0.
> > > To avoid this, set device numa node value based on
> > > the first lcore instead of 0.
> > >
> > > Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support")
> >
> > Sorry, the Fixes line is wrong. This is the correct one:
> > Fixes: 8a04cb612589 ("pci: set default numa node for broken systems")
> >
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Houssem Bouhlel <houssem.bouhlel@6wind.com>
> > > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > > ---
> > > drivers/bus/pci/pci_common.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
> > > index f8fff2c98ebf..c70ab2373c79 100644
> > > --- a/drivers/bus/pci/pci_common.c
> > > +++ b/drivers/bus/pci/pci_common.c
> > > @@ -166,6 +166,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
> > > struct rte_pci_device *dev)
> > > {
> > > int ret;
> > > + unsigned int socket_id;
> > > bool already_probed;
> > > struct rte_pci_addr *loc;
> > >
> > > @@ -194,7 +195,8 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
> > > if (rte_socket_count() > 1)
> > > RTE_LOG(INFO, EAL, "Device %s is not NUMA-aware, defaulting socket to 0\n",
> > > dev->name);
> >
> > One more comment (sorry, I should have done it before you send the mail):
> > We should move this log below, and use the socket_id instead of 0.
> >
> > > - dev->device.numa_node = 0;
> > > + socket_id = rte_lcore_to_socket_id(rte_get_next_lcore(-1, 0, 0));
> > > + dev->device.numa_node = socket_id;
>
> After some offline discussions with David, some additional comments:
>
> - a similar change may be needed in other bus drivers
>
> - instead of setting the numa node to an existing socket, it can make
> more sense to keep its value to unknown (-1). This would however be a
> behavior change for pci bus, which returns 0 since 2015 for unknown
> cases. See:
> 81f8d2317df2 ("eal/linux: fix socket value for undetermined numa node")
> 8a04cb612589 ("pci: set default numa node for broken systems")
>
> I'll tend to be in favor of using -1. Any other opinion?
> Should we announce a behavior change in this case?
Good summary.
I copied some more people.
I am for -1 too (as a way to indicate "I don't know what this PCI
device affinity is").
It is dangerous to change now, and I think it is late for 21.11.
--
David Marchand