From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7F009A0C53
for <public@inbox.dpdk.org>; Wed, 3 Nov 2021 14:43:07 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 75A65426F6;
Wed, 3 Nov 2021 14:43:07 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mails.dpdk.org (Postfix) with ESMTP id 82A53426F6
for <stable@dpdk.org>; Wed, 3 Nov 2021 14:43:06 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1635946986;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=1kwAxDeFTo+KprEEVwsP0WA5FOw20ezyOi5dCoTW4i0=;
b=Gpcl2+JQjN/VyXuB0YDSlIGbpY3lPi3iGG59xClS6msOdiNLWESUoud86qWdD5L/9tVBQ4
IMNre2qYCnz0wZfb3ldxbvw7JVfC1+0pJA4CoqzeCmiQy9DNnviqSnbi5rq7TtxV3EdoI+
GVSUVrPHvTSoNyHtHU7yFRn0Nwd7I2w=
Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com
[209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-239-5OWf6f71PQSgu4HyUajr9g-1; Wed, 03 Nov 2021 09:43:03 -0400
X-MC-Unique: 5OWf6f71PQSgu4HyUajr9g-1
Received: by mail-lj1-f200.google.com with SMTP id
m11-20020a2e97cb000000b00212f89f3888so1082749ljj.21
for <stable@dpdk.org>; Wed, 03 Nov 2021 06:43:03 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=1kwAxDeFTo+KprEEVwsP0WA5FOw20ezyOi5dCoTW4i0=;
b=ufYwEIz84NrLv9jlxUH128vCY4OPUXdg6CaKhi/r5Ejx8BlZ3Qli9CLS2qIKHWA2Cy
Ir1sdgQWAO9Hh/froOcNu+4kag/HKoh0BRWOom1IfpFdknBHhx9n1tXla5p269dlh1st
5WvqcWAHW8sObQDM0b3+bZ2MG+AOo9UjC7nh8uqvk5b0ReK9nD+ewGCiIQS1nUYlSz14
F7UYjtXDAE6tatw35BV54T1XKtYnS1vMTZM61sX3UvRem4hsLZ0+NVuw0ba6NjhvEw0j
rvhK4yO0iP+mGPQiNuEGWpDQZFGnIBSXgyZ5/MXe/6a29hs7n2hW7gOv3TJnENKt/dnR
Tsww==
X-Gm-Message-State: AOAM532cYvm7YdLkhNcdaiwMFv9MMuJD2gAQ1+o3VjnyEptLnpXPpfP9
cV6sB8nTm2AlokDljUgewVU0qOroThk/N3LTdJDo1Een5jmTC/RqSgXFYnLOrF3C82JFvpcIaFE
o84lpZrNDclZ7XzXfpezpV20=
X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr38998055lfq.553.1635946981838;
Wed, 03 Nov 2021 06:43:01 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxkfLAoZhlUX2iKIDm1ZktiAHFYfeg1KX6FKGtX1mpsn1UEQdxp2qPmZb0fTM6VuH3JgLT3jDTTmtkHMAgvChs=
X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr38998026lfq.553.1635946981536;
Wed, 03 Nov 2021 06:43:01 -0700 (PDT)
MIME-Version: 1.0
References: <20211103105155.3556048-1-radu.nicolau@intel.com>
<20211103115618.3559996-1-radu.nicolau@intel.com> <2503525.8RzHhxm8q0@thomas>
In-Reply-To: <2503525.8RzHhxm8q0@thomas>
From: David Marchand <david.marchand@redhat.com>
Date: Wed, 3 Nov 2021 14:42:50 +0100
Message-ID: <CAJFAV8y2XQJr=VewNphuf-mJ2m2gTz3SVWjVNiN51-+p_6A=Ug@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Radu Nicolau <radu.nicolau@intel.com>, Akhil Goyal <gakhil@marvell.com>
Cc: dev <dev@dpdk.org>, Declan Doherty <declan.doherty@intel.com>,
"Hemant Agrawal (OSS)" <hemant.agrawal@oss.nxp.com>,
Anoob Joseph <anoobj@marvell.com>, dpdk stable <stable@dpdk.org>
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-stable] [PATCH v2] examples/ipsec-secgw: fix potential
build error
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
On Wed, Nov 3, 2021 at 2:09 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 03/11/2021 12:56, Radu Nicolau:
> > When STATS_INTERVAL is set to a non-zero value the core_statistics array
> > will be defined in multiple compilation units and this can trigger a
> > linker error on particular environments. In order to fix this the
> > core_statistics definition was moved out of the header file.
>
> So it is not fixing compilation,
> as we would never apply a patch which would completely break compilation.
> I would say (in the title) that it moves global variable from header file.
>
> > Fixes: 1329602b6c8f ("examples/ipsec-secgw: add per-core packet statistics")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
I guess it has to do with series:
https://patchwork.dpdk.org/project/dpdk/list/?series=20174
http://mails.dpdk.org/archives/test-report/2021-November/237332.html
So it should be part of this series.
--
David Marchand