patches for DPDK stable branches
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Cc: dev@dpdk.org, Harry van Haaren <harry.van.haaren@intel.com>,
	 Stephen Hemminger <stephen@networkplumber.org>,
	hofors@lysator.liu.se,  Suanming Mou <suanmingm@nvidia.com>,
	thomas@monjalon.net, stable@dpdk.org
Subject: Re: [PATCH] service: avoid worker lcore exit deadlock
Date: Tue, 1 Oct 2024 15:54:11 +0200	[thread overview]
Message-ID: <CAJFAV8y6WvJWdhDBSPdQT9okw6mJxE7Hj4q1Pk3PCWqxNpenoQ@mail.gmail.com> (raw)
In-Reply-To: <20230704214339.244271-1-mattias.ronnblom@ericsson.com>

Hello,

On Tue, Jul 4, 2023 at 11:49 PM Mattias Rönnblom
<mattias.ronnblom@ericsson.com> wrote:
>
> Calling rte_exit() from a worker lcore thread causes a deadlock in
> rte_service_finalize().
>
> This patch makes rte_service_finalize() deadlock-free by avoiding the
> need to synchronize with service lcore threads, which in turn is
> achieved by moving service and per-lcore state from the heap to being
> statically allocated.
>
> The BSS segment increases with ~156 kB (on x86_64 with default
> RTE_MAX_LCORE and RTE_SERVICE_NUM_MAX).
>
> According to the service perf autotest, this change also results in a
> slight reduction of service framework overhead.
>
> Fixes: 33666b448f15 ("service: fix crash on exit")
> Cc: stable@dpdk.org
>
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

Sorry, this fell through the cracks.
CI was complaining about this patch and it was probably a false
positive, but we don't have the (full) logs anymore.

Could you resend it please?


-- 
David Marchand


  parent reply	other threads:[~2024-10-01 13:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04 21:43 Mattias Rönnblom
2023-07-06 11:33 ` Van Haaren, Harry
2024-10-01 13:54 ` David Marchand [this message]
2024-10-01 16:26 Mattias Rönnblom
2024-10-02 14:02 ` Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8y6WvJWdhDBSPdQT9okw6mJxE7Hj4q1Pk3PCWqxNpenoQ@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=hofors@lysator.liu.se \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=suanmingm@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).