From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A444148B9D for ; Mon, 24 Nov 2025 17:13:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 987124067E; Mon, 24 Nov 2025 17:13:07 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5371740689 for ; Mon, 24 Nov 2025 17:13:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764000784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aYpiH7WGW9wnhZ4Qa5eLJhW4o8twlPxgcc8Qxxb0NTo=; b=R673BGcgOc0msktaOLOLrYu0vnE7ETFId6dtAi1oY9X8jNF1XR8AeksV6GT/WZDGTj1dV4 BWOci9LSBc5snRwDtfAdOC4bQwmlshy1xImXxMWIR5z5KhbVBlkOJGroxIoUmKVqBOMySC yTAwNw8HB9m5KO/gye/p45hjAAU09RU= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-551-jtAj6-h7MyKVjDH2NQiW9Q-1; Mon, 24 Nov 2025 11:12:56 -0500 X-MC-Unique: jtAj6-h7MyKVjDH2NQiW9Q-1 X-Mimecast-MFC-AGG-ID: jtAj6-h7MyKVjDH2NQiW9Q_1764000775 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5944d65a8f5so2385944e87.1 for ; Mon, 24 Nov 2025 08:12:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764000775; x=1764605575; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aYpiH7WGW9wnhZ4Qa5eLJhW4o8twlPxgcc8Qxxb0NTo=; b=rZR4RQT9pO3DDa7bwMvJLbTtTSTmgGEFFN+9/+TsjPKbgQA3Nrsp7AuobvSlbdv35v 7NLDGeDacXIyaKCzV8eiYl45244zNJ5SxTkQYCkhqnwEyJFttQ7GUmZs9+vYBAmqwmsU iOkTbLt+92zSlWfRK9s/m0w89I3NvkS5n0Opyy7ukgfkTGqHlNhXp1/pSBuELoJRhwDp I/VXobdvAq5vf6dJb9s0xKge9nMrusGcWsYH2lx48SO0ll2Hw3drlDKvsd7u2IxK5Qf/ rABIiFFKWklWTDtdasfO58Ok4qRtXV7I8Pqpz3qbQvGpT8KE7W2f7euCWzPt8HXgir26 yMuw== X-Forwarded-Encrypted: i=1; AJvYcCXRPGLSc8yv/tLPsbm4XK6pWYu1Fk9E3OdSBjiiKJx8JfY4KSOSNngACnqu1Ur3rrczArg8F6E=@dpdk.org X-Gm-Message-State: AOJu0Yy5tpLJq0GUpNZ0344FBe9VyRQ4djdn3mrZll+rFqH6P0VWgPL3 Ztby584RMvm5VUKnfeCx+CyfQkSdA/izAdeb20p+fIUKJTylsO0bjRftKirEKH0B4a7nUHqlOxp difC0CP+sKgn2ScIQHOeHUrz9R7NK9b0Qmk5VpaeKkZ4e+MtR/S7Z/+R/LPnlAOAl68kLfU8S9X QHSYTfnXw9y5Pd9eEW5Z9ljHE= X-Gm-Gg: ASbGncs/RzKHS3T5Lp7kwA9uQbcJyDv2pMPU/UX2ToOOMg6U5IVnpzh8Qe9tdHsM5kh 8uR9l4y1ygQTJ3WwjPJ29kWAKKpXimzjOSUIvVj3cu2/SX+cQfPeap1cFIeLo3FtsV3/TMjmRxH +qwdLCo6o+lpZqgYpRq5sLgdwH/RcZ71rWaEPzAMwRadwqvXHXbUg0VfTMUS8zis1iQUR6 X-Received: by 2002:a05:6512:104a:b0:592:fc68:5b9d with SMTP id 2adb3069b0e04-596a3e9eb5emr4279590e87.10.1764000774871; Mon, 24 Nov 2025 08:12:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IHYDq7xobEIP1TwINMuoDbqjeuckq5VMm4NybH+wJEcfWBZYflu1qX/pIQw1gh1zytIyFiY+L+JyV8q93QTOXo= X-Received: by 2002:a05:6512:104a:b0:592:fc68:5b9d with SMTP id 2adb3069b0e04-596a3e9eb5emr4279579e87.10.1764000774356; Mon, 24 Nov 2025 08:12:54 -0800 (PST) MIME-Version: 1.0 References: <20250609095827.4174387-1-sivaprasad.tummala@amd.com> <20251106141631.179443-1-sivaprasad.tummala@amd.com> In-Reply-To: <20251106141631.179443-1-sivaprasad.tummala@amd.com> From: David Marchand Date: Mon, 24 Nov 2025 17:12:42 +0100 X-Gm-Features: AWmQ_bmLMd9F9WtggRjCzL8TjIiiprPzVplI4C905T3qGVfxRF5ZnfW3jyhP2LE Message-ID: Subject: Re: [PATCH v3] examples/l3fwd: add Tx burst size configuration option To: Sivaprasad Tummala Cc: =?UTF-8?Q?Morten_Br=C3=B8rup?= , Huisong Li , Chengwen Feng , Jie Hai , dev@dpdk.org, stable@dpdk.org, Venkat Kumar Ande , Dengdui Huang , Pavan Nikhilesh X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Q11mZIqDjkrmYAruou1fIbgNdo8i6eiZKlireuor4j0_1764000775 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, 6 Nov 2025 at 15:17, Sivaprasad Tummala wrote: > > Previously, the TX burst size in l3fwd was fixed at 256, which could > lead to suboptimal performance in certain scenarios. > > This patch introduces separate --rx-burst and --tx-burst options to > explicitly configure RX and TX burst sizes. By default, the TX burst > size now matches the RX burst size for better efficiency and pipeline > balance. > > Fixes: d5c4897ecfb2 ("examples/l3fwd: add option to set Rx burst size") > > Signed-off-by: Sivaprasad Tummala > Tested-by: Venkat Kumar Ande > Tested-by: Dengdui Huang > Tested-by: Pavan Nikhilesh > > v3: > - Added --tx-burst option to allow independent TX burst configuration > - Renamed --burst to --rx-burst for clarity > - Renamed variables for clarity: > - nb_pkt_per_burst =E2=86=92 rx_burst_size > - max_tx_burst =E2=86=92 tx_burst_size > - Modified parsing packet burst logic for RX and TX > - Default TX burst size now equals RX burst size > - Added logging of selected RX and TX burst sizes > - Updated documentation for --rx-burst and --tx-burst options Please don't put changelog in the commitlog itself. Fixed when applying... I also fixed [RT]X occurences as [RT]x. Applied, thanks. --=20 David Marchand