From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3462A0A0C for ; Wed, 7 Apr 2021 13:53:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA375140ED8; Wed, 7 Apr 2021 13:53:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 8E6C04013F for ; Wed, 7 Apr 2021 13:53:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617796430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2GWYp/y3uURKtNK4HmpZxRZp3uUInf1qTBqJgDBSMGY=; b=EYbYt88zFRS56j+Mw3i4j8MlU9abXown4K3FL9m80H4dkPHraPiNt9yBmufybr8ShbgXRV jmRBkz1AtO4u3pYmzOyOf3iiwVMgrEzSlyvTIvrnE8CKV4B3DPrE0KdZCiN+e05wJs/wSp E/OXUH209ETMqbv64wPS26tpoSv8osU= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-431-VClCldymOQywA6OnL7IK2Q-1; Wed, 07 Apr 2021 07:53:47 -0400 X-MC-Unique: VClCldymOQywA6OnL7IK2Q-1 Received: by mail-lf1-f70.google.com with SMTP id o11so9526919lfo.12 for ; Wed, 07 Apr 2021 04:53:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2GWYp/y3uURKtNK4HmpZxRZp3uUInf1qTBqJgDBSMGY=; b=iyBVFgBVa4VAL2PEDzV/QyDm0CGoGEAdK1yqfAS6uPlAQ7vbbe5pkzoMnYtYnD51+J ECSgAJedO41CMsrz3M963cAV3NoWpNgEkQfeCqsMn27hcdd7qLpn8nXhTVkXA2z5GCPv df9S7h3t5T3k3s+p7rM/FFVopWUrGaAIfztIjlGJquDawN8nyWfZMrx3/LFZ3Nlmsc43 V/+4jpj46uu8l31MBLQoCxO2irHtB+dVYL9rKZkDymD5nevyt0gCQ+o8O1HjldqTxAeV Q0tZxUkg/YBbTQ2Z8l2oFVenuo72/2f+rpUKvdlujrBraB1s5nut/BTeKx8VYMsaVwsI Ylkg== X-Gm-Message-State: AOAM533nYlMtmUCCuNedsVikQQ7n5+fTpscAUJ3lOHKGx6Tlezd8sSV1 FAYinofEHrycCUf30LW4F9ao+pCvL8uuHHPk6QcgzZWOO/6EH0O8rwR8VI2p2IXC9jIAOHme++J ZLc8ESxFjB0aqsMRRUTZebso= X-Received: by 2002:a2e:3005:: with SMTP id w5mr1740801ljw.493.1617796425523; Wed, 07 Apr 2021 04:53:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxK3N1OKF4TfW4qhfkKvt0xrVkwA5S1Ph0Aya/ZyNfADBVI2KfWN2NqNnkNvsp9qjEGdbqGMnnNkpeW+iq4co= X-Received: by 2002:a2e:3005:: with SMTP id w5mr1740775ljw.493.1617796425209; Wed, 07 Apr 2021 04:53:45 -0700 (PDT) MIME-Version: 1.0 References: <20210202070652.145861-1-haiyue.wang@intel.com> <20210204143949.22827-1-haiyue.wang@intel.com> In-Reply-To: From: David Marchand Date: Wed, 7 Apr 2021 13:53:34 +0200 Message-ID: To: Haiyue Wang , Qi Zhang Cc: dev , Paolo Valerio , Aaron Conole , Leyi Rong , "Tu, Lijuan" , "Ruifeng Wang (Arm Technology China)" , Feifei Wang , dpdk stable , Jeff Guo , Bruce Richardson , Konstantin Ananyev , Van Haaren Harry , Thomas Monjalon , "Yigit, Ferruh" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH v3] net/ixgbe: fix UDP zero checksum error X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Feb 25, 2021 at 11:54 AM David Marchand wrote: > > Hello Haiyue, > > On Thu, Feb 4, 2021 at 3:56 PM Haiyue Wang wrote: > > > > There is an 82599 errata that UDP frames with a zero checksum are > > incorrectly marked as checksum invalid by the hardware. This was > > leading to misleading PKT_RX_L4_CKSUM_BAD flag. > > > > This patch changes the bad UDP checksum to PKT_RX_L4_CKSUM_UNKNOWN, > > so the software application will then have to recompute the checksum > > itself if needed. > > > > Bugzilla ID: 629 > > Fixes: af75078fece3 ("first public release") > > Cc: stable@dpdk.org > > > > Reported-by: Paolo Valerio > > Signed-off-by: Haiyue Wang > > There was a previous mention of this issue in the past and it resulted > in dropping part of the hw statistics. > https://git.dpdk.org/dpdk/commit/?id=256ff05a9cae7484e2197cde4401dfa1f21d5a6f > > Does it make sense to restrict this "fix" to 82599 only? ping. -- David Marchand