From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64D69A0524 for ; Mon, 24 Feb 2020 11:32:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 14AF92C39; Mon, 24 Feb 2020 11:32:30 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 4CDDF2C39 for ; Mon, 24 Feb 2020 11:32:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582540348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A5tQbwJq0Pikl15hfR5+ShZYlldAEUbqTl1yAeU0kAE=; b=aycsF9cN+MvGk9EvM/qwOAqADp0xAFnTsLYMxaFfI9AXct/8RDKW8fIg1JyO28e+siiCvH TWNhwXW623EVyOb1D4uxB8ecB0lU81ly254J/L4tj6zVy9vLM5V9cGaXIjOi6N39rccn5o lnINVSv8jlEsHZLnyC9EqDqthf65MZE= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-GSOY7P_SOICYwjFsn8uaNQ-1; Mon, 24 Feb 2020 05:32:24 -0500 X-MC-Unique: GSOY7P_SOICYwjFsn8uaNQ-1 Received: by mail-vs1-f72.google.com with SMTP id x71so770789vsx.13 for ; Mon, 24 Feb 2020 02:32:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dnxkoUKfpEepUIUnCnBLETxMnO7cgGW8XKFYTGQGXao=; b=qvfChXoZ0JOhT1YhseeYXU9ArDgYimalCjFP05dlMA/hhO0evJ+uG0ALL7+JNbaedu AOkPoT6oH/77gm2/RNWuTu/0Eum33giukUDrbf0t0APGph0JoF2nkIGWw0/yvVPyEh2H zIkg+TFrlwZe2+YKlAmIhPne+Yr2I56mTZyG7gp+9YdWEOxt2gQP7XTKns5pFvj6Dtr9 Av+3P+h6afEH8GTP9xI8w4uDubqQbW3gE9v99SPkDmMeaqybdPFYiiym6FGDdmV17VnM V7YeLRGNGasdXk8UjHg3tOtqLbPbKS39uYJNRa6+wStJg+DC5DgmeCNAt1Nesu5f0D42 Ec0g== X-Gm-Message-State: APjAAAVNfr5PZClDekAFBP2SayP8vveFTx9ac3nShXfmAmmtI0EEpcBK 6TT5CdYDDnK24QDwpsrz1J4UxX4ccEjPirRYi8yIbNa+WOoC4WuhvaU1HGNIPo4bxbb9q5DKM2s MSVp7SBg7DeL1bQOohk083CY= X-Received: by 2002:a1f:4104:: with SMTP id o4mr23073939vka.80.1582540344234; Mon, 24 Feb 2020 02:32:24 -0800 (PST) X-Google-Smtp-Source: APXvYqzuslmm/Kfcj/RfNrwP/9H+qDXq7SSvyBtQILSRZqrFc0nxoKwblOMAuFva6wAW9UZw26uOzyQhEfmCwF73Xyc= X-Received: by 2002:a1f:4104:: with SMTP id o4mr23073924vka.80.1582540343924; Mon, 24 Feb 2020 02:32:23 -0800 (PST) MIME-Version: 1.0 References: <20200224145025.84899-1-yong.liu@intel.com> <20200224151419.85565-1-yong.liu@intel.com> In-Reply-To: From: David Marchand Date: Mon, 24 Feb 2020 11:32:12 +0100 Message-ID: To: Maxime Coquelin Cc: Marvin Liu , Tiwei Bie , Zhihong Wang , Thomas Monjalon , dev , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [PATCH v2] vhost: fix packed ring zero-copy X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Feb 24, 2020 at 9:28 AM Maxime Coquelin wrote: > > Hi David & Thomas, > > On 2/24/20 4:14 PM, Marvin Liu wrote: > > Available buffer ID should be stored in the zmbuf in the packed-ring > > dequeue path. There's no guarantee that local queue avail index is > > equal to buffer ID. > > > > Fixes: d1eafb532268 ("vhost: add packed ring zcopy batch and single deq= ueue") > > Cc: stable@dpdk.org > > > > Signed-off-by: Marvin Liu > > Reported-by: Yinan Wang > > Reviewed-by: Maxime Coquelin > > > > If it is not too late, I think we should pick this patch for > v20.02. It is fixing a regression introduced in DPDK v19.11. I might have cold feet, but taking this fix right now feels risky. If the problem has been there since 19.11, it can wait 20.05 and it will go to 19.11 after proper validation. --=20 David Marchand