From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4364DA0527 for ; Wed, 25 Nov 2020 10:10:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07869C93E; Wed, 25 Nov 2020 10:10:29 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id CB8F5C93E for ; Wed, 25 Nov 2020 10:10:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606295425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nqT0dQw4vbOuSuBzED4AFHTyUsPg4xmulpCTO/B8les=; b=PhX4cCt04o3mhifrrvT+CBn5Dj/QEoT/SIUNerZz3py3dlI3gqDH/Gz3lMQ/h11CRwVfhv J5KdzGGN0XLJyl1CzDgDEsmNHsYTDh3gw9Mcq3nS9+nK108Ct8B1Z6/+41K6gCDs/XGAch Ipxm0YwtWv8CHfd9wvzr7KIuoXGA1wQ= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-579-m8hZXFlOOw24e4LkRvp_WQ-1; Wed, 25 Nov 2020 04:10:22 -0500 X-MC-Unique: m8hZXFlOOw24e4LkRvp_WQ-1 Received: by mail-ua1-f71.google.com with SMTP id q90so791243uaq.12 for ; Wed, 25 Nov 2020 01:10:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nqT0dQw4vbOuSuBzED4AFHTyUsPg4xmulpCTO/B8les=; b=rN7MSA0PMS8tbIEaZdIwq+flWPXfycTvvhrpsoyJlPTSt+7MLPm4aEIoz+2LPgsVEQ j+Nq0TsnE2b7Wy05qjHe0kKw5jaeUk9z50O0yYD1M+SrPrm9CNoRGGYQPRyF2ywayUbV ZK7pRJ5r8vGlPR2/AIplhtFuypb91PTcYzyr6RCA0fs3rxmVvX1jhmB1egt0Gp+5GTkC aLBaVvx9Z2zAH181JmuC9ROs0AvZQ1+z7vmL6MHl0yC+rrRcB+opGm5snlxM5yIaTgm4 Dn2IK7Ye0SJEjero3o3l8Gni9xAEY5Y2WqLq6Fjz6CIlQwEq2HpdBClGLbSWvUgc4InP XeCg== X-Gm-Message-State: AOAM53384ZPZs1qtwlbXPrvMCEkSUgK3Sm0ABIOhSOszYEfTT2+X+8zX JFl3waDul6Namj24+zknDLZrIr/5cJtE0wWTug1XTbMe9fgxoBybQGlAWRKYL/xGbs3XWj2+eW9 VbaT+CmhKgbWKvEGaaucbk7U= X-Received: by 2002:ab0:2e9:: with SMTP id 96mr1071968uah.87.1606295421984; Wed, 25 Nov 2020 01:10:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJymIyyx9De3whK0zdsFuo5ZiOeXUkoTU44jLhV+q25o7nNJHDLR84vyLFYKVqJoBLdXo/LVv112+KmP/4JJNTA= X-Received: by 2002:ab0:2e9:: with SMTP id 96mr1071963uah.87.1606295421773; Wed, 25 Nov 2020 01:10:21 -0800 (PST) MIME-Version: 1.0 References: <1bbaefeb069a75f57a2f49b4217efa994bed5d4b.1606229937.git.tredaelli@redhat.com> In-Reply-To: <1bbaefeb069a75f57a2f49b4217efa994bed5d4b.1606229937.git.tredaelli@redhat.com> From: David Marchand Date: Wed, 25 Nov 2020 10:10:10 +0100 Message-ID: To: Timothy Redaelli Cc: Anatoly Burakov , Bruce Richardson , dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH 1/2] eal: fix shared lib mode detection X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Nov 24, 2020 at 4:15 PM Timothy Redaelli wrote: > > Commit 06c7871dde01 ("eal: restrict default plugin path to shared lib mode") > introduced a check that enabled shared lib mode when librte_eal.so can > be loaded, but it can't work, at least, on Fedora/CentOS/RHEL since .so > symlinks are not installed when you install dpdk package, but only when > you install dpdk-devel package. > > This commit uses librte_eal.so.ABI_VERSION to check for shared lib, > since it exists on any linux distributions. > > See Fedora Packaging Guidelines for more informations: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages > > Fixes: 06c7871dde01 ("eal: restrict default plugin path to shared lib mode") > Cc: bruce.richardson@intel.com > Cc: stable@dpdk.org > Signed-off-by: Timothy Redaelli Same comment as Bruce on the != NULL location, but otherwise lgtm. Acked-by: David Marchand -- David Marchand