From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA3D0A052B for ; Wed, 29 Jul 2020 17:59:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CE5123B5; Wed, 29 Jul 2020 17:59:46 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 94F1F3B5 for ; Wed, 29 Jul 2020 17:59:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596038384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/AqU+vxPlKwxcjXjrStKn1Jx+uPVtMR9G+VnFGTAE2M=; b=i48gs5nNfYWAgZJa2VpwGdDpxLl/bkfwwFS40K94VtToTUIRUNVeWLIiCypSPFFtmph5RO T5HnJcTj4ODbrkveIMiDY7+bLmLymLKF4aIsbWtUHzkXsVw/8VPZ/aMBF3Mp2eCOa8dt4H d1Bk3B4E9l61AjfDapHiG12YwTwu/6c= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-312-eb9csMXQPhqQvzxML95hLA-1; Wed, 29 Jul 2020 11:59:42 -0400 X-MC-Unique: eb9csMXQPhqQvzxML95hLA-1 Received: by mail-vk1-f200.google.com with SMTP id m1so7722163vkl.11 for ; Wed, 29 Jul 2020 08:59:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/AqU+vxPlKwxcjXjrStKn1Jx+uPVtMR9G+VnFGTAE2M=; b=DA5wUf0RurHasfN37YhiwZzO4DbzbmXRTxowRc/QvvQnFMqB665ti4GN5xAtX9SFZ6 I8D4WDRpZ/QXU396wpk9VSZ1tQAMimBy9CHyVwtkVukgKNNYYzK1dThhjp+GfDB8oDm0 5sloVdoi78Tr5SZoqgK6rrEBD7ba3qdya2OfJ2T+MYxxG1Hoz15IWIwr96X4dkysDZHN jLOhwqm4AafRJW1718VIs9aY1mQYCeHOWzfpwknzZI4KulpjmI/QrCsB4EoYU76JbypL iwIk+0V4CnHxcdg3p4tAtGgOkOa3N+HPMEs64Ie0TEgkcRQ3zipQ1G9aMknACCb787AV YSBA== X-Gm-Message-State: AOAM532WyfXvxBu8m+muyUXhRnk013SSZKcOJ2ET7eK2zDXXH64vY1hs Sxlm6nlhTzzW6Vbq78GIBlnXMDpCYkpnohIkWQiqA4oTL8duePxBA42afyEFASrxfUe2/0g0Xgh X2fhzfGnSZfMXOzuZD+v8lBg= X-Received: by 2002:a67:cb9c:: with SMTP id h28mr24202338vsl.39.1596038381705; Wed, 29 Jul 2020 08:59:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyI0TfxlSNn8oD7x9kP9ASVbZ1n4vgKl/88wxar3uGpIWiT9nSl1Mo/pp6RFvMTevgn1IAqWXBColr3gFJqHmA= X-Received: by 2002:a67:cb9c:: with SMTP id h28mr24202316vsl.39.1596038381395; Wed, 29 Jul 2020 08:59:41 -0700 (PDT) MIME-Version: 1.0 References: <20200729063105.11299-1-feifei.wang2@arm.com> <20200729063105.11299-2-feifei.wang2@arm.com> In-Reply-To: <20200729063105.11299-2-feifei.wang2@arm.com> From: David Marchand Date: Wed, 29 Jul 2020 17:59:30 +0200 Message-ID: To: Feifei Wang , "Ananyev, Konstantin" , Honnappa Nagarahalli , Olivier Matz Cc: dev , nd , dpdk stable , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1 1/2] ring: fix the misdescription of the param X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, Jul 29, 2020 at 8:31 AM Feifei Wang wrote: > > When enqueue one element to the ring, the param "obj" should be the > object to be added into the ring. The object is of type void*. I understand void * as a pointer to an object you don't know the type of. I would keep the current description. Honnappa, Konstantin, Olivier ? > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > --- > lib/librte_ring/rte_ring.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h > index da17ed6d7..418536b61 100644 > --- a/lib/librte_ring/rte_ring.h > +++ b/lib/librte_ring/rte_ring.h > @@ -276,7 +276,7 @@ rte_ring_enqueue_bulk(struct rte_ring *r, void * const *obj_table, > * @param r > * A pointer to the ring structure. > * @param obj > - * A pointer to the object to be added. > + * A pointer (object) to be added. -- David Marchand