* [PATCH] app/testpmd: fix help string of BPF load command
@ 2024-06-24 1:58 Chaoyong He
2024-06-24 15:45 ` Konstantin Ananyev
0 siblings, 1 reply; 3+ messages in thread
From: Chaoyong He @ 2024-06-24 1:58 UTC (permalink / raw)
To: dev
Cc: oss-drivers, Chaoyong He, konstantin.ananyev, stable, Long Wu,
Peng Zhang
Based on the logic of 'bpf_parse_flags()' and the 'bpf-load' section of
'testpmd_funcs.rst' document, the 'B' flag in the help string of
bpf-load command should be '-'.
Fixes: e977e4199a8d ("app/testpmd: add commands to load/unload BPF filters")
Cc: konstantin.ananyev@intel.com
Cc: stable@dpdk.org
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
app/test-pmd/bpf_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/bpf_cmd.c b/app/test-pmd/bpf_cmd.c
index 46f6b7d6d2..24d34f983e 100644
--- a/app/test-pmd/bpf_cmd.c
+++ b/app/test-pmd/bpf_cmd.c
@@ -139,7 +139,7 @@ static cmdline_parse_token_string_t cmd_load_bpf_prm =
cmdline_parse_inst_t cmd_operate_bpf_ld_parse = {
.f = cmd_operate_bpf_ld_parsed,
.data = NULL,
- .help_str = "bpf-load rx|tx <port> <queue> <J|M|B> <file_name>",
+ .help_str = "bpf-load rx|tx <port> <queue> <J|M|-> <file_name>",
.tokens = {
(void *)&cmd_load_bpf_start,
(void *)&cmd_load_bpf_dir,
--
2.39.1
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] app/testpmd: fix help string of BPF load command
2024-06-24 1:58 [PATCH] app/testpmd: fix help string of BPF load command Chaoyong He
@ 2024-06-24 15:45 ` Konstantin Ananyev
2024-07-09 12:22 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Konstantin Ananyev @ 2024-06-24 15:45 UTC (permalink / raw)
To: Chaoyong He, dev
Cc: oss-drivers, konstantin.ananyev, stable, Long Wu, Peng Zhang
> Based on the logic of 'bpf_parse_flags()' and the 'bpf-load' section of
> 'testpmd_funcs.rst' document, the 'B' flag in the help string of
> bpf-load command should be '-'.
>
> Fixes: e977e4199a8d ("app/testpmd: add commands to load/unload BPF filters")
> Cc: konstantin.ananyev@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
> ---
> app/test-pmd/bpf_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/bpf_cmd.c b/app/test-pmd/bpf_cmd.c
> index 46f6b7d6d2..24d34f983e 100644
> --- a/app/test-pmd/bpf_cmd.c
> +++ b/app/test-pmd/bpf_cmd.c
> @@ -139,7 +139,7 @@ static cmdline_parse_token_string_t cmd_load_bpf_prm =
> cmdline_parse_inst_t cmd_operate_bpf_ld_parse = {
> .f = cmd_operate_bpf_ld_parsed,
> .data = NULL,
> - .help_str = "bpf-load rx|tx <port> <queue> <J|M|B> <file_name>",
> + .help_str = "bpf-load rx|tx <port> <queue> <J|M|-> <file_name>",
> .tokens = {
> (void *)&cmd_load_bpf_start,
> (void *)&cmd_load_bpf_dir,
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> 2.39.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] app/testpmd: fix help string of BPF load command
2024-06-24 15:45 ` Konstantin Ananyev
@ 2024-07-09 12:22 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2024-07-09 12:22 UTC (permalink / raw)
To: Chaoyong He
Cc: Konstantin Ananyev, dev, oss-drivers, konstantin.ananyev, stable,
Long Wu, Peng Zhang
On Mon, Jun 24, 2024 at 5:46 PM Konstantin Ananyev
<konstantin.ananyev@huawei.com> wrote:
>
> > Based on the logic of 'bpf_parse_flags()' and the 'bpf-load' section of
> > 'testpmd_funcs.rst' document, the 'B' flag in the help string of
> > bpf-load command should be '-'.
> >
> > Fixes: e977e4199a8d ("app/testpmd: add commands to load/unload BPF filters")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> > Reviewed-by: Long Wu <long.wu@corigine.com>
> > Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-09 12:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-24 1:58 [PATCH] app/testpmd: fix help string of BPF load command Chaoyong He
2024-06-24 15:45 ` Konstantin Ananyev
2024-07-09 12:22 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).