From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F19ADA00C2 for ; Fri, 6 Jan 2023 11:27:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CCF76400EF; Fri, 6 Jan 2023 11:27:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AD551400D4 for ; Fri, 6 Jan 2023 11:26:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673000819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ysWUikHmnHPt/WJNB4PFcCz60hU9o0mYjaDF/8MYOsU=; b=jVS+ULSB7zahSyG9oKwKWiHCj4MuyG29bxbuJj0q9Ir9IC9BTxzmqNCreRITlBowBwiNaU etM68y89RyhtvwmMMEgyE6Fzj7zlg16QnqC+IDrYS1FvgohNTHk1eRnyiNwJ5LxYLO9lfT 14R/HIcexP41JPqWhkSuX3P/5TexamA= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-668-w8ZYhICVO0iXPpE5-wXyWg-1; Fri, 06 Jan 2023 05:26:58 -0500 X-MC-Unique: w8ZYhICVO0iXPpE5-wXyWg-1 Received: by mail-pf1-f200.google.com with SMTP id a18-20020a62bd12000000b0056e7b61ec78so673760pff.17 for ; Fri, 06 Jan 2023 02:26:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ysWUikHmnHPt/WJNB4PFcCz60hU9o0mYjaDF/8MYOsU=; b=7ES7W0LMZ7JsvJycZfC4LZH4R6JL3SnKRJZdC1JG9TldsfHF/Q8Pm39ZVwzbk0MQGS RmP/R7DqokYUtylXzMD0zlCRlk1+ytL6vUDmEERiubBhl59AyBwnDMCZcwFCjPpdseVo qPSIN43WKVEVpHu2/8XUu2llSjwFww3zhlmelNl5xbe7UpMP/YXvQwcJxUmojqLz1I8n Ut2gzwPSoOUNAdxyf6vjjhrEkTHtx43G5/1Oi5rzeKxkmv+8ysSnE6csD9MmOtaCpFQF mR6AehEvn4cIfL0qNgHn+tbDp5sECQUBTxjndXSgWoeZtwfcQmfA3xBq5GtlSO045rhD dqRg== X-Gm-Message-State: AFqh2kqsYe+f0Gn/ezxHdiUQSjEiHCTxTZORp68HAP3pxd8/F0Qcb2Xk +BXYzAngYIwIsB75o/QMvy+nIrR8kLR10LYID9/biEsAfwJeMRPNIhiviX4uSvtJZ9TqiKkuSKQ h8Zh3HXpekJJc1st4tVlmJTY= X-Received: by 2002:a17:902:efcb:b0:186:971b:b7e5 with SMTP id ja11-20020a170902efcb00b00186971bb7e5mr2729662plb.54.1673000817162; Fri, 06 Jan 2023 02:26:57 -0800 (PST) X-Google-Smtp-Source: AMrXdXvTMwdJhd4kdMnUZS52zSPlxXqHO+aNpBGkzcQzy2DsUvchYkY7hyOxjQpoL9iwAPas2Z/jwicj2jCR9tRBF7E= X-Received: by 2002:a17:902:efcb:b0:186:971b:b7e5 with SMTP id ja11-20020a170902efcb00b00186971bb7e5mr2729652plb.54.1673000816858; Fri, 06 Jan 2023 02:26:56 -0800 (PST) MIME-Version: 1.0 References: <20230106101520.2736826-1-ruifeng.wang@arm.com> In-Reply-To: <20230106101520.2736826-1-ruifeng.wang@arm.com> From: David Marchand Date: Fri, 6 Jan 2023 11:26:45 +0100 Message-ID: Subject: Re: [PATCH] crypto/openssl: fix warning on copy length To: Kai Ji , Ruifeng Wang Cc: Fan Zhang , Akhil Goyal , dev@dpdk.org, nd@arm.com, stable@dpdk.org, Feifei Wang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, Jan 6, 2023 at 11:16 AM Ruifeng Wang wrote: > > When building with gcc 11.2.0, the compiler warns as follows: > In function 'memcpy', > inlined from 'openssl_set_session_auth_parameters' at ../drivers/crypto/openssl/rte_openssl_pmd.c:699:3, > inlined from 'openssl_set_session_parameters' at ../drivers/crypto/openssl/rte_openssl_pmd.c:826:9: > /usr/include/aarch64-linux-gnu/bits/string_fortified.h:29:10: warning: '__builtin_memcpy' forming offset [4, 8] is out of the bounds [0, 4] [-Warray-bounds] > > Fixed the warning by copying up to string size. > > Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API") > Cc: stable@dpdk.org > Cc: kai.ji@intel.com > > Signed-off-by: Ruifeng Wang > Reviewed-by: Feifei Wang > --- > drivers/crypto/openssl/rte_openssl_pmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c > index 05449b6e98..8458ad487a 100644 > --- a/drivers/crypto/openssl/rte_openssl_pmd.c > +++ b/drivers/crypto/openssl/rte_openssl_pmd.c > @@ -696,7 +696,7 @@ openssl_set_session_auth_parameters(struct openssl_session *sess, > algo = digest_name_get(xform->auth.algo); > if (!algo) > return -EINVAL; > - rte_memcpy(algo_name, algo, (sizeof(algo)+1)); > + rte_memcpy(algo_name, algo, strlen(algo) + 1); Why is there a need for copying such a string to a local storage? If it is really needed, we are dealing with strings, so I suggest: strlcpy(algo_name, algo, sizeof(algo_name)); -- David Marchand