From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 051A84269E for ; Mon, 2 Oct 2023 10:26:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F34B1402CE; Mon, 2 Oct 2023 10:26:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 70DE84003C for ; Mon, 2 Oct 2023 10:26:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696235177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9M7IS44gJqhpmyyspXI9UXL5CCaVbxv4CY7Q8NdLx1o=; b=DF3yzp0EwuyZhRgv0u9Sg3ov/3u4DA5Z1OrfMWPhggUy6uql4lHiw3PPihDXV+J4ekGzTe vWU/x5aSlOfTOtG0BGo+5YNLLUmb8TzCHqHHo3fzz8+aLKihsm4WaeC+rKttitrj+oftuT okKF/Fc0SodsgUuvbc/e0PhIwrEt9QY= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-58-t0j8_JNxP5mPmo-v3_yscw-1; Mon, 02 Oct 2023 04:26:05 -0400 X-MC-Unique: t0j8_JNxP5mPmo-v3_yscw-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-50433ca6d81so19965396e87.3 for ; Mon, 02 Oct 2023 01:26:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696235164; x=1696839964; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9M7IS44gJqhpmyyspXI9UXL5CCaVbxv4CY7Q8NdLx1o=; b=usL4rfqfS5jQL5Cv55ZPZE3AWOuG6D12QhTBSffx6LA6X91J7BpUNsDRhh/j7kZzBA TDZxCt2xQ5eMyneHaRBjOarKLL6RgXyZ8sYN/qYCyYQu7Vw8E/XJBKOkHsV+eV6hiR2F vzv/ndesBqWKBHYrJIMHABNgf9VF5lmXWEl0XbIcCrFeU2gQf4OX+rL8Avs3jRdB0tEw PxJAomoOSCrV/hwbndqWkUICU7jaydIVUiqO//Ha5sM8/mJW5MxCSPvSbDDnu9/pp7Xt FTVK5F+G1WXwV7k86cQaLgP40DjJP0fwhnHr3BHW4LklmeekqMAd1Z1AA/LLpXEuW+l2 8pcw== X-Gm-Message-State: AOJu0YwfD3Pu9gu7jcVvF2FpqxLyxmLU0dX/vdPISpoQWhB46mCAg5Wd zD+eDVM7sXKbElbN4TrtqP9U50zEw+yKdYWguc9fEdTVlR6QwZJZ+4cubixT2euRvD5ZVOeqSkw 1/4zK5FbF3Xr0znZ8tCjLFl45v4DR4rjoig== X-Received: by 2002:a2e:9b1a:0:b0:2bf:fa62:5ceb with SMTP id u26-20020a2e9b1a000000b002bffa625cebmr8645956lji.11.1696235164300; Mon, 02 Oct 2023 01:26:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmmRcYZbi4NvNWPQbqqoXguVLASxjzOFZmsw4BYUikDdtOyECkphTTgrRU7sbtDwwbJki1yQwxb5uMwrXl1iw= X-Received: by 2002:a2e:9b1a:0:b0:2bf:fa62:5ceb with SMTP id u26-20020a2e9b1a000000b002bffa625cebmr8645945lji.11.1696235164028; Mon, 02 Oct 2023 01:26:04 -0700 (PDT) MIME-Version: 1.0 References: <366f5750e01894c56d5d486c75d312e85c404277.1693224396.git.anatoly.burakov@intel.com> In-Reply-To: <366f5750e01894c56d5d486c75d312e85c404277.1693224396.git.anatoly.burakov@intel.com> From: David Marchand Date: Mon, 2 Oct 2023 10:25:52 +0200 Message-ID: Subject: Re: [PATCH v1 1/1] eal/random: fix random state initialization for non-eal threads To: Anatoly Burakov , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Stephen Hemminger Cc: dev@dpdk.org, Bruce Richardson , stable@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hello guys, On Mon, Aug 28, 2023 at 2:07=E2=80=AFPM Anatoly Burakov wrote: > > Currently, the rte_rand() state is initialized with seed, and each > rand state is initialized up until RTE_MAX_LCORE'th rand state. However, > rand state also has one extra rand state reserved for non-EAL threads, > which is not initialized. Fix it by initializing this extra state. > > Fixes: 3f002f069612 ("eal: replace libc-based random generation with LFSR= ") > Cc: mattias.ronnblom@ericsson.com > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov We have two series for fixing related issues. Stephen alternative patch 1 handles Anatoly fix here. https://patchwork.dpdk.org/project/dpdk/list/?series=3D29449&state=3D%2A&ar= chive=3Dboth I see Anatoly was acked by Mattias and Morten, though Stephen (RTE_DIM) fix is more elegant. How do you guys want me to proceed? Thanks. --=20 David Marchand