From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC3B143382 for ; Wed, 22 Nov 2023 17:37:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C610E410F1; Wed, 22 Nov 2023 17:37:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2912240265 for ; Wed, 22 Nov 2023 17:37:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700671019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hVmZDM6IQrmuVFXtzMQbALGK3HH6FQBbpkbdrxjslEo=; b=NVa40HkCsxjy53sWuaM9xa1siFSuMomdoE/GCZN1dplHgLqMQCpLss3NMRmvd5ql7hj4ZQ oPQ76QR90LMNNchx36VbA3MnHKijlni5bSsTimiFfy1iu/AJS9yN5xa/yI5XuvRel/5HPs 7NYXwVic+x/05Kgcs+FF0qWqATeBlWc= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-297-iC5KrzfkPdubghnuMpZa3A-1; Wed, 22 Nov 2023 11:36:58 -0500 X-MC-Unique: iC5KrzfkPdubghnuMpZa3A-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c88e978e8fso15489291fa.3 for ; Wed, 22 Nov 2023 08:36:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700671017; x=1701275817; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hVmZDM6IQrmuVFXtzMQbALGK3HH6FQBbpkbdrxjslEo=; b=LV8HyKYXWEhzaO4MwDhgSLXq+IJxNp6TsWplhRRwtfVCCfqIszrQRIko/T3tgM2TQb ytlDDkbbFqdN/XC3VxAbIrjZ0HiGp5h4b/AgjvaIwTAxWEbfftgOPKLmax52LxZj82z6 3/jPcdNxdstxarJxcboUmfgFyAtTTAbeZlybq2GNw2EJx3B1ZllnSgoyppCek7vLe4pX cOWd+Vfgvhi9hsJVSCUM9wtdafwzGR0PFvbNky/+v66CRUGJk8AVAjP9Y11VbgOFEWRo KqRMOA4g3jNaDHjWLyrRxY9jrbQQJrFhVGVRKOoI2CJptdLEHAYCKGgv4NEaxsQNUzLW rSKg== X-Gm-Message-State: AOJu0YyMpm7Zj0etO4LC40ZIEIeIJfHhBNWd/RKnTu99IZgmlQnuGWwE SjS4KvePWn+quGwcLcnNvnRnPM70xI60MZdmafZOuN+H7LHa+yy4w20EyEiiR5ytdppOrsHbk6R dm7dNt8b3KfV7iqtmvar7TZw= X-Received: by 2002:a2e:960e:0:b0:2c5:18ed:1802 with SMTP id v14-20020a2e960e000000b002c518ed1802mr1686572ljh.34.1700671016813; Wed, 22 Nov 2023 08:36:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTDoBYHQZLhzH6vIzG7G8tcCKdD4ANz6WEEB12NLuFZYAlKC10WTffLo2Hk11mkcBltk2239EbwYqP1vqoLc0= X-Received: by 2002:a2e:960e:0:b0:2c5:18ed:1802 with SMTP id v14-20020a2e960e000000b002c518ed1802mr1686555ljh.34.1700671016515; Wed, 22 Nov 2023 08:36:56 -0800 (PST) MIME-Version: 1.0 References: <20231122163228.986037-1-bruce.richardson@intel.com> In-Reply-To: <20231122163228.986037-1-bruce.richardson@intel.com> From: David Marchand Date: Wed, 22 Nov 2023 17:36:44 +0100 Message-ID: Subject: Re: [PATCH] eal/windows: fix mingw build To: Bruce Richardson Cc: dev@dpdk.org, Tyler Retzlaff , dmitry.kozliuk@gmail.com, stable@dpdk.org, Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Nov 22, 2023 at 5:32=E2=80=AFPM Bruce Richardson wrote: > > When compiling with mingw on Ubuntu 23.10, I get the following compiler > error: > > ../../lib/eal/windows/eal_memory.c:77: error: "MEM_REPLACE_PLACEHOLDER" r= edefined [-Werror] > 77 | #define MEM_REPLACE_PLACEHOLDER 0x00004000 > | > In file included from /usr/share/mingw-w64/include/minwindef.h:163, > from /usr/share/mingw-w64/include/windef.h:9, > from /usr/share/mingw-w64/include/windows.h:69, > from ../../lib/eal/windows/include/rte_windows.h:32, > from ../../lib/eal/windows/include/rte_os_shim.h:9, > from ../../lib/eal/common/eal_internal_cfg.h:14, > from ../../lib/eal/windows/eal_memory.c:11: > /usr/share/mingw-w64/include/winnt.h:5710: note: this is the location of = the previous definition > 5710 | #define MEM_REPLACE_PLACEHOLDER 0x4000 > > and a similar error for MEM_RESERVE_PLACEHOLDER. These errors can be > fixed by wrapping the two defines in #ifndef .. #endif blocks. > > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management") > Cc: dmitry.kozliuk@gmail.com > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson Probably a duplicate of https://patchwork.dpdk.org/project/dpdk/patch/20231114170529.176665-1-getel= son@nvidia.com/ --=20 David Marchand