patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] lib/table: fix table autotest ut crashes in ipv6
@ 2019-07-02 11:21 Jananee Parthasarathy
  2019-07-02 11:46 ` David Marchand
  0 siblings, 1 reply; 4+ messages in thread
From: Jananee Parthasarathy @ 2019-07-02 11:21 UTC (permalink / raw)
  To: dev
  Cc: reshma.pattan, david.marchand, cristian.dumitrescu,
	jasvinder.singh, Jananee Parthasarathy, stable

Unit test table_autotest results in segmentation fault.
Crash occurs in test_table_lpm_ipv6_combined().

Variable 'nht_pos0' used as array subscript is not initialized
in rte_table_lpm_ipv6_entry_add(). It will not be assigned,
if a rule does not exist.

In such case a junk number or invalid array index might result in
segmentation fault due to array out of bounds when
lpm->nht_users is used with such invalid array index.

Fix is to initialize the variables used for array subscript.

Fixes: d89a5bce1d ("lpm6: extend next hop field")
Cc: stable@dpdk.org

Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
---
 lib/librte_table/rte_table_lpm_ipv6.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_table/rte_table_lpm_ipv6.c b/lib/librte_table/rte_table_lpm_ipv6.c
index a55f808a4..4e068d79b 100644
--- a/lib/librte_table/rte_table_lpm_ipv6.c
+++ b/lib/librte_table/rte_table_lpm_ipv6.c
@@ -182,7 +182,7 @@ rte_table_lpm_ipv6_entry_add(
 	struct rte_table_lpm_ipv6 *lpm = table;
 	struct rte_table_lpm_ipv6_key *ip_prefix =
 		key;
-	uint32_t nht_pos, nht_pos0, nht_pos0_valid;
+	uint32_t nht_pos = 0, nht_pos0 = 0, nht_pos0_valid = 0;
 	int status;
 
 	/* Check input parameters */
-- 
2.14.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-07-04 21:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-02 11:21 [dpdk-stable] [PATCH] lib/table: fix table autotest ut crashes in ipv6 Jananee Parthasarathy
2019-07-02 11:46 ` David Marchand
2019-07-02 11:50   ` Dumitrescu, Cristian
2019-07-04 21:25     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).