patches for DPDK stable branches
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, "Harry van Haaren" <harry.van.haaren@intel.com>,
	"Bruce Richardson" <bruce.richardson@intel.com>,
	"David Hunt" <david.hunt@intel.com>,
	"Anatoly Burakov" <anatoly.burakov@intel.com>,
	"Morten Brørup" <mb@smartsharesystems.com>,
	"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
	stable@dpdk.org
Subject: Re: [PATCH 1/2] event/sw: fix missing flow ID init in selftest
Date: Mon, 17 Oct 2022 09:30:26 +0200	[thread overview]
Message-ID: <CAJFAV8yYkERC96dz99ZXDv4u_XZbQ3aRdSb6XsJNHx6wiWAcKQ@mail.gmail.com> (raw)
In-Reply-To: <20221014203710.6172-1-olivier.matz@6wind.com>

On Fri, Oct 14, 2022 at 10:38 PM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> The issue is seen by unit tests:
>
> > root@dpdk-VF-dut247:~/dpdk# MALLOC_PERTURB_=204 \
> >   DPDK_TEST=eventdev_selftest_sw \
> >   /root/dpdk/x86_64-native-linuxapp-gcc/app/test/dpdk-test -c 0xff
> > (...)
> > *** Running XStats ID Reset test...
> > 12: 1761: qid_0_port_2_pinned_flows value , expected 1 got 7
> > 1778: qid_0_port_2_pinned_flows value incorrect, expected 1 got 7
> > ERROR - XStats ID Reset test FAILED.
> > SW Eventdev Selftest Failed.
> > Test Failed
>
> The flow id is not set in the event, which results in an undefined
> flow, whose value depends on what was previously in stack. Having
> different flows for the packets makes the test to fail, since only one
> flow is expected.
>
> This only happens in -O3, where the same stack area is shared by the
> event object and the address of the mbuf allocated in rte_gen_arp().

Good catch.
That's scary...


>
> Fix this by properly initializing the flow id.
>
> Bugzilla ID: 1101
> Fixes: e21df4b062b5 ("test/eventdev: add SW xstats tests")
> Cc: stable@dpdk.org
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


      parent reply	other threads:[~2022-10-17  7:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14 20:37 Olivier Matz
2022-10-14 20:37 ` [PATCH 2/2] event/sw: fix invalid log " Olivier Matz
2022-10-19 14:07   ` Jerin Jacob
2022-10-15  8:25 ` [PATCH 1/2] event/sw: fix missing flow ID init " Morten Brørup
2022-10-17  7:30 ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8yYkERC96dz99ZXDv4u_XZbQ3aRdSb6XsJNHx6wiWAcKQ@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=anatoly.burakov@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bruce.richardson@intel.com \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=mb@smartsharesystems.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).