From: David Marchand <david.marchand@redhat.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: dpdk stable <stable@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
Luca Boccassi <bluca@debian.org>,
Xueming Li <xuemingl@nvidia.com>,
Kevin Traynor <ktraynor@redhat.com>
Subject: Re: [PATCH] 5-make-release-commit: fix rstheader
Date: Fri, 7 Jan 2022 11:00:35 +0100 [thread overview]
Message-ID: <CAJFAV8ya1z0WONorKdjf2c-f1X2hocjXw2QsQ4O4KtzbdWbCQw@mail.gmail.com> (raw)
In-Reply-To: <20220107095002.1253288-1-christian.ehrhardt@canonical.com>
On Fri, Jan 7, 2022 at 10:50 AM <christian.ehrhardt@canonical.com> wrote:
>
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
>
> The printf magic fails trying to interpret "-" as option and thereby breaking
> the top level headers.
> printf: -%: invalid option
> printf: usage: printf [-v var] format [arguments]
That's getopt that caught the -.
You could also fix by prefixing with --:
- printf "${rchar}%.0s" $(seq 1 ${#msg})
+ printf -- "${rchar}%.0s" $(seq 1 ${#msg})
>
> Instead of relying printf expansion, fall back to the more trivial
> printf n times which works with any char.
>
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
> 5-make-release-commit | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/5-make-release-commit b/5-make-release-commit
> index 374154f..00acf92 100755
> --- a/5-make-release-commit
> +++ b/5-make-release-commit
> @@ -29,7 +29,7 @@ function rstheader()
>
> echo
> echo "${msg}"
> - printf "${rchar}%.0s" $(seq 1 ${#msg})
> + for i in $(seq 1 ${#msg}); do printf "${rchar}"; done
> # break after line plus one empty line
> echo
> echo
Either form works for me.
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2022-01-07 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 9:50 christian.ehrhardt
2022-01-07 10:00 ` David Marchand [this message]
2022-01-07 10:04 ` Christian Ehrhardt
2022-01-10 14:50 ` Kevin Traynor
2022-01-11 7:51 ` Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8ya1z0WONorKdjf2c-f1X2hocjXw2QsQ4O4KtzbdWbCQw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=ktraynor@redhat.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).