From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6250A04A6 for ; Fri, 7 Jan 2022 11:00:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99A9040042; Fri, 7 Jan 2022 11:00:52 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 00E5040042 for ; Fri, 7 Jan 2022 11:00:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641549651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=du9zEnznRg8PtqU7MThwuript07qOZwo+GWiGYHuOwI=; b=AySs2RRhWaFGAlha9CW/u0P5c2kPRl0o+CJjUAm/wu5DltBYNoDfMwwiwL5SZOpCYAvd3q S9ItSD0djoahAItAFj+Uj262OZllnUx+C+H3OLb4oQDdlmAlbpYvksNM7HcAlWgOb0eDt4 fovHUAJrqX7LiAe403OnJy5s0JO3sPU= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-261-oJ80ANVhOWmr4eARQTJKFQ-1; Fri, 07 Jan 2022 05:00:48 -0500 X-MC-Unique: oJ80ANVhOWmr4eARQTJKFQ-1 Received: by mail-lf1-f71.google.com with SMTP id h7-20020ac24da7000000b0042521f16f1fso1972459lfe.21 for ; Fri, 07 Jan 2022 02:00:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=du9zEnznRg8PtqU7MThwuript07qOZwo+GWiGYHuOwI=; b=t0xqzcVt4cXS7zE1qpPlIzsyxB/yH2UHmbdZrhZsfO8cl/Q3mAxWahMiXR088sIQvS Rw2oF93U7YkcU/U+jgmkjHkqO76dcmz/dgKkxr0GaupNLZfw299b0RVxmISmEIPZzFfn jIGPRNwomg88sUmHDI4wASmpqhHHk9AGYTJmnstNCYaTRXJigj6QVppXtqXws3LjZePS 0ZsGZ0v4byXLm7FWH1nlWOT24hcqM2+kZWOOjye1vbWF+xSzoGVEdkJp8+ERj0+kuwx+ jM+ZCIX+hmA6Talo7HjSsvcdFk9A9yojJNL06grGwSUUUvuocliEMKbdPc+W41pdCsYj 2tLQ== X-Gm-Message-State: AOAM530di4cVuuiXLiAZP1UK0z3Xp/kevUQXk5IKBYkQfNrD4+zUTe5F Um8kyjwzhPMUoTONkCU/GTh4yqnC4QaATDOOc08Ti7Wi0zvLpRKFtKS8fvtVU6gqr+y+yXIhF7d P6kxWkMXgw1jKJWgCeLrkSlI= X-Received: by 2002:a2e:81d9:: with SMTP id s25mr45080293ljg.46.1641549646719; Fri, 07 Jan 2022 02:00:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJwhuJwrMSw8beyRYKDPmmkP/TwKmvwGV50xedeWtSr6CRS7eVu+mqfEK6TtM/jajzVIu02B3c+FFwlRey9YZbU= X-Received: by 2002:a2e:81d9:: with SMTP id s25mr45080280ljg.46.1641549646472; Fri, 07 Jan 2022 02:00:46 -0800 (PST) MIME-Version: 1.0 References: <20220107095002.1253288-1-christian.ehrhardt@canonical.com> In-Reply-To: <20220107095002.1253288-1-christian.ehrhardt@canonical.com> From: David Marchand Date: Fri, 7 Jan 2022 11:00:35 +0100 Message-ID: Subject: Re: [PATCH] 5-make-release-commit: fix rstheader To: Christian Ehrhardt Cc: dpdk stable , Thomas Monjalon , Luca Boccassi , Xueming Li , Kevin Traynor Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, Jan 7, 2022 at 10:50 AM wrote: > > From: Christian Ehrhardt > > The printf magic fails trying to interpret "-" as option and thereby breaking > the top level headers. > printf: -%: invalid option > printf: usage: printf [-v var] format [arguments] That's getopt that caught the -. You could also fix by prefixing with --: - printf "${rchar}%.0s" $(seq 1 ${#msg}) + printf -- "${rchar}%.0s" $(seq 1 ${#msg}) > > Instead of relying printf expansion, fall back to the more trivial > printf n times which works with any char. > > Signed-off-by: Christian Ehrhardt > --- > 5-make-release-commit | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/5-make-release-commit b/5-make-release-commit > index 374154f..00acf92 100755 > --- a/5-make-release-commit > +++ b/5-make-release-commit > @@ -29,7 +29,7 @@ function rstheader() > > echo > echo "${msg}" > - printf "${rchar}%.0s" $(seq 1 ${#msg}) > + for i in $(seq 1 ${#msg}); do printf "${rchar}"; done > # break after line plus one empty line > echo > echo Either form works for me. Reviewed-by: David Marchand -- David Marchand