From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6EA03430BE for ; Mon, 21 Aug 2023 10:23:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45CB240EE3; Mon, 21 Aug 2023 10:23:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 498E140A7D for ; Mon, 21 Aug 2023 10:23:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692606184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e/ohmHdEoDyzR9p0k5YYfyFi8v20qzMg6U3Bc5i8srI=; b=fvBNbrpyrgVUl8qNBWEzgoXZzXiNq7NH94MAEnaET42REGd8DrN+F24P3oBsGzfExiYkRm 7TOd4ldXsG1WqxIvTdLTmtg4uH66y90fhDt741RIUYkBPZZZ9GnADLQ2jaB77Jjv4acCAt c8vg6UubYm6MWFCXglWFPu5veNFd2PQ= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-NuISaACfMFao__GCbXcSzw-1; Mon, 21 Aug 2023 04:23:03 -0400 X-MC-Unique: NuISaACfMFao__GCbXcSzw-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-4ff93641409so2885044e87.3 for ; Mon, 21 Aug 2023 01:23:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692606182; x=1693210982; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e/ohmHdEoDyzR9p0k5YYfyFi8v20qzMg6U3Bc5i8srI=; b=I8DeF23Ctq9IRx+HCtOXob6vTbGEXGZDS5TTjQ1v5Cqr3w5v376150qOL65RWlq5RF w+W090fmafy+GRabLs2VR/Q69qllv0kUfOvyTU2sQVNTGyX9GeNK14VZM1uVCCk/LD4Z WGubfIp7CCvurw8j8OAjSGou5IwTSaZdmAx1mCV5wsv7rtR9Dggr9Qt8AV+CWzNrdogw QVahIPvAohTrzO5u1Yup2/pCTx7vKjuBW509Mh66/fgDoGe6xiKggyWelw5hTsJNW0q/ zSIpKb6yggkcd6L/ORsrwrUTpvzV9ij9GPzlDruii/Lb3XZ1ZPef24y0iphSSgSpkxLS ixiA== X-Gm-Message-State: AOJu0YzAVMVSlv2BP5IhgQJz+ert8OlUTYIUY4CO9go2hfV8sX8zb4pG ZDWGDPxu910VrSP++DA8aPr83WN+aJ3H/mTKb8ec9JlgpIE12lPeTlAhV5iO2xEKyNwh1MCx44b tYTcW+Dn8KPzY7Jh/C6d3A4g= X-Received: by 2002:a05:6512:3706:b0:4fb:820a:f87f with SMTP id z6-20020a056512370600b004fb820af87fmr3821972lfr.10.1692606182010; Mon, 21 Aug 2023 01:23:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGaVUmmwDRMmCr0SnwvHn/sb1YwOoRmfzb9mE67nhT7pDMI61MXCp2t5+I0AlJ/8dhuYPejzAvDjjO1TVXX3sw= X-Received: by 2002:a05:6512:3706:b0:4fb:820a:f87f with SMTP id z6-20020a056512370600b004fb820af87fmr3821951lfr.10.1692606181704; Mon, 21 Aug 2023 01:23:01 -0700 (PDT) MIME-Version: 1.0 References: <20230818090351.2402519-1-david.marchand@redhat.com> <59C4371C-6702-4704-ACAA-048794EA3A42@redhat.com> In-Reply-To: <59C4371C-6702-4704-ACAA-048794EA3A42@redhat.com> From: David Marchand Date: Mon, 21 Aug 2023 10:22:49 +0200 Message-ID: Subject: Re: [PATCH] net/iavf: fix checksum offloading To: Eelco Chaudron Cc: dev@dpdk.org, mkp@redhat.com, stable@dpdk.org, Jingjing Wu , Beilei Xing , Declan Doherty , Abhijit Sinha , Radu Nicolau X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, Aug 21, 2023 at 10:03=E2=80=AFAM Eelco Chaudron wrote: > On 18 Aug 2023, at 11:03, David Marchand wrote: > > > The only presence of RTE_MBUF_F_TX_IPV4 can't be used as an indicator > > that a checksum offload has been requested by an application. > > Check that RTE_MBUF_F_TX_IP_CKSUM or others flags have been set. > > > > Fixes: 1e728b01120c ("net/iavf: rework Tx path") > > Cc: stable@dpdk.org > > Thanks for fixing this David! I tested and reviewed this change and it wo= rks now. For the record, Eelco encountered an issue with OVS 3.2 which now uses ip checksum offloading. Packets requiring such offloading were dropped by either the net/iavf driver or the i40e VF hw itself. --=20 David Marchand