From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49A06A04C0 for ; Tue, 13 Oct 2020 14:02:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 20FF21C19C; Tue, 13 Oct 2020 14:02:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 272CB1BCA2 for ; Tue, 13 Oct 2020 14:01:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602590518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w3Lp7JsJVTUbp/TINbVmymY67nSjrVvPePhElohDS9A=; b=A5sjCnZDWP+G1MItyAkjHOXpyLiH7xOiyRDtBf6OS7omcTJI7K2aMAl5kI2b1vWbNf1YAt /urUNbvvCrbPYAOhbYxV7NOGbtbV4CUeqxFoo/wgkGcBJASgVAbwcGUZ3kLa34cYQRzJDX 5WJinvcqMZ0UyZTXeviH5vQnWQgrxfA= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-197-blMWwSiBO1KIN_JT6F6NoQ-1; Tue, 13 Oct 2020 08:01:56 -0400 X-MC-Unique: blMWwSiBO1KIN_JT6F6NoQ-1 Received: by mail-vk1-f200.google.com with SMTP id v129so2761160vke.23 for ; Tue, 13 Oct 2020 05:01:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=w3Lp7JsJVTUbp/TINbVmymY67nSjrVvPePhElohDS9A=; b=lD5Hala4Jwy2yOAwI9zMIPo+95UrV3s5ypQdTJlZ3awKOwsIa0Cmq9yXBCfY3KpcAA YMkZ9x/JesrIaNpJZ9n2ok9L1p83EYq5SFt4L1Y0fY2X5QrofjtS8X53bFWa2Eq1q5lr vfmvex1/rmphs0q2ubQMNV4aJ909I+uKT/xthOWv1WlGbrFp08WgV9V8oLUh0e9rfATh PLZO4koD5RkIIcgXWXZCG4JlMHDTE5c6EZ+X5tVsdb+R3LGg0qeuIL31pp0ib2QR2YLd ZdxN+CEzp8V/A/IgiiKX6iI3KWfMNPEpiynzk0fzdZU/hwpja7vYpHfKVY39bmtPFqaW /qYA== X-Gm-Message-State: AOAM533UAa0MnS6/78J9vKTqFKPBCZelgXRz/roMxL6cP4jmCUisgNza 6CxlPvLE8H2n9M8C2THMtTy/cgc8AIJS+7RwgCFY9rYeTo5R7GfTsPBUi8mvmV93d5OT7gFQflP od8xJTjDaSk0tygzttW98dZc= X-Received: by 2002:a05:6102:3121:: with SMTP id f1mr16544967vsh.10.1602590516105; Tue, 13 Oct 2020 05:01:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNk1Y7FluHVdQia9LFs74O7gFszgaLlV1oQWCTaH/L3Yk2Swl2ydWXwO6o+F2U1QIyj3abffRNFHLd+LOaAvY= X-Received: by 2002:a05:6102:3121:: with SMTP id f1mr16544939vsh.10.1602590515777; Tue, 13 Oct 2020 05:01:55 -0700 (PDT) MIME-Version: 1.0 References: <20200805122640.13884-1-nick.connolly@mayadata.io> <20201012192803.3741-1-nick.connolly@mayadata.io> In-Reply-To: From: David Marchand Date: Tue, 13 Oct 2020 14:01:44 +0200 Message-ID: To: Nick Connolly Cc: Nicolas Dichtel , Anatoly Burakov , Didier Pallard , Olivier Matz , dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [PATCH v2] mem: fix allocation failure on non-NUMA kernel X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Oct 13, 2020 at 10:00 AM Nicolas Dichtel wrote: > > Le 12/10/2020 =C3=A0 21:28, Nick Connolly a =C3=A9crit : > > Running dpdk-helloworld on Linux with lib numa present, > > but no kernel support for NUMA (CONFIG_NUMA=3Dn) causes > > ret_service_init() to fail with EAL: error allocating > > rte services array. > > > > alloc_seg() calls get_mempolicy to verify that the allocation > > has happened on the correct socket, but receives ENOSYS from > > the kernel and fails the allocation. > > > > The allocated socket should only be verified if check_numa() is true. > > > > Fixes: 2a96c88be83e ("mem: ease init in a docker container") > > Cc: nicolas.dichtel@6wind.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Nick Connolly > Reviewed-by: Nicolas Dichtel Acked-by: Anatoly Burakov Applied, thanks Nick. --=20 David Marchand