From: David Marchand <david.marchand@redhat.com>
To: dev <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2 3/3] net/pcap: fix concurrent multiseg packet transmits
Date: Thu, 25 Jul 2019 14:05:58 +0200 [thread overview]
Message-ID: <CAJFAV8yiSCZa0OJKaSzUT6bjjyyR0rMcAAK1MGPoJWpwKeyQUg@mail.gmail.com> (raw)
In-Reply-To: <1564056260-18125-4-git-send-email-david.marchand@redhat.com>
On Thu, Jul 25, 2019 at 2:05 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> Two cores can send multi segment packets on two different pcap ports.
> Because of this, we can't have one single buffer to linearize packets.
>
> Use rte_pktmbuf_read() to copy the packet into a buffer on the stack
> and remove eth_pcap_gather_data() when necessary (if the mbuf is
> contiguous, rte_pktmbuf_read() just points at the buffer address).
>
> With this change, we won't support mono segment mbuf larger than 16k.
Argh, should have removed this wrong comment...
--
David Marchand
next prev parent reply other threads:[~2019-07-25 12:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1563969270-29669-1-git-send-email-david.marchand@redhat.com>
2019-07-24 11:54 ` [dpdk-stable] [PATCH 1/3] net/pcap: fix Rx with small buffers David Marchand
2019-07-24 18:28 ` Ferruh Yigit
2019-07-24 11:54 ` [dpdk-stable] [PATCH 2/3] net/pcap: fix transmit return count in error conditions David Marchand
2019-07-24 18:36 ` Ferruh Yigit
2019-07-25 7:40 ` David Marchand
2019-07-25 11:01 ` Ferruh Yigit
2019-07-24 11:54 ` [dpdk-stable] [PATCH 3/3] net/pcap: fix concurrent multiseg packet transmits David Marchand
2019-07-24 18:43 ` Ferruh Yigit
2019-07-25 8:18 ` David Marchand
2019-07-25 11:07 ` Ferruh Yigit
[not found] ` <1564056260-18125-1-git-send-email-david.marchand@redhat.com>
2019-07-25 12:04 ` [dpdk-stable] [PATCH v2 1/3] net/pcap: fix Rx with small buffers David Marchand
2019-07-25 12:04 ` [dpdk-stable] [PATCH v2 2/3] net/pcap: fix transmit return count in error conditions David Marchand
2019-07-25 14:43 ` Ferruh Yigit
2019-07-25 12:04 ` [dpdk-stable] [PATCH v2 3/3] net/pcap: fix concurrent multiseg packet transmits David Marchand
2019-07-25 12:05 ` David Marchand [this message]
2019-07-25 14:47 ` Ferruh Yigit
[not found] ` <1564082659-21922-1-git-send-email-david.marchand@redhat.com>
2019-07-25 19:24 ` [dpdk-stable] [PATCH v3 1/3] net/pcap: fix Rx with small buffers David Marchand
2019-07-25 19:24 ` [dpdk-stable] [PATCH v3 2/3] net/pcap: fix transmit return count in error conditions David Marchand
2019-07-25 19:24 ` [dpdk-stable] [PATCH v3 3/3] net/pcap: fix concurrent multiseg packet transmits David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yiSCZa0OJKaSzUT6bjjyyR0rMcAAK1MGPoJWpwKeyQUg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).