From: David Marchand <david.marchand@redhat.com>
To: Simei Su <simei.su@intel.com>
Cc: beilei.xing@intel.com, yuying.zhang@intel.com, dev@dpdk.org,
qi.z.zhang@intel.com, qiming.yang@intel.com, stable@dpdk.org
Subject: Re: [PATCH v5] net/i40e: rework maximum frame size configuration
Date: Thu, 2 Feb 2023 14:24:14 +0100 [thread overview]
Message-ID: <CAJFAV8yn=EpeNq4PisM_U0baf64hkcZZL7fG9VWi5yQenBOV1Q@mail.gmail.com> (raw)
In-Reply-To: <20230202123632.56730-1-simei.su@intel.com>
On Thu, Feb 2, 2023 at 1:37 PM Simei Su <simei.su@intel.com> wrote:
> @@ -2467,8 +2466,16 @@ i40e_dev_start(struct rte_eth_dev *dev)
> "please call hierarchy_commit() "
> "before starting the port");
>
> - max_frame_size = dev->data->mtu + I40E_ETH_OVERHEAD;
> - i40e_set_mac_max_frame(dev, max_frame_size);
> + max_frame_size = dev->data->mtu ?
> + dev->data->mtu + I40E_ETH_OVERHEAD :
> + I40E_FRAME_SIZE_MAX;
> +
> + /* Set the max frame size to HW*/
> + ret = i40e_aq_set_mac_config(hw, max_frame_size, TRUE, false, 0, NULL);
> + if (ret) {
> + PMD_DRV_LOG(ERR, "Fail to set mac config");
> + return ret;
> + }
Reading this patch again.
Returning here seems incorrect as we leave rx/tx queue in started state.
Don't we need to jump to tx_err label on error?
>
> return I40E_SUCCESS;
>
--
David Marchand
next prev parent reply other threads:[~2023-02-02 13:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 10:53 [PATCH] " Simei Su
2023-01-16 11:18 ` David Marchand
2023-01-16 12:15 ` Su, Simei
2023-01-20 7:33 ` David Marchand
2023-01-20 13:57 ` Su, Simei
2023-01-20 14:46 ` David Marchand
2023-01-20 15:37 ` Su, Simei
2023-01-31 6:52 ` [PATCH v2] " Simei Su
2023-01-31 7:44 ` 答复: [[SPF Failed]][PATCH " 韩爽
2023-01-31 10:31 ` [PATCH v3] " Simei Su
2023-02-02 5:54 ` Yang, Qiming
2023-02-02 12:30 ` [PATCH v4] " Simei Su
2023-02-02 12:36 ` [PATCH v5] " Simei Su
2023-02-02 12:55 ` David Marchand
2023-02-03 3:50 ` Su, Simei
2023-02-02 13:24 ` David Marchand [this message]
2023-02-02 13:48 ` David Marchand
2023-02-03 8:38 ` Yang, Qiming
2023-02-03 8:47 ` David Marchand
2023-02-03 4:00 ` Su, Simei
2023-02-20 7:59 ` [PATCH v6] " Simei Su
2023-02-27 0:35 ` Zhang, Qi Z
2023-02-28 9:36 ` David Marchand
2023-03-02 9:51 ` Zhang, Qi Z
2023-03-22 16:50 ` Kevin Traynor
2023-03-23 14:50 ` Kevin Traynor
2023-03-24 6:32 ` Jiang, YuX
2023-03-24 9:40 ` Kevin Traynor
2023-03-24 10:20 ` Jiang, YuX
2023-03-24 13:07 ` Su, Simei
2023-03-06 12:18 ` [PATCH v7] net/i40e: fix max " Simei Su
2023-03-07 2:27 ` Zhang, Qi Z
2023-02-02 13:14 ` [PATCH v4] net/i40e: rework maximum " Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yn=EpeNq4PisM_U0baf64hkcZZL7fG9VWi5yQenBOV1Q@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=simei.su@intel.com \
--cc=stable@dpdk.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).