Re: [PATCH] examples/pipeline: fix include path for rte_log.h

[David Marchand <david.marchand@redhat.com>]

On Tue, Feb 13, 2024 at 3:52 PM Cristian Dumitrescu
<cristian.dumitrescu@intel.com> wrote:
>
> When rte_log.h was moved to a new directory, the include path was not
> updated for the generated C code produced by the pipeline library,
> which results in build failure for this code.
>
> Fixes: 09ce41310930 ("log: separate logging functions out of EAL")
> Cc: stable@dpdk.org
>
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
>  examples/pipeline/cli.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c
> index 2ae6cc579f..afb143c01f 100644
> --- a/examples/pipeline/cli.c
> +++ b/examples/pipeline/cli.c
> @@ -714,6 +714,7 @@ cmd_pipeline_libbuild(char **tokens,
>                  "-I %s/lib/eal/include "
>                  "-I %s/lib/eal/x86/include "
>                  "-I %s/lib/eal/include/generic "
> +                "-I %s/lib/log "
>                  "-I %s/lib/meter "
>                  "-I %s/lib/port "
>                  "-I %s/lib/table "
> @@ -738,6 +739,7 @@ cmd_pipeline_libbuild(char **tokens,
>                  install_dir,
>                  install_dir,
>                  install_dir,
> +                install_dir,
>                  log_file,
>                  obj_file,
>                  lib_file,

Wrt $Subject, copy/paste code in drivers/net/softnic is broken too.

Some comments on this code:
- putting compilation commands seems a rather strange idea in C code,
but at least, why not invoke an external tool/script that makes use of
existing build framework?
- RTE_INSTALL_DIR is undocumented,
- this implementation (passing -I <some_directory>/lib/eal/include) is
broken with a system-installed dpdk,


-- 
David Marchand