patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH stable-scripts] Fix regex to select commit via Fixed line
@ 2020-02-14 11:48 luca.boccassi
  2020-02-14 12:47 ` Luca Boccassi
  0 siblings, 1 reply; 3+ messages in thread
From: luca.boccassi @ 2020-02-14 11:48 UTC (permalink / raw)
  To: stable; +Cc: ktraynor

From: Luca Boccassi <luca.boccassi@microsoft.com>

The regex was not matching very old DPDK versions with letters in
it, like 1.3.0r0.

Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
I had one problem, so I used a regex to fix it.
Now I have two problems.

 1-import | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/1-import b/1-import
index 51e4413..b49e228 100755
--- a/1-import
+++ b/1-import
@@ -46,7 +46,7 @@ then
 			echo $line >> $tmp_list
 		# Is the patch fixing a commit that was part of this stable release?
 		# If so select it
-		elif verlte `echo $line | sed "s/.*(\([0-9][0-9].[0-9][0-9]\).*)/\1/"` $stable_release
+		elif verlte `echo $line | sed -E "s/.*\(([0-9]+.[0-9]+(.\w+)*)(\s\(.*\))*\)/\1/"` $stable_release
 		then
 			echo $line >> $tmp_list
 		# Was the commit (which might be only in a subsequent release)
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH stable-scripts] Fix regex to select commit via Fixed line
  2020-02-14 11:48 [dpdk-stable] [PATCH stable-scripts] Fix regex to select commit via Fixed line luca.boccassi
@ 2020-02-14 12:47 ` Luca Boccassi
  2020-02-14 12:56   ` David Marchand
  0 siblings, 1 reply; 3+ messages in thread
From: Luca Boccassi @ 2020-02-14 12:47 UTC (permalink / raw)
  To: stable; +Cc: ktraynor

David pointed out that sed -E is not present on certain ancient
distros, so I'll use --regexp-extended instead which is equivalent

On Fri, 2020-02-14 at 11:48 +0000, luca.boccassi@gmail.com wrote:
> From: Luca Boccassi <
> luca.boccassi@microsoft.com
> >
> 
> The regex was not matching very old DPDK versions with letters in
> it, like 1.3.0r0.
> 
> Signed-off-by: Luca Boccassi <
> luca.boccassi@microsoft.com
> >
> ---
> I had one problem, so I used a regex to fix it.
> Now I have two problems.
> 
>  1-import | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/1-import b/1-import
> index 51e4413..b49e228 100755
> --- a/1-import
> +++ b/1-import
> @@ -46,7 +46,7 @@ then
>  			echo $line >> $tmp_list
>  		# Is the patch fixing a commit that was part of this
> stable release?
>  		# If so select it
> -		elif verlte `echo $line | sed "s/.*(\([0-9][0-9].[0-
> 9][0-9]\).*)/\1/"` $stable_release
> +		elif verlte `echo $line | sed -E "s/.*\(([0-9]+.[0-
> 9]+(.\w+)*)(\s\(.*\))*\)/\1/"` $stable_release
>  		then
>  			echo $line >> $tmp_list
>  		# Was the commit (which might be only in a subsequent
> release)
> 
-- 
Kind regards,
Luca Boccassi


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH stable-scripts] Fix regex to select commit via Fixed line
  2020-02-14 12:47 ` Luca Boccassi
@ 2020-02-14 12:56   ` David Marchand
  0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2020-02-14 12:56 UTC (permalink / raw)
  To: Luca Boccassi; +Cc: dpdk stable, Kevin Traynor

On Fri, Feb 14, 2020 at 1:47 PM Luca Boccassi <luca.boccassi@gmail.com> wrote:
>
> David pointed out that sed -E is not present on certain ancient
> distros, so I'll use --regexp-extended instead which is equivalent

Ok ok, I might be the only one still using one of those ;-).


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-14 11:48 [dpdk-stable] [PATCH stable-scripts] Fix regex to select commit via Fixed line luca.boccassi
2020-02-14 12:47 ` Luca Boccassi
2020-02-14 12:56   ` David Marchand

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox