From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 258EA432BB for ; Mon, 6 Nov 2023 19:17:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01CE4402D4; Mon, 6 Nov 2023 19:17:42 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BEF57402C2 for ; Mon, 6 Nov 2023 19:17:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699294659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TIn6bGidvtCmlcFJrnMyObcIWqza1u8Je9Ae4LxGnvI=; b=QuV+iUsxYpbUe8zpZMQQoMpkcSmm76c//fQLCtz2KTxwrYP/pNm+0YacCaNpipJB3wGlMB PyGLcri2iKQgA/LgvrzcQmeMPY3Z35gSt/Yubcsg+GlMwVkE+65A0unNrEdvg/fKbWR7AH rdIK9WZK0wfyu0MBoNxTwbQtkm/rDNc= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-MVcEjYIpNCCOQLq5MVbC_w-1; Mon, 06 Nov 2023 13:17:38 -0500 X-MC-Unique: MVcEjYIpNCCOQLq5MVbC_w-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2c50cec5d29so39940911fa.2 for ; Mon, 06 Nov 2023 10:17:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699294656; x=1699899456; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TIn6bGidvtCmlcFJrnMyObcIWqza1u8Je9Ae4LxGnvI=; b=LaOfM5jBi0Eds8gY1ZqPWoKqIRYhrFIqWPSj/PCdKidZqRt8APHcfFp80gUp5Sfkcc Z59aMBusze9ERFWML1YsZIzfHleEkqdd5b6r8YwJOB4l7M6qDT0zihEQImYXxoPORLZ5 mMkobeouTxHYQXLcNZYU74ZJHfbyCi8QELmFdRc/DYVmBeK8wOVm9y88rsxLK19JlLks 6x0FsHvXDwzHW0B7Op5gGLGH5smyY3mQijPRn/B4X4KrdYTpg4ihvnQI1IZYTyCvUTpQ 4D4Bv6ftJg/0Wnb/BwF+IMfw91ekCFJMk3J/jFnH53thlmQI4DXPDVmO33DLAY6anzRe Llsg== X-Gm-Message-State: AOJu0Yzq7cCYrko+X37lLfugtfoop6RFBBLZQXSfTiaSKIWdYVfcJsOU EE7KyU2wPFXJ/1sb8XW8srEde3umPEQinXHn4XOIRIxk0WmVasakJOKjme8dz+268yGO2eANcAY dY3+04uTqNR9DeiYRs34DD3M= X-Received: by 2002:a05:651c:210e:b0:2b6:df71:cff1 with SMTP id a14-20020a05651c210e00b002b6df71cff1mr29567983ljq.52.1699294656632; Mon, 06 Nov 2023 10:17:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGZfUxwWrJvqX6hzqVzSDfia3Bq74ajNxJemYlELHlEDX8DxLvKBsIGO61yNhb8NN4ToPFxnXfnANoZN47b8vE= X-Received: by 2002:a05:651c:210e:b0:2b6:df71:cff1 with SMTP id a14-20020a05651c210e00b002b6df71cff1mr29567974ljq.52.1699294656287; Mon, 06 Nov 2023 10:17:36 -0800 (PST) MIME-Version: 1.0 References: <20231020170135.18319-1-syalavarthi@marvell.com> <20231106041243.13621-1-syalavarthi@marvell.com> In-Reply-To: From: David Marchand Date: Mon, 6 Nov 2023 19:17:24 +0100 Message-ID: Subject: Re: [PATCH v5 1/1] build: add libarchive to external deps To: Bruce Richardson Cc: Srikanth Yalavarthi , Aaron Conole , Igor Russkikh , dev@dpdk.org, sshankarnara@marvell.com, aprabhu@marvell.com, ptakkar@marvell.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, Nov 6, 2023 at 5:24=E2=80=AFPM Bruce Richardson wrote: > > On Mon, Nov 06, 2023 at 05:03:10PM +0100, David Marchand wrote: > > On Mon, Nov 6, 2023 at 5:12=E2=80=AFAM Srikanth Yalavarthi > > wrote: > > > > > > In order to avoid linking with Libs.private, libarchive is not added = to > > > ext_deps during the meson setup stage. > > > > > > Since libarchive is not added to ext_deps, cross-compilation or nativ= e > > > compilation with libarchive installed in non-standard location fails > > > with errors related to "cannot find -larchive" or "archive.h: No such > > > file or directory". In order to fix the build failures, user is > > > required to define the 'c_args' and 'c_link_args' with '-I' > > > and '-L'. > > > > > > This patch adds libarchive to ext_deps and further would not require > > > setting c_args and c_link_args externally. > > > > > > Fixes: 40edb9c0d36b ("eal: handle compressed firmware") Cc: > > > stable@dpdk.org > > > > > > Signed-off-by: Srikanth Yalavarthi > > > > This breaks static compilation of applications. This can be reproduced > > with test-meson-builds.sh and in GHA (which was not linking examples > > statically, I added a patch in my github repo): > > https://github.com/david-marchand/dpdk/actions/runs/6772879600/job/1840= 6442129#step:19:19572 > > > The libarchive-dev Ubuntu package does not install all its needed > dependencies for static linking. The errors can be resolved by manually > installing the 3 missing -dev packages. Same with fedora. > > It's less than ideal, but to my mind, DPDK is behaving correctly with thi= s > fix - it is marking that it requires libarchive as a dependency. The fact > that the libarchive.pc file lists static libraries that aren't installed = is > outside of our control. The previous implementation hacked around this by > just passing -larchive in all cases, rather than using pkg-config > information. This then caused other issues that the patch submitter hit. Ok, I'll see how to workaround this on my side. --=20 David Marchand