From: David Marchand <david.marchand@redhat.com>
To: Gavin Hu <gavin.hu@arm.com>
Cc: dev <dev@dpdk.org>, nd <nd@arm.com>,
Thomas Monjalon <thomas@monjalon.net>,
Stephen Hemminger <stephen@networkplumber.org>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"Ruifeng Wang (Arm Technology China)" <ruifeng.wang@arm.com>,
Phil Yang <phil.yang@arm.com>,
Steve Capper <steve.capper@arm.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v7 1/7] bus/fslmc: fix the conflicting dmb function
Date: Thu, 17 Oct 2019 17:06:43 +0200 [thread overview]
Message-ID: <CAJFAV8z1G6xzswUWDQnFokCPODWngxxOa_2aOeYi=FF4V_719g@mail.gmail.com> (raw)
In-Reply-To: <1569562904-43950-2-git-send-email-gavin.hu@arm.com>
On Fri, Sep 27, 2019 at 7:42 AM Gavin Hu <gavin.hu@arm.com> wrote:
>
> There are two definitions conflicting each other, for more
> details, refer to [1].
>
> include/rte_atomic_64.h:19: error: "dmb" redefined [-Werror]
> drivers/bus/fslmc/mc/fsl_mc_sys.h:36: note: this is the location of the
> previous definition
> #define dmb() {__asm__ __volatile__("" : : : "memory"); }
Interesting, this means that we have a leftover macro from the arm
header that can pollute the namespace.
Anyway, this driver is not using the memory barrier api from the EAL.
How about simply fixing with?
#define __iormb() rte_io_rmb()
#define __iowmb() rte_io_wmb()
>
> The fix is to include the spinlock.h file before the other header files,
> this is inline with the coding style[2] about the "header includes".
> The fix changes the function to take the argument for arm to be
> meaningful.
>
> [1] http://inbox.dpdk.org/users/VI1PR08MB537631AB25F41B8880DCCA988FDF0@i
> VI1PR08MB5376.eurprd08.prod.outlook.com/T/#u
This url is broken, there is a trailing i on the first line.
> [2] https://doc.dpdk.org/guides/contributing/coding_style.html
>
> Fixes: 3af733ba8da8 ("bus/fslmc: introduce MC object functions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Phil Yang <phi.yang@arm.com>
--
David Marchand
next prev parent reply other threads:[~2019-10-17 15:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1566454356-37277-1-git-send-email-gavin.hu@arm.com>
[not found] ` <1561911676-37718-1-git-send-email-gavin.hu@arm.com>
2019-08-22 6:12 ` [dpdk-stable] [PATCH v4 1/6] " Gavin Hu
2019-09-12 11:24 ` [dpdk-stable] [PATCH v5 2/8] " Gavin Hu
2019-09-14 14:59 ` [dpdk-stable] [PATCH v6 1/7] " Gavin Hu
2019-09-27 5:41 ` [dpdk-stable] [PATCH v7 " Gavin Hu
2019-09-27 8:24 ` Hemant Agrawal
2019-10-17 15:06 ` David Marchand [this message]
2019-10-21 9:47 ` [dpdk-stable] [PATCH v8 1/6] " Gavin Hu
2019-10-21 19:00 ` [dpdk-stable] [dpdk-dev] " David Marchand
2019-10-24 10:42 ` [dpdk-stable] [PATCH v9 1/5] " Gavin Hu
2019-10-25 15:39 ` [dpdk-stable] [PATCH v10 " Gavin Hu
2019-10-27 12:52 ` [dpdk-stable] [PATCH v11 " Gavin Hu
2019-11-04 15:32 ` [dpdk-stable] [PATCH v12 " Gavin Hu
[not found] ` <1573162528-16230-1-git-send-email-david.marchand@redhat.com>
2019-11-07 21:35 ` [dpdk-stable] [PATCH v13 " David Marchand
2019-12-10 6:13 ` [dpdk-stable] [dpdk-dev] " Honnappa Nagarahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8z1G6xzswUWDQnFokCPODWngxxOa_2aOeYi=FF4V_719g@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=pbhagavatula@marvell.com \
--cc=phil.yang@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=steve.capper@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).