patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] eal/windows: revert definition of ETOOMANYREFS
@ 2020-11-19 15:43 Tal Shnaiderman
  2020-11-19 16:03 ` Nick Connolly
  2020-11-20  9:12 ` David Marchand
  0 siblings, 2 replies; 4+ messages in thread
From: Tal Shnaiderman @ 2020-11-19 15:43 UTC (permalink / raw)
  To: dev
  Cc: thomas, dmitry.kozliuk, navasile, dmitrym, pallavi.kadam,
	nick.connolly, stable

This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.

The definition of ETOOMANYREFS is reverted as it breaks build of
external applications already defining it.

Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
Cc: stable@dpdk.org

Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
 lib/librte_eal/windows/include/rte_os.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/librte_eal/windows/include/rte_os.h b/lib/librte_eal/windows/include/rte_os.h
index 8300ea483a..569ed92d51 100644
--- a/lib/librte_eal/windows/include/rte_os.h
+++ b/lib/librte_eal/windows/include/rte_os.h
@@ -51,8 +51,6 @@ extern "C" {
 /* as in <windows.h> */
 typedef long long ssize_t;
 
-#define ETOOMANYREFS 10059 /* WSAETOOMANYREFS */
-
 #ifndef RTE_TOOLCHAIN_GCC
 
 static inline int
-- 
2.16.1.windows.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH] eal/windows: revert definition of ETOOMANYREFS
  2020-11-19 15:43 [dpdk-stable] [PATCH] eal/windows: revert definition of ETOOMANYREFS Tal Shnaiderman
@ 2020-11-19 16:03 ` Nick Connolly
  2020-11-20  9:12 ` David Marchand
  1 sibling, 0 replies; 4+ messages in thread
From: Nick Connolly @ 2020-11-19 16:03 UTC (permalink / raw)
  To: Tal Shnaiderman, dev
  Cc: thomas, dmitry.kozliuk, navasile, dmitrym, pallavi.kadam, stable

Reviewed-by: Nick Connolly <nick.connolly@mayadata.io>

On 19/11/2020 15:43, Tal Shnaiderman wrote:
> This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.
>
> The definition of ETOOMANYREFS is reverted as it breaks build of
> external applications already defining it.
>
> Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
>   lib/librte_eal/windows/include/rte_os.h | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/lib/librte_eal/windows/include/rte_os.h b/lib/librte_eal/windows/include/rte_os.h
> index 8300ea483a..569ed92d51 100644
> --- a/lib/librte_eal/windows/include/rte_os.h
> +++ b/lib/librte_eal/windows/include/rte_os.h
> @@ -51,8 +51,6 @@ extern "C" {
>   /* as in <windows.h> */
>   typedef long long ssize_t;
>   
> -#define ETOOMANYREFS 10059 /* WSAETOOMANYREFS */
> -
>   #ifndef RTE_TOOLCHAIN_GCC
>   
>   static inline int


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH] eal/windows: revert definition of ETOOMANYREFS
  2020-11-19 15:43 [dpdk-stable] [PATCH] eal/windows: revert definition of ETOOMANYREFS Tal Shnaiderman
  2020-11-19 16:03 ` Nick Connolly
@ 2020-11-20  9:12 ` David Marchand
  2020-11-20  9:17   ` David Marchand
  1 sibling, 1 reply; 4+ messages in thread
From: David Marchand @ 2020-11-20  9:12 UTC (permalink / raw)
  To: Tal Shnaiderman
  Cc: dev, Thomas Monjalon, Dmitry Kozlyuk, Narcisa Ana Maria Vasile,
	Dmitry Malloy (MESHCHANINOV),
	Pallavi Kadam, Nick Connolly, dpdk stable

On Thu, Nov 19, 2020 at 4:43 PM Tal Shnaiderman <talshn@nvidia.com> wrote:
>
> This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.
>
> The definition of ETOOMANYREFS is reverted as it breaks build of
> external applications already defining it.
>
> Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")

No need to copy stable, the reverted commit is only in the current release.

> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
Reviewed-by: Nick Connolly <nick.connolly@mayadata.io>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH] eal/windows: revert definition of ETOOMANYREFS
  2020-11-20  9:12 ` David Marchand
@ 2020-11-20  9:17   ` David Marchand
  0 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2020-11-20  9:17 UTC (permalink / raw)
  To: Dmitry Kozlyuk, Narcisa Ana Maria Vasile,
	Dmitry Malloy (MESHCHANINOV),
	Pallavi Kadam
  Cc: dev, Nick Connolly, dpdk stable, Tal Shnaiderman, Thomas Monjalon

On Fri, Nov 20, 2020 at 10:12 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Thu, Nov 19, 2020 at 4:43 PM Tal Shnaiderman <talshn@nvidia.com> wrote:
> >
> > This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.
> >
> > The definition of ETOOMANYREFS is reverted as it breaks build of
> > external applications already defining it.
> >
> > Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
>
> No need to copy stable, the reverted commit is only in the current release.
>
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> Reviewed-by: Nick Connolly <nick.connolly@mayadata.io>
>
> Applied, thanks.

Hum, pulling back on this.
I did not see any Windows maintainer opine in the discussion.
Can I get some acks please ?


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19 15:43 [dpdk-stable] [PATCH] eal/windows: revert definition of ETOOMANYREFS Tal Shnaiderman
2020-11-19 16:03 ` Nick Connolly
2020-11-20  9:12 ` David Marchand
2020-11-20  9:17   ` David Marchand

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox