From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 172D8A0C42 for ; Wed, 23 Jun 2021 12:43:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04686410E6; Wed, 23 Jun 2021 12:43:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id A73144003E for ; Wed, 23 Jun 2021 12:43:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624444980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KWRyrBtcjK+n6nJ/FxygwX9U0YhOnlnYtHMU4wwU1TM=; b=XX7kgpKT8Pg5Jk9r6WfJZVSPrl2zQqsDOa3zYsOWm8nDyjfC69iscP1XXDkAocPp43fqZZ 4O8A8TkjeHe04RLP6IjHpZ/Mfvhn+S8SmWtXpyo0oiM9LPVa/yKHL3ELwtbIUVtfGqN9Hf 0O+z3zlqKnkyfiHRXkzaNdn8K3RJCFg= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-521-hMODy4WcNO-X2JRHekPgmg-1; Wed, 23 Jun 2021 06:42:57 -0400 X-MC-Unique: hMODy4WcNO-X2JRHekPgmg-1 Received: by mail-ua1-f69.google.com with SMTP id e12-20020ab0356c0000b029027874ede313so718157uaa.17 for ; Wed, 23 Jun 2021 03:42:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KWRyrBtcjK+n6nJ/FxygwX9U0YhOnlnYtHMU4wwU1TM=; b=JlLIPyx1iwCYuvjTVPvR+5F6IGTNx4OX3gSvJIkd/tzBQmTLwd93F2MvMl5fOeLxsP Bb0FpiQdTjlS9r2PhdoUuLpArCK+FPzojMxgncMOaHhUk6NaRVZFpzMjc5ip5ToD8kzO dhZKzAsAKNpCxg7lAek5men+zGxmOioiigYPGNYMS9foCdgkwErc/2bjEBt42l+FJ89M cBEiyg65Yvknruh0Ia+Denoz+6C/1oT1dZyliPG8WfVugv4v5AYKiHkq47nHkJXPynLo /WN/dzZrWKv1kQFtEd7ckr8I11LqRIWNlMWJoq/OLBNqGCDFe1jKccIeiprUmF/t/4xX 6E+g== X-Gm-Message-State: AOAM532/oHqUvgXPmgXg9kVRD2Fer2xqAf5dNM0oj0YXOqxgadM1ewFn U430LhWbSwxTqTeCmXk1lJUixBiuPLobQbL/mZfLF5xClH86pBhCPHoyRGxrKSZQV784ZwAktY2 jgcHiAitirGQytHLcPVomAPM= X-Received: by 2002:a1f:2e86:: with SMTP id u128mr23720750vku.22.1624444976906; Wed, 23 Jun 2021 03:42:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySpqOr+UDkwGK5fVhA5PXJ3uyCKqX6PmtrQ02K/hCW33AzfqEgLT4s9tRDtkfApZuh5QkCmdn4K3WgTG2XN1s= X-Received: by 2002:a1f:2e86:: with SMTP id u128mr23720737vku.22.1624444976644; Wed, 23 Jun 2021 03:42:56 -0700 (PDT) MIME-Version: 1.0 References: <20210619124830.25297-1-viacheslavo@nvidia.com> In-Reply-To: <20210619124830.25297-1-viacheslavo@nvidia.com> From: David Marchand Date: Wed, 23 Jun 2021 12:42:45 +0200 Message-ID: To: Viacheslav Ovsiienko Cc: dev , Raslan Darawsheh , Matan Azrad , Thomas Monjalon , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] common/mlx5: add provider query port support to glue library X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Sat, Jun 19, 2021 at 2:49 PM Viacheslav Ovsiienko wrote: > > The rdma-core mlx5 provider introduced the port attributes query > API since version v35.0 - the mlx5dv_query_port routine. In order > to support this change in the rdma-core the conditional compilation > flag HAVE_MLX5DV_DR_DEVX_PORT_V35 is introduced by the this patch. > > In the OFED rdma-core version the new compatible mlx5dv_query_port > routine was introduced as well, replacing the existing proprietary > mlx5dv_query_devx_port routine. The proprietary routine was > controlled in PMD code with HAVE_MLX5DV_DR_DEVX_PORT conditional > flag. > > Currently, the OFED rdma-core library contains both versions of > port query API. And this version is a transitional one, there are > the plans to remove the proprietary mlx5dv_query_devx_port routine > and the HAVE_MLX5DV_DR_DEVX_PORT flag in PMD will not work anymore. > > We had one more dependency on this flag in the code (for the > mlx5dv_dr_action_create_dest_ib_port routine) and the patch > fixes mentioned dependency also, by introducing the new > dedicated conditional flag - HAVE_MLX5DV_DR_CREATE_DEST_IB_PORT. > > This patch is highly desirable to be provided in DPDK LTS releases > due to it covers the major compatibility issue. This patch is a fix, yet nothing tells this story in the title. And the title does not reflect that it is a fix wrt versions of rdma-core. Is this a build issue? or a runtime compat issue? A good title makes life easier for users and people maintaining stable versions of DPDK. -- David Marchand