* [PATCH] dmadev: fix build if RTE_DMADEV_DEBUG enabled
@ 2025-10-27 16:46 Stephen Hemminger
2025-10-28 0:45 ` fengchengwen
2025-10-29 13:48 ` David Marchand
0 siblings, 2 replies; 5+ messages in thread
From: Stephen Hemminger @ 2025-10-27 16:46 UTC (permalink / raw)
To: dev
Cc: stable, Stephen Hemminger, david.marchand, Chengwen Feng,
Kevin Laatz, Bruce Richardson
Missing definition of errnos causes build failure:
In file included from ../lib/dmadev/rte_dmadev_trace.h:16,
from ../lib/dmadev/rte_dmadev_trace_points.c:8:
../lib/dmadev/rte_dmadev.h: In function ‘rte_dma_copy’:
../lib/dmadev/rte_dmadev.h:1183:25: error: ‘EINVAL’ undeclared (first use in this function)
1183 | return -EINVAL;
| ^~~~~~
Bugzilla ID: 1814
Fixes: 8f1d23ece06a ("eal: deprecate RTE_FUNC_PTR_* macros")
Cc: david.marchand@redhat.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/dmadev/rte_dmadev.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h
index 0f4f10ec12..e3d7c9d0ca 100644
--- a/lib/dmadev/rte_dmadev.h
+++ b/lib/dmadev/rte_dmadev.h
@@ -145,6 +145,7 @@
*/
#include <stdint.h>
+#include <errno.h>
#include <rte_bitops.h>
#include <rte_common.h>
--
2.51.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dmadev: fix build if RTE_DMADEV_DEBUG enabled
2025-10-27 16:46 [PATCH] dmadev: fix build if RTE_DMADEV_DEBUG enabled Stephen Hemminger
@ 2025-10-28 0:45 ` fengchengwen
2025-10-29 13:48 ` David Marchand
1 sibling, 0 replies; 5+ messages in thread
From: fengchengwen @ 2025-10-28 0:45 UTC (permalink / raw)
To: Stephen Hemminger, dev
Cc: stable, david.marchand, Kevin Laatz, Bruce Richardson
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
On 10/28/2025 12:46 AM, Stephen Hemminger wrote:
> Missing definition of errnos causes build failure:
>
> In file included from ../lib/dmadev/rte_dmadev_trace.h:16,
> from ../lib/dmadev/rte_dmadev_trace_points.c:8:
> ../lib/dmadev/rte_dmadev.h: In function ‘rte_dma_copy’:
> ../lib/dmadev/rte_dmadev.h:1183:25: error: ‘EINVAL’ undeclared (first use in this function)
> 1183 | return -EINVAL;
> | ^~~~~~
>
> Bugzilla ID: 1814
> Fixes: 8f1d23ece06a ("eal: deprecate RTE_FUNC_PTR_* macros")
> Cc: david.marchand@redhat.com
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dmadev: fix build if RTE_DMADEV_DEBUG enabled
2025-10-27 16:46 [PATCH] dmadev: fix build if RTE_DMADEV_DEBUG enabled Stephen Hemminger
2025-10-28 0:45 ` fengchengwen
@ 2025-10-29 13:48 ` David Marchand
2025-10-29 14:32 ` Stephen Hemminger
1 sibling, 1 reply; 5+ messages in thread
From: David Marchand @ 2025-10-29 13:48 UTC (permalink / raw)
To: Stephen Hemminger
Cc: dev, stable, Chengwen Feng, Kevin Laatz, Bruce Richardson
On Mon, 27 Oct 2025 at 17:46, Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> Missing definition of errnos causes build failure:
>
> In file included from ../lib/dmadev/rte_dmadev_trace.h:16,
> from ../lib/dmadev/rte_dmadev_trace_points.c:8:
> ../lib/dmadev/rte_dmadev.h: In function ‘rte_dma_copy’:
> ../lib/dmadev/rte_dmadev.h:1183:25: error: ‘EINVAL’ undeclared (first use in this function)
> 1183 | return -EINVAL;
> | ^~~~~~
>
> Bugzilla ID: 1814
> Fixes: 8f1d23ece06a ("eal: deprecate RTE_FUNC_PTR_* macros")
I am not following the rationale... 8f1d23ece06a removed a macro but
use of errno was already there, so I am skeptical this is the right
Fixes: tag.
The issue was present from the start, so:
Fixes: 91e581e5c924 ("dmadev: add data plane API")
> Cc: david.marchand@redhat.com
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dmadev: fix build if RTE_DMADEV_DEBUG enabled
2025-10-29 13:48 ` David Marchand
@ 2025-10-29 14:32 ` Stephen Hemminger
2025-10-29 14:40 ` David Marchand
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Hemminger @ 2025-10-29 14:32 UTC (permalink / raw)
To: David Marchand; +Cc: dev, stable, Chengwen Feng, Kevin Laatz, Bruce Richardson
On Wed, 29 Oct 2025 14:48:13 +0100
David Marchand <david.marchand@redhat.com> wrote:
> On Mon, 27 Oct 2025 at 17:46, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > Missing definition of errnos causes build failure:
> >
> > In file included from ../lib/dmadev/rte_dmadev_trace.h:16,
> > from ../lib/dmadev/rte_dmadev_trace_points.c:8:
> > ../lib/dmadev/rte_dmadev.h: In function ‘rte_dma_copy’:
> > ../lib/dmadev/rte_dmadev.h:1183:25: error: ‘EINVAL’ undeclared (first use in this function)
> > 1183 | return -EINVAL;
> > | ^~~~~~
> >
> > Bugzilla ID: 1814
> > Fixes: 8f1d23ece06a ("eal: deprecate RTE_FUNC_PTR_* macros")
>
> I am not following the rationale... 8f1d23ece06a removed a macro but
> use of errno was already there, so I am skeptical this is the right
> Fixes: tag.
>
> The issue was present from the start, so:
> Fixes: 91e581e5c924 ("dmadev: add data plane API")
>
> > Cc: david.marchand@redhat.com
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
>
Yes, the fixes tag is incorrect. The issue probably goes back further
in time. Might be related to tracepoints not including errno.h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dmadev: fix build if RTE_DMADEV_DEBUG enabled
2025-10-29 14:32 ` Stephen Hemminger
@ 2025-10-29 14:40 ` David Marchand
0 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2025-10-29 14:40 UTC (permalink / raw)
To: Stephen Hemminger
Cc: dev, stable, Chengwen Feng, Kevin Laatz, Bruce Richardson
On Wed, 29 Oct 2025 at 15:32, Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Wed, 29 Oct 2025 14:48:13 +0100
> David Marchand <david.marchand@redhat.com> wrote:
>
> > On Mon, 27 Oct 2025 at 17:46, Stephen Hemminger
> > <stephen@networkplumber.org> wrote:
> > >
> > > Missing definition of errnos causes build failure:
> > >
> > > In file included from ../lib/dmadev/rte_dmadev_trace.h:16,
> > > from ../lib/dmadev/rte_dmadev_trace_points.c:8:
> > > ../lib/dmadev/rte_dmadev.h: In function ‘rte_dma_copy’:
> > > ../lib/dmadev/rte_dmadev.h:1183:25: error: ‘EINVAL’ undeclared (first use in this function)
> > > 1183 | return -EINVAL;
> > > | ^~~~~~
> > >
> > > Bugzilla ID: 1814
> > > Fixes: 8f1d23ece06a ("eal: deprecate RTE_FUNC_PTR_* macros")
> >
> > I am not following the rationale... 8f1d23ece06a removed a macro but
> > use of errno was already there, so I am skeptical this is the right
> > Fixes: tag.
> >
> > The issue was present from the start, so:
> > Fixes: 91e581e5c924 ("dmadev: add data plane API")
> >
> > > Cc: david.marchand@redhat.com
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >
> >
>
> Yes, the fixes tag is incorrect. The issue probably goes back further
> in time. Might be related to tracepoints not including errno.h
Tracepoints were added later.
$ git blame 91e581e5c924 -- lib/dmadev/rte_dmadev.h | grep -A3 -E
'#include|RTE_DMADEV_DEBUG'
b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 147) #include <stdint.h>
b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 148)
b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 149) #include
<rte_bitops.h>
b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 150) #include
<rte_common.h>
b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 151) #include
<rte_compat.h>
b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 152) #include <rte_dev.h>
b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 153)
b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 154) #ifdef __cplusplus
b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 155) extern "C" {
--
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 739) #include
"rte_dmadev_core.h"
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 740)
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 741) /**@{@name
DMA operation flag
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 742) * @see
rte_dma_copy()
--
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 801) #ifdef
RTE_DMADEV_DEBUG
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 802) if
(!rte_dma_is_valid(dev_id) || length == 0)
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 803)
return -EINVAL;
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 804)
RTE_FUNC_PTR_OR_ERR_RET(*obj->copy, -ENOTSUP);
--
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 851) #ifdef
RTE_DMADEV_DEBUG
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 852) if
(!rte_dma_is_valid(dev_id) || src == NULL || dst == NULL ||
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 853)
nb_src == 0 || nb_dst == 0)
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 854)
return -EINVAL;
--
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 898) #ifdef
RTE_DMADEV_DEBUG
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 899) if
(!rte_dma_is_valid(dev_id) || length == 0)
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 900)
return -EINVAL;
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 901)
RTE_FUNC_PTR_OR_ERR_RET(*obj->fill, -ENOTSUP);
--
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 931) #ifdef
RTE_DMADEV_DEBUG
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 932) if
(!rte_dma_is_valid(dev_id))
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 933)
return -EINVAL;
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 934)
RTE_FUNC_PTR_OR_ERR_RET(*obj->submit, -ENOTSUP);
--
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 972) #ifdef
RTE_DMADEV_DEBUG
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 973) if
(!rte_dma_is_valid(dev_id) || nb_cpls == 0)
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 974) return 0;
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 975)
RTE_FUNC_PTR_OR_ERR_RET(*obj->completed, 0);
--
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 1032) #ifdef
RTE_DMADEV_DEBUG
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 1033) if
(!rte_dma_is_valid(dev_id) || nb_cpls == 0 || status == NULL)
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 1034) return 0;
91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 1035)
RTE_FUNC_PTR_OR_ERR_RET(*obj->completed_status, 0);
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-10-29 14:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-27 16:46 [PATCH] dmadev: fix build if RTE_DMADEV_DEBUG enabled Stephen Hemminger
2025-10-28 0:45 ` fengchengwen
2025-10-29 13:48 ` David Marchand
2025-10-29 14:32 ` Stephen Hemminger
2025-10-29 14:40 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).