From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D79E048A48 for ; Wed, 29 Oct 2025 15:40:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CDD094064F; Wed, 29 Oct 2025 15:40:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A79EF4026F for ; Wed, 29 Oct 2025 15:40:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761748832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xNmKX/hEzm1E1/q5CdhMfwU91FdZLxmDD+1iCfM5COA=; b=Qlo2jEyoFCK9DxE0EtUwXcjdKS/sEFCDEkckGVfW8ImdRtH1sf5Ifxzb2LHGRBk6z0gHpl jmCiMxQ54kw1B/0Ayj0ocl2pYptPpecG0qPvl6L+ePjpUQkG4y5H/C4IJDzBHLpvCtpRCs T+T9+q63Q1mmD2rIA6KOm2Ivy2xuJ8o= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-323-ii9AIPIaPEKeey0fzRSY7w-1; Wed, 29 Oct 2025 10:40:28 -0400 X-MC-Unique: ii9AIPIaPEKeey0fzRSY7w-1 X-Mimecast-MFC-AGG-ID: ii9AIPIaPEKeey0fzRSY7w_1761748827 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-592f33729c6so4071189e87.0 for ; Wed, 29 Oct 2025 07:40:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761748827; x=1762353627; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xNmKX/hEzm1E1/q5CdhMfwU91FdZLxmDD+1iCfM5COA=; b=jRlHxI/EXzuzB2og189k6t+sKq0Y29Sm3FzDnffLCZtiSxhjBsPjoSPBi/GLNNnT+C 0cGW9q/CuIK/UaTduaXjgUgmtW2Dn0CrH8Bv+s1SzhwGsLoeCqcMH8R38Rcbp6QC8a9w cvelX0wpiAOOVbrpqKrTCvTZGtVMAtP76pViw2lFexocHfPc08sBx3YBpZSXf2ptrxQO PwQcLl8o8VVNu5OjV+6N/mYWVOLvg6UrZtlMSeNio8bE8V+ij7YUjC1KSB1gi2CQJu7F M2ks+UT03pKvPcDlgg5cr6+luNEREGIeYLKGP8t+LQG7RR9FIUNypw2ANVtvsGwJKWnp 3DlQ== X-Forwarded-Encrypted: i=1; AJvYcCVCpHg7BoG7cCHfFVGliFC+nGSdDOEA92tu4RO+wz76v5wwVNEX+28KJpi/YXFMlqbikRavdpE=@dpdk.org X-Gm-Message-State: AOJu0YwoSSeSC75mFeVowumVPVv1VYO+A8KGQrxWAQUMG14J91KlZ4cQ 6ATkT0G6AaPBl5wxnY22koIxcJ0VAJTaaN0vyl97JmmKKbvPv+lRwFKg0bsIC9JWoNKM6Zr5ixh mUEkJywGIP1HLt4ohRmc/xUZgsoImmCqr59RRtGjs0fj+EdKFupVKyB/CFARpudUKjugdHD8uZG EDCmOVzuFI2JA0JTdQ57dQnLE= X-Gm-Gg: ASbGncuMeZdelpmjlR97qbOhPSlnjVtXkorztV2yKEDBv/9wcJZbqQaTXV0eikF51YY lq2U4WNTNeENOaRNsUG0ueRkLeo6Lcb7QGA0rUugoIPAxHVONKskD/8smhzc0WW0wiHyRCPRi+B jzAzdQlovATmSIitKuR7DDYWzeoM0iBNLyt5QQN+ibsmml2G4sjhirg8YrQg== X-Received: by 2002:a05:6512:3d22:b0:592:f573:65d3 with SMTP id 2adb3069b0e04-594128738bfmr1223103e87.1.1761748827143; Wed, 29 Oct 2025 07:40:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2QJBlAEjE+Ews7lHSrKqafx+/crvonIaA2xPY5IuqcQ+p0T0U6eDz1jJEo/P/9l0qc2x6XRMz1kutTgRdrDQ= X-Received: by 2002:a05:6512:3d22:b0:592:f573:65d3 with SMTP id 2adb3069b0e04-594128738bfmr1223081e87.1.1761748826658; Wed, 29 Oct 2025 07:40:26 -0700 (PDT) MIME-Version: 1.0 References: <20251027164621.175861-1-stephen@networkplumber.org> <20251029073215.494d130e@phoenix> In-Reply-To: <20251029073215.494d130e@phoenix> From: David Marchand Date: Wed, 29 Oct 2025 15:40:15 +0100 X-Gm-Features: AWmQ_bn0IzWrxeEsS85CzGCJsEH3WXRTvFTtPJGq8bVWVUqN_dY8DsQwuA4Cvwo Message-ID: Subject: Re: [PATCH] dmadev: fix build if RTE_DMADEV_DEBUG enabled To: Stephen Hemminger Cc: dev@dpdk.org, stable@dpdk.org, Chengwen Feng , Kevin Laatz , Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ztSRWc_ajLRYS8m8OeObFh-p4mNeZ30anBy8rXCOd7k_1761748827 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, 29 Oct 2025 at 15:32, Stephen Hemminger wrote: > > On Wed, 29 Oct 2025 14:48:13 +0100 > David Marchand wrote: > > > On Mon, 27 Oct 2025 at 17:46, Stephen Hemminger > > wrote: > > > > > > Missing definition of errnos causes build failure: > > > > > > In file included from ../lib/dmadev/rte_dmadev_trace.h:16, > > > from ../lib/dmadev/rte_dmadev_trace_points.c:8: > > > ../lib/dmadev/rte_dmadev.h: In function =E2=80=98rte_dma_copy=E2=80= =99: > > > ../lib/dmadev/rte_dmadev.h:1183:25: error: =E2=80=98EINVAL=E2=80=99 u= ndeclared (first use in this function) > > > 1183 | return -EINVAL; > > > | ^~~~~~ > > > > > > Bugzilla ID: 1814 > > > Fixes: 8f1d23ece06a ("eal: deprecate RTE_FUNC_PTR_* macros") > > > > I am not following the rationale... 8f1d23ece06a removed a macro but > > use of errno was already there, so I am skeptical this is the right > > Fixes: tag. > > > > The issue was present from the start, so: > > Fixes: 91e581e5c924 ("dmadev: add data plane API") > > > > > Cc: david.marchand@redhat.com > > > > > > Signed-off-by: Stephen Hemminger > > > > > > Yes, the fixes tag is incorrect. The issue probably goes back further > in time. Might be related to tracepoints not including errno.h Tracepoints were added later. $ git blame 91e581e5c924 -- lib/dmadev/rte_dmadev.h | grep -A3 -E '#include|RTE_DMADEV_DEBUG' b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 147) #include b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 148) b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 149) #include b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 150) #include b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 151) #include b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 152) #include b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 153) b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 154) #ifdef __cpluspl= us b36970f2e13 (Chengwen Feng 2021-10-13 20:24:55 +0800 155) extern "C" { -- 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 739) #include "rte_dmadev_core.h" 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 740) 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 741) /**@{@name DMA operation flag 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 742) * @see rte_dma_copy() -- 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 801) #ifdef RTE_DMADEV_DEBUG 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 802) if (!rte_dma_is_valid(dev_id) || length =3D=3D 0) 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 803) return -EINVAL; 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 804) RTE_FUNC_PTR_OR_ERR_RET(*obj->copy, -ENOTSUP); -- 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 851) #ifdef RTE_DMADEV_DEBUG 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 852) if (!rte_dma_is_valid(dev_id) || src =3D=3D NULL || dst =3D=3D NULL || 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 853) nb_src =3D=3D 0 || nb_dst =3D=3D 0) 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 854) return -EINVAL; -- 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 898) #ifdef RTE_DMADEV_DEBUG 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 899) if (!rte_dma_is_valid(dev_id) || length =3D=3D 0) 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 900) return -EINVAL; 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 901) RTE_FUNC_PTR_OR_ERR_RET(*obj->fill, -ENOTSUP); -- 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 931) #ifdef RTE_DMADEV_DEBUG 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 932) if (!rte_dma_is_valid(dev_id)) 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 933) return -EINVAL; 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 934) RTE_FUNC_PTR_OR_ERR_RET(*obj->submit, -ENOTSUP); -- 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 972) #ifdef RTE_DMADEV_DEBUG 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 973) if (!rte_dma_is_valid(dev_id) || nb_cpls =3D=3D 0) 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 974) return 0= ; 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 975) RTE_FUNC_PTR_OR_ERR_RET(*obj->completed, 0); -- 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 1032) #ifdef RTE_DMADEV_DEBUG 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 1033) if (!rte_dma_is_valid(dev_id) || nb_cpls =3D=3D 0 || status =3D=3D NULL) 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 1034) return 0= ; 91e581e5c92 (Chengwen Feng 2021-10-13 20:24:57 +0800 1035) RTE_FUNC_PTR_OR_ERR_RET(*obj->completed_status, 0); --=20 David Marchand