From: David Marchand <david.marchand@redhat.com>
To: Long Li <longli@microsoft.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"aconole@redhat.com" <aconole@redhat.com>,
"zhihongx.peng@intel.com" <zhihongx.peng@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-stable] [PATCH 1/3] bus/vmbus: fix leak on device scan
Date: Fri, 1 Oct 2021 08:47:38 +0200 [thread overview]
Message-ID: <CAJFAV8zFkUW33KRu642gCA+ZBhUR-LbVnVOR8xUq4DQ5nJ-JdQ@mail.gmail.com> (raw)
In-Reply-To: <DM6PR21MB1513F80FF0E2601A844A6ED8CEAA9@DM6PR21MB1513.namprd21.prod.outlook.com>
On Thu, Sep 30, 2021 at 9:14 PM Long Li <longli@microsoft.com> wrote:
> > rte_device name only points at some location where the name is stored.
> > In general this storage is in the bus object or (in some buses) the devarg that
> > resulted in the rte_device object creation.
> >
> > If we won't store the name in the bus object, then we lose the ability to
> > release the name later.
> > This is probably fine as long as we never release rte_vmbus_device objects
> > which is the case atm.
> > But I don't understand why vmbus should be an exception when comparing
> > to other buses.
>
> I don’t understand why you want to put a name there if it's never used outside vmbus_scan_one().
Since you don't care about releasing rte_vmbus_device objects, I'll
rework as you suggest.
--
David Marchand
next prev parent reply other threads:[~2021-10-01 6:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210917082313.21934-1-david.marchand@redhat.com>
2021-09-17 8:23 ` David Marchand
2021-09-29 20:57 ` Long Li
2021-09-30 7:50 ` David Marchand
2021-09-30 19:14 ` Long Li
2021-10-01 6:47 ` David Marchand [this message]
2021-10-01 16:28 ` Long Li
2021-09-17 8:23 ` [dpdk-stable] [PATCH 2/3] test/latencystats: fix incorrect loop boundary David Marchand
2021-09-20 8:51 ` Pattan, Reshma
[not found] ` <20211002162432.4348-1-david.marchand@redhat.com>
2021-10-02 16:24 ` [dpdk-stable] [PATCH v2 1/3] bus/vmbus: fix leak on device scan David Marchand
2021-10-04 17:43 ` Long Li
2021-10-02 16:24 ` [dpdk-stable] [PATCH v2 2/3] test/latencystats: fix incorrect loop boundary David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zFkUW33KRu642gCA+ZBhUR-LbVnVOR8xUq4DQ5nJ-JdQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=longli@microsoft.com \
--cc=stable@dpdk.org \
--cc=sthemmin@microsoft.com \
--cc=zhihongx.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).