From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADC7E433B8 for ; Fri, 24 Nov 2023 14:36:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95A3A432BE; Fri, 24 Nov 2023 14:36:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 423B0432B2 for ; Fri, 24 Nov 2023 14:36:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700832979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Vu7JFS/KEclCoLB4h6aR2g+oG99KmlEj2I2ol6FX5M=; b=YmZWFo+G3iYIIv3bdQvHIbgzYmklrt5PZbSb1Ez0mkModMESBFEMB1xSxsl3KBvtYLeyLz BlTdZO9iK0U1fbqUZVSxgHaijpgxfLrAhsowpjY3/RwON+2y0W/Sy1w9Ddt3wfCecyzIcS jShcOAAJrUXkE5PQXe3/DCMl0ceijng= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-HSHI42AjMxiZZ6e_FB9jVg-1; Fri, 24 Nov 2023 08:36:16 -0500 X-MC-Unique: HSHI42AjMxiZZ6e_FB9jVg-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2c5194d4e98so15374131fa.3 for ; Fri, 24 Nov 2023 05:36:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700832975; x=1701437775; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Vu7JFS/KEclCoLB4h6aR2g+oG99KmlEj2I2ol6FX5M=; b=n5i0/ORIi1+wYSOMmOhzCbjZutKsp8ewDt1AbqWYEyigTsFsqCd85SHU8djk2V/qxx JmCF4FcFt1vy6642PYkC39NebqYS2qv2ZMqQbGh/tCckpgDSy/qE/qyCyyH4j3RGgxqZ jj+NxNk4DMzw0BBF6qv5H+aie/D4Sork75G4pTFfILD+D3EqgkFM1N/IplBiPzePiV9W v1cvNcYkAfeH/b6Q6G7EC1OAE1l35Es1ifGGJzFEeICkXr+KQfzOkp7vg4Ehr1fp6fgA LQEtzc9p1acKyQb82xKNlTX1lChFqJwmMpUInfM1mykLlX68P1x0FTZ1oBV2yF6/r+r1 EthQ== X-Gm-Message-State: AOJu0Yz9guYrozyYxab4KmRbun9GZ7UDMHm9aiDO+zSMbwjaIh/fAZVo YvEdjPXqo4ZoYam7vse3HYERIpVg6WuTvUeHYxHH6mplfRa8LEDlYs97VH2mEWVsxLAXKweX6k9 tfTy1N4Wy/kdaZUZuPkJ8Gew= X-Received: by 2002:a2e:9218:0:b0:2c5:3a9:7467 with SMTP id k24-20020a2e9218000000b002c503a97467mr2106260ljg.8.1700832975139; Fri, 24 Nov 2023 05:36:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IGYN0aQAp3bmCxrEsFwDkdSkHW4KHeI6bX9BVBmVgWy86MdHGZeIwdS7VX91R+cjb3QMWtfcda/QfJlrak7yCo= X-Received: by 2002:a2e:9218:0:b0:2c5:3a9:7467 with SMTP id k24-20020a2e9218000000b002c503a97467mr2106247ljg.8.1700832974824; Fri, 24 Nov 2023 05:36:14 -0800 (PST) MIME-Version: 1.0 References: <20231124033059.22972-1-sunyang.wu@jaguarmicro.com> In-Reply-To: <20231124033059.22972-1-sunyang.wu@jaguarmicro.com> From: David Marchand Date: Fri, 24 Nov 2023 14:36:03 +0100 Message-ID: Subject: Re: [PATCH] lib/ethdev: modified the definition of 'NVGRE_ENCAP' To: Sunyang Wu Cc: dev@dpdk.org, orika@nvidia.com, stable@dpdk.org, Joey Xing , Thomas Monjalon , Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, Nov 24, 2023 at 4:31=E2=80=AFAM Sunyang Wu wrote: > > Fix the issue of incorrect definition of 'NVGRE_ENCAP', and > modified the error comments of 'rte_flow_action_nvgre_encap'. > > Fixes: c2beb1d ("ethdev: add missing items/actions to flow object convert= er") > Fixes: 3850cf0 ("ethdev: add tunnel encap/decap actions") Please use the format for Fixes tag described in the contributing guide. Fixes: c2beb1d469d2 ("ethdev: add missing items/actions to flow object converter") Fixes: 3850cf0c8c37 ("ethdev: add tunnel encap/decap actions") > Cc: stable@dpdk.org Copying more maintainers. Apart from readability, I think this patch does not fix any real bug, does = it? > > Signed-off-by: Joey Xing > Signed-off-by: Sunyang Wu --=20 David Marchand