From: David Marchand <david.marchand@redhat.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
"stable@dpdk.org" <stable@dpdk.org>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbox@nvidia.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
Jiayu Hu <hujiayu.hu@foxmail.com>,
Michael Baum <michaelba@nvidia.com>,
Jianfeng Tan <jianfeng.tan@intel.com>,
Yuanhan Liu <yliu@fridaylinux.org>,
Tiwei Bie <tiwei.bie@intel.com>,
Yinan Wang <yinan.wang@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
Mark Kavanagh <mark.b.kavanagh@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
John McNamara <john.mcnamara@intel.com>
Subject: Re: [PATCH 3/5] doc: fix some ordered lists
Date: Fri, 24 Nov 2023 09:11:46 +0100 [thread overview]
Message-ID: <CAJFAV8zSwhVTb2ke3SCP7OGuy_mpgiBw7LJZXrV252nFiBryew@mail.gmail.com> (raw)
In-Reply-To: <IA1PR12MB831181F16F00DF5377699F45A4B9A@IA1PR12MB8311.namprd12.prod.outlook.com>
On Thu, Nov 23, 2023 at 6:22 PM Dariusz Sosnowski <dsosnowski@nvidia.com> wrote:
>
> Hi,
>
> > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index
> > 45379960f0..39a8c5d7b4 100644
> > --- a/doc/guides/nics/mlx5.rst
> > +++ b/doc/guides/nics/mlx5.rst
> > @@ -2326,19 +2326,18 @@ This command performs:
> >
> > #. Call the regular ``port attach`` function with updated identifier.
> >
> > -For example, to attach a port whose PCI address is ``0000:0a:00.0`` -and its
> > socket path is ``/var/run/import_ipc_socket``:
> > + For example, to attach a port whose PCI address is ``0000:0a:00.0``
> > + and its socket path is ``/var/run/import_ipc_socket``:
> >
> > -.. code-block:: console
> > -
> > - testpmd> mlx5 port attach 0000:0a:00.0
> > socket=/var/run/import_ipc_socket
> > - testpmd: MLX5 socket path is /var/run/import_ipc_socket
> > - testpmd: Attach port with extra devargs
> > 0000:0a:00.0,cmd_fd=40,pd_handle=1
> > - Attaching a new port...
> > - EAL: Probe PCI driver: mlx5_pci (15b3:101d) device: 0000:0a:00.0 (socket
> > 0)
> > - Port 0 is attached. Now total ports is 1
> > - Done
> > + .. code-block:: console
> >
> > + testpmd> mlx5 port attach 0000:0a:00.0
> > socket=/var/run/import_ipc_socket
> > + testpmd: MLX5 socket path is /var/run/import_ipc_socket
> > + testpmd: Attach port with extra devargs
> > 0000:0a:00.0,cmd_fd=40,pd_handle=1
> > + Attaching a new port...
> > + EAL: Probe PCI driver: mlx5_pci (15b3:101d) device: 0000:0a:00.0 (socket
> > 0)
> > + Port 0 is attached. Now total ports is 1
> > + Done
> >
> > port map external Rx queue
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~
> The preceding list explains what "mlx5 port attach" command does and the following section provides an example of usage.
> I don't think this section should be a part of that list.
Re-reading this section, I agree.
I will drop this hunk.
Thanks Dariusz.
--
David Marchand
next prev parent reply other threads:[~2023-11-24 8:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231123114405.2611371-1-david.marchand@redhat.com>
2023-11-23 11:44 ` [PATCH 1/5] doc: remove restriction on ixgbe vector support David Marchand
2023-11-23 11:45 ` Bruce Richardson
2023-11-23 11:44 ` [PATCH 3/5] doc: fix some ordered lists David Marchand
2023-11-23 11:49 ` Bruce Richardson
2023-11-23 17:22 ` Dariusz Sosnowski
2023-11-24 8:11 ` David Marchand [this message]
2023-11-23 11:44 ` [PATCH 4/5] doc: remove number of commands in vDPA guide David Marchand
2023-11-23 12:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zSwhVTb2ke3SCP7OGuy_mpgiBw7LJZXrV252nFiBryew@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=hujiayu.hu@foxmail.com \
--cc=jerinj@marvell.com \
--cc=jianfeng.tan@intel.com \
--cc=john.mcnamara@intel.com \
--cc=kirankumark@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=mark.b.kavanagh@intel.com \
--cc=matan@nvidia.com \
--cc=maxime.coquelin@redhat.com \
--cc=michaelba@nvidia.com \
--cc=ndabilpuram@marvell.com \
--cc=orika@nvidia.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=tiwei.bie@intel.com \
--cc=viacheslavo@nvidia.com \
--cc=yinan.wang@intel.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).