From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B02C8A0569 for ; Wed, 11 Mar 2020 17:16:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F9FBFEB; Wed, 11 Mar 2020 17:16:04 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 86086FEB for ; Wed, 11 Mar 2020 17:16:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583943363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YBeGh4ZG18zII2bpjYTaLQuDv736Gw2CwWE4xrM4/SY=; b=RkbBrde/nkG7K6/tLnCphRYZNCSJCk27DMdwuewIoJESttn3J9tcR8GFObW3OJ/dS+teGO +6NyIlpRcjPOSoYHdN4PK0e0/ujJB2U/7cWkcoqtvW5RWubQ2n6Dry7osyy2elOa6BSUYS 2EjM4/aYAYEZzY7g8b8pkQw/fSP9xls= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-241-JQuM324qPUKcdBn0agWgmw-1; Wed, 11 Mar 2020 12:16:01 -0400 X-MC-Unique: JQuM324qPUKcdBn0agWgmw-1 Received: by mail-vs1-f71.google.com with SMTP id z18so330183vsz.11 for ; Wed, 11 Mar 2020 09:16:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ws+pWvyqzorNhgB2J93W60j+4fOB1/z0nDIgjrm6uTs=; b=AsOMSdMcEKSUz2UWEH/GNoF4QIprW9/QKfy5iCDsRy3JxjkzAUlM3KfAP+J5Y+/0ma bn4/eZJyVUJvelo9W7bdDpQ41zlLgzJyKHKjyvQk2TMjV26L8AfMYcEKtKF9u/uyNznw IVRQQW6sS20+yrlhRbbFCP4CBfL+9SBPiDbNpYGZhYO2OtSc05HET1WRKk+XqUUvPiIQ MYrPV8tRQ1ZmO52zfIlzKfc4Z5JdBtdGLsZQSqw5OHCmsbxVbiWa7zqcceR7YkgMUSOv GmDNHbEzB7Dls9c32k3bfmnKZeZhLFLMd7SPwzucDSI+LT7MAf2ChwpLhunh2VnPXfWP jK8Q== X-Gm-Message-State: ANhLgQ1CO/cERGpTlmB45KaS0r/VLKfpa5STvaOYtU5LuvszJhkO2TdZ LJVFbJVjfz4IddTS8e/TXdmgcT3SN1uIrZ60kObnF1SK6Dwc5PK5AsSkTELXyUY9n/ndwK1ZSUu 8uQiISW1UDuhPrtvrta5HEtA= X-Received: by 2002:a9f:2204:: with SMTP id 4mr2112322uad.87.1583943360687; Wed, 11 Mar 2020 09:16:00 -0700 (PDT) X-Google-Smtp-Source: ADFU+vs3++2JJFankBZlq6Dlya29XHzDPC3zwaVg/2+jFnxxFeUz5izPV0V/AfpHXwfBAp8p/LBQu4MDsxXXIo57myc= X-Received: by 2002:a9f:2204:: with SMTP id 4mr2112295uad.87.1583943360134; Wed, 11 Mar 2020 09:16:00 -0700 (PDT) MIME-Version: 1.0 References: <20200310133304.39951-1-harry.van.haaren@intel.com> <20200311143927.76021-1-harry.van.haaren@intel.com> In-Reply-To: <20200311143927.76021-1-harry.van.haaren@intel.com> From: David Marchand Date: Wed, 11 Mar 2020 17:15:49 +0100 Message-ID: To: Harry van Haaren Cc: dev , Aaron Conole , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [PATCH v2] eal/service: fix exit by resetting service lcores X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren wrote: > > This commit releases all service cores from their role, > returning them to ROLE_RTE on rte_service_finalize(). > > This may fix an issue relating to the service cores causing You don't seem convinced. > a race-condition on eal_cleanup(), where the service core > could still be executing while the main thread has already > free-d the service memory, leading to a segfault. > > Fixes: 21698354c832 ("service: introduce service cores concept") > Cc: stable@dpdk.org > > Reported-by: David Marchand > Reported-by: Aaron Conole > Signed-off-by: David Marchand > Signed-off-by: Harry van Haaren > Acked-by: Aaron Conole I am okay with merging this so that we stop getting random failures of the = ut. I will let this patch on the ml and apply on Friday at worse. Please take the time to reply to my question. Thanks. --=20 David Marchand