* [PATCH v3] bus/fslmc: unlock spinlock in case of timeout
@ 2023-01-04 7:40 Alvaro Karsz
2023-01-31 10:10 ` David Marchand
0 siblings, 1 reply; 2+ messages in thread
From: Alvaro Karsz @ 2023-01-04 7:40 UTC (permalink / raw)
To: dev; +Cc: sachin.saxena, hemant.agrawal, david.marchand, stable, Alvaro Karsz
Bug in function mc_send_command,
A spinlock is not unlocked in case of timeouts.
Fixes: 79711846f676 ("bus/fslmc: add timeout in MC send command")
Cc: stable@dpdk.org
Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
v2:
- Fix code indentation.
- Fix "Fixes: " tag format.
v3:
- Remove unnecessary comment.
- cc stable@dpdk.org
---
drivers/bus/fslmc/mc/mc_sys.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/fslmc/mc/mc_sys.c b/drivers/bus/fslmc/mc/mc_sys.c
index ab9a074835..76fdcd5c8a 100644
--- a/drivers/bus/fslmc/mc/mc_sys.c
+++ b/drivers/bus/fslmc/mc/mc_sys.c
@@ -77,8 +77,11 @@ int mc_send_command(struct fsl_mc_io *mc_io, struct mc_command *cmd)
total_time = rte_get_timer_cycles() - start_time;
} while (status == MC_CMD_STATUS_READY && total_time <= time_to_wait);
- if (status == MC_CMD_STATUS_READY)
+ if (status == MC_CMD_STATUS_READY) {
+ rte_spinlock_unlock(&mc_portal_lock);
+
return mc_status_to_error(MC_CMD_STATUS_TIMEOUT);
+ }
/* Read the response back into the command buffer */
mc_read_response(mc_io->regs, cmd);
--
2.32.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3] bus/fslmc: unlock spinlock in case of timeout
2023-01-04 7:40 [PATCH v3] bus/fslmc: unlock spinlock in case of timeout Alvaro Karsz
@ 2023-01-31 10:10 ` David Marchand
0 siblings, 0 replies; 2+ messages in thread
From: David Marchand @ 2023-01-31 10:10 UTC (permalink / raw)
To: Alvaro Karsz, sachin.saxena, hemant.agrawal; +Cc: dev, stable
On Wed, Jan 4, 2023 at 8:41 AM Alvaro Karsz <alvaro.karsz@solid-run.com> wrote:
>
> Bug in function mc_send_command,
> A spinlock is not unlocked in case of timeouts.
>
> Fixes: 79711846f676 ("bus/fslmc: add timeout in MC send command")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
No review from the driver maintainers after a month.
The fix seems valid to me.
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-31 10:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-04 7:40 [PATCH v3] bus/fslmc: unlock spinlock in case of timeout Alvaro Karsz
2023-01-31 10:10 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).