From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83707432BA for ; Mon, 6 Nov 2023 17:04:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CE1C40A7A; Mon, 6 Nov 2023 17:04:04 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 548F94025D for ; Mon, 6 Nov 2023 17:04:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699286642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NsHZjD+bhA5RbnzM1xghkBgeyHRmxtvuRZ7LOJt/HnY=; b=F1z4YdQ16RjO3fBEjCS0WwSatRO4fOA2FGQwyQ+CU7WCvzcGhUVBjtc4PUKHrlcWFp74hO Eb2wFTFVVWswv7DmTRsFozawH7S/So2Qfy+lT9HaI2vO9QHvq0gRQczPHwHRM4wPbN8K+P PPmoKRrWTb3Iz7kjihhTxMIHPcE4p70= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-8kc015FzMFm3U9IUWZwKPg-1; Mon, 06 Nov 2023 11:03:26 -0500 X-MC-Unique: 8kc015FzMFm3U9IUWZwKPg-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2c6ed315cc3so48298601fa.2 for ; Mon, 06 Nov 2023 08:03:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699286602; x=1699891402; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NsHZjD+bhA5RbnzM1xghkBgeyHRmxtvuRZ7LOJt/HnY=; b=gwHiOnvuVKMNRc3jS+tJUtRJHJnDAQKv5RrpohRIo5OQFbP/Y1m8NlZL2uNcrZcdRy kqU8vz1KRHZfsL9vgHdkZvOZCuY1IQ//fYhjw5MJyC2tXb3J0sKYpnOPRw9laZJeLi0w +naQkbHbeye9c2JTRz+Hv5gnLHyDee9lAcQ2702rjNhOa5ycHWzwalEAy1vSWd1DdCyH FDlDo0d524aCpUb8E6nchklQWsT9KoNZ9at0BPM3U+JrZ7+Va+X+SD2n+EulovsgWSvT J4N/N/S7rKTwu0DHEZu/f+UqDqOF7JCxLM4v8GATFyTclmlELaXbWtGj7gVMOqVjvY+b 9UBw== X-Gm-Message-State: AOJu0YwNCwjKyuxRD0whaNHoH4ijb9kQq35jiN/r6diz7Tu/JI5esW5b vvWabZbNAq1sU7CZX/dDSQ7VmeQKdgGvGpmuTAYhpi4hUS0ZTjKRzRcT5kBfdAAeWDmIDP8Qxf2 1CMaHghh2aPRsjoaeoTIbGr4= X-Received: by 2002:a05:651c:1a0e:b0:2c0:d21:39de with SMTP id by14-20020a05651c1a0e00b002c00d2139demr30902185ljb.42.1699286602117; Mon, 06 Nov 2023 08:03:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IEWrSs1Yjkc0gwWtLiM4WR+u3HNRPQvJ59b4lvN+A86vXEdSHwkx9O2H+Aj6siWUQIbNyFu4NwboUHM++jV/g8= X-Received: by 2002:a05:651c:1a0e:b0:2c0:d21:39de with SMTP id by14-20020a05651c1a0e00b002c00d2139demr30902146ljb.42.1699286601806; Mon, 06 Nov 2023 08:03:21 -0800 (PST) MIME-Version: 1.0 References: <20231020170135.18319-1-syalavarthi@marvell.com> <20231106041243.13621-1-syalavarthi@marvell.com> In-Reply-To: <20231106041243.13621-1-syalavarthi@marvell.com> From: David Marchand Date: Mon, 6 Nov 2023 17:03:10 +0100 Message-ID: Subject: Re: [PATCH v5 1/1] build: add libarchive to external deps To: Srikanth Yalavarthi , Bruce Richardson Cc: Aaron Conole , Igor Russkikh , dev@dpdk.org, sshankarnara@marvell.com, aprabhu@marvell.com, ptakkar@marvell.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, Nov 6, 2023 at 5:12=E2=80=AFAM Srikanth Yalavarthi wrote: > > In order to avoid linking with Libs.private, libarchive > is not added to ext_deps during the meson setup stage. > > Since libarchive is not added to ext_deps, cross-compilation > or native compilation with libarchive installed in non-standard > location fails with errors related to "cannot find -larchive" > or "archive.h: No such file or directory". In order to fix the > build failures, user is required to define the 'c_args' and > 'c_link_args' with '-I' and '-L'. > > This patch adds libarchive to ext_deps and further would not > require setting c_args and c_link_args externally. > > Fixes: 40edb9c0d36b ("eal: handle compressed firmware") > Cc: stable@dpdk.org > > Signed-off-by: Srikanth Yalavarthi This breaks static compilation of applications. This can be reproduced with test-meson-builds.sh and in GHA (which was not linking examples statically, I added a patch in my github repo): https://github.com/david-marchand/dpdk/actions/runs/6772879600/job/18406442= 129#step:19:19572 --=20 David Marchand