From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6958DA00C2 for ; Wed, 17 Mar 2021 10:48:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A6FC40687; Wed, 17 Mar 2021 10:48:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 768E640687 for ; Wed, 17 Mar 2021 10:48:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615974523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rxx5LlubbyNIjH8CN2mBbrGIFbEPd9P7XM32WynOuyY=; b=SgKe035TWp4UYQm5uX5OepITHEUQ3iTapxM+3FbqAzeFFUep4ouBrEqAx0NizDKOJk8dBh iS5cvgLHBuD/5FH0PGNKuKcPiFWHFRb0P98wpgQY3/vncKqhH7nUwT1t5AUM1mvVYH4QXH 5MhL90MxcTtQqx7VnoLlXaE2Z5Ch8WM= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-588-jwWvAKRVOry0GnhfBoIroA-1; Wed, 17 Mar 2021 05:48:41 -0400 X-MC-Unique: jwWvAKRVOry0GnhfBoIroA-1 Received: by mail-vs1-f71.google.com with SMTP id w5so10065776vsf.14 for ; Wed, 17 Mar 2021 02:48:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rxx5LlubbyNIjH8CN2mBbrGIFbEPd9P7XM32WynOuyY=; b=pFbJe6TyzdcatIkocWH18EX5gXV575qWTJ8BX6z0CV5LsHdMsxP6S+2RisnbheZigt H4fpo1yT0wF3eCY2yKiCB0mrExFe+0nLMR8iv4MelffNsuNHRDelpwu6FNIZp2W9mCJY aAvNuZS8gkZZyyMdwiOP29ouH8elLj5eZ/jfkLAkK+PixXiBvFrmyil5mNyWj/90ie/l HhdyOMxGd5srDl0XGta1zwt0VulAbAvU6GlF7hw0umR1zhsPfHiyxQiCvI9Hbm8sSgT3 ztFNesCePYZq7BN081sBFEa03+bBoywgzoTsns6YyTUbhRjkJeehYFC705RhEMySG64k fcWw== X-Gm-Message-State: AOAM531ForsouMd9yFvYAivxLGfhYtXLOIjLkxYGH5wfjQYqArjSvYHf K25cGiIVWD2QMcSpg0Fa4Sq1d+FVyaWzjyQIOMbQc27tD+0vm4QflLjtnh2d0DYxgYTOAFFQBdo lf5djaSVJmAJypqa8CHQTA2Q= X-Received: by 2002:a1f:9ac7:: with SMTP id c190mr2051115vke.17.1615974520575; Wed, 17 Mar 2021 02:48:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVau612PPwRBHE3x0BBRilvYYlKq9Dtl5wGv7w9dYNtSDsBPSHz4hl2oToMO7YFlrKyVycSq+wLJcICkr3+hs= X-Received: by 2002:a1f:9ac7:: with SMTP id c190mr2051109vke.17.1615974520363; Wed, 17 Mar 2021 02:48:40 -0700 (PDT) MIME-Version: 1.0 References: <20210317093124.965624-1-thomas@monjalon.net> In-Reply-To: <20210317093124.965624-1-thomas@monjalon.net> From: David Marchand Date: Wed, 17 Mar 2021 10:48:29 +0100 Message-ID: To: Thomas Monjalon Cc: dev , dpdk stable , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH] eal: fix version macro X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon wrote: > > The macro RTE_VERSION is broken since updated with function calls. > It is a build-time version number, and must be built with macros. > For a run-time version number, there is the function rte_version(). > > Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime") > Cc: stable@dpdk.org > > Reported-by: David Marchand > Signed-off-by: Thomas Monjalon > --- > lib/librte_eal/include/rte_version.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_eal/include/rte_version.h b/lib/librte_eal/include/rte_version.h > index 2f3f727b46..736c5703be 100644 > --- a/lib/librte_eal/include/rte_version.h > +++ b/lib/librte_eal/include/rte_version.h > @@ -28,10 +28,10 @@ extern "C" { > * All version numbers in one to compare with RTE_VERSION_NUM() > */ > #define RTE_VERSION RTE_VERSION_NUM( \ > - rte_version_year(), \ > - rte_version_month(), \ > - rte_version_minor(), \ > - rte_version_release()) > + RTE_VER_YEAR, \ > + RTE_VER_MONTH, \ > + RTE_VER_MINOR, \ > + RTE_VER_RELEASE) > > /** > * Function to return DPDK version prefix string The original patch wanted to fix rte_version() at runtime. I don't see the need to keep the rte_version_XXX exports now that RTE_VERSION is reverted. -- David Marchand