From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-f194.google.com (mail-vk1-f194.google.com [209.85.221.194]) by dpdk.org (Postfix) with ESMTP id 2CEB42BD3 for ; Thu, 17 Jan 2019 18:18:12 +0100 (CET) Received: by mail-vk1-f194.google.com with SMTP id y14so2429497vky.9 for ; Thu, 17 Jan 2019 09:18:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ugJE2q3q4tmC9ujTnVT3Y23bgyvWvxbm9dWNEeI7BUA=; b=Y5Qj+7JO85pAXATzFGVodxYOyg88qODBKaDJF5NaDt4aKBqvJNIn+n2wWc61iDoQB/ a/+zVjvpGQMNxHXycXGEx1muOUdatm+VxCfD3HKIWTRg8ZCb9GxUh8f3TdDmmkW7pFoC 5WlzEGB/Q03KcFCB/YyxKbzH+SGmmD9hXoozk6sHPe5s1n6zsevPPhzpOR4sCdIuLQfe FuitxWCVmJe7GnY2vZS0MOxtZKdD7tx5F2ZsK6IyLN1uSw9643gZgYmtDCW9ARx/aAg7 tkQehOZon3oBVii+V5WZmnViqwGZhMkN5s1zfZCf7V8/8qI5ywP3OfHBybZl3CM9HOwO rhzg== X-Gm-Message-State: AJcUukdno9G7psT2iFJ4RYAnBb82j58aXMk4k72/kzdzhONgdyAn6chW 9rcX8xqNkSTsVYlY+Bx3PYf/S9Z+jbVggQ4bKHQTEQ== X-Google-Smtp-Source: ALg8bN7PfK1KytCP3d4rNJz7RL9ub1korWJalKhR0w/BeaFbQ58xqYFwRqm6hBZ23HId2/Zee7ja1FNrmxJeOZJTY28= X-Received: by 2002:a1f:19d6:: with SMTP id 205mr5783477vkz.53.1547745491309; Thu, 17 Jan 2019 09:18:11 -0800 (PST) MIME-Version: 1.0 References: <1547730777-20405-1-git-send-email-david.marchand@redhat.com> <3463567.oezzxnnWpT@xps> In-Reply-To: <3463567.oezzxnnWpT@xps> From: David Marchand Date: Thu, 17 Jan 2019 18:17:59 +0100 Message-ID: To: Thomas Monjalon Cc: dev@dpdk.org, Bruce Richardson , solal.pirelli@gmail.com, dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix out of bound access when no cpu is available X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 17:18:12 -0000 On Thu, Jan 17, 2019 at 5:34 PM Thomas Monjalon wrote: > 17/01/2019 14:12, David Marchand: > > In the unlikely case when the dpdk application is started with no cpu > > available in the [0, RTE_MAX_LCORE - 1] range, the master_lcore is > > automatically chosen as RTE_MAX_LCORE which triggers an out of bound > > access. > > > > Either you have a crash then, or the initialisation fails later when > > trying to pin the master thread on it. > > In my test, with RTE_MAX_LCORE == 2: > > > > $ taskset -c 2 ./master/app/testpmd --no-huge -m 512 --log-level *:debug > > [...] > > EAL: pthread_setaffinity_np failed > > PANIC in eal_thread_init_master(): > > cannot set affinity > > 7: [./master/app/testpmd() [0x47f629]] > > > > Bugzilla ID: 19 > > Signed-off-by: David Marchand > > We should backport this fix. > When this bug has been introduced? > Indeed, at first, I thought the problem had always been there, but it should be starting 17.02: Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection") + CC stable Do you want a v2 ? -- David Marchand