* [PATCH] bus/ifpga: fix driver header dependency
@ 2023-10-23 14:46 David Marchand
2023-10-23 15:05 ` Bruce Richardson
2023-10-24 0:23 ` Xu, Rosen
0 siblings, 2 replies; 4+ messages in thread
From: David Marchand @ 2023-10-23 14:46 UTC (permalink / raw)
To: dev; +Cc: stable, Rosen Xu
The driver header bus_ifpga_driver.h was not self sufficient.
Fix this by including dev_driver.h.
Fixes: 925c074e377b ("bus/ifpga: make driver-only headers private")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/bus/ifpga/bus_ifpga_driver.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bus/ifpga/bus_ifpga_driver.h b/drivers/bus/ifpga/bus_ifpga_driver.h
index 7b75c2ddbc..5bbe36d6e0 100644
--- a/drivers/bus/ifpga/bus_ifpga_driver.h
+++ b/drivers/bus/ifpga/bus_ifpga_driver.h
@@ -16,6 +16,7 @@ extern "C" {
#endif /* __cplusplus */
#include <rte_compat.h>
+#include <dev_driver.h>
#include <rte_pci.h>
#include <rte_interrupts.h>
#include <rte_spinlock.h>
--
2.41.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] bus/ifpga: fix driver header dependency
2023-10-23 14:46 [PATCH] bus/ifpga: fix driver header dependency David Marchand
@ 2023-10-23 15:05 ` Bruce Richardson
2023-10-24 0:23 ` Xu, Rosen
1 sibling, 0 replies; 4+ messages in thread
From: Bruce Richardson @ 2023-10-23 15:05 UTC (permalink / raw)
To: David Marchand; +Cc: dev, stable, Rosen Xu
On Mon, Oct 23, 2023 at 04:46:17PM +0200, David Marchand wrote:
> The driver header bus_ifpga_driver.h was not self sufficient.
> Fix this by including dev_driver.h.
>
> Fixes: 925c074e377b ("bus/ifpga: make driver-only headers private")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] bus/ifpga: fix driver header dependency
2023-10-23 14:46 [PATCH] bus/ifpga: fix driver header dependency David Marchand
2023-10-23 15:05 ` Bruce Richardson
@ 2023-10-24 0:23 ` Xu, Rosen
2023-10-26 8:41 ` David Marchand
1 sibling, 1 reply; 4+ messages in thread
From: Xu, Rosen @ 2023-10-24 0:23 UTC (permalink / raw)
To: Marchand, David, dev; +Cc: stable
Hi,
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, October 23, 2023 10:46 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Xu, Rosen <rosen.xu@intel.com>
> Subject: [PATCH] bus/ifpga: fix driver header dependency
>
> The driver header bus_ifpga_driver.h was not self sufficient.
> Fix this by including dev_driver.h.
>
> Fixes: 925c074e377b ("bus/ifpga: make driver-only headers private")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/bus/ifpga/bus_ifpga_driver.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/ifpga/bus_ifpga_driver.h
> b/drivers/bus/ifpga/bus_ifpga_driver.h
> index 7b75c2ddbc..5bbe36d6e0 100644
> --- a/drivers/bus/ifpga/bus_ifpga_driver.h
> +++ b/drivers/bus/ifpga/bus_ifpga_driver.h
> @@ -16,6 +16,7 @@ extern "C" {
> #endif /* __cplusplus */
>
> #include <rte_compat.h>
> +#include <dev_driver.h>
> #include <rte_pci.h>
> #include <rte_interrupts.h>
> #include <rte_spinlock.h>
> --
> 2.41.0
Acked-by: Rosen Xu <rosen.xu@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] bus/ifpga: fix driver header dependency
2023-10-24 0:23 ` Xu, Rosen
@ 2023-10-26 8:41 ` David Marchand
0 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2023-10-26 8:41 UTC (permalink / raw)
To: David Marchand; +Cc: dev, stable, Xu, Rosen, Bruce Richardson
On Tue, Oct 24, 2023 at 2:23 AM Xu, Rosen <rosen.xu@intel.com> wrote:
> > The driver header bus_ifpga_driver.h was not self sufficient.
> > Fix this by including dev_driver.h.
> >
> > Fixes: 925c074e377b ("bus/ifpga: make driver-only headers private")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Rosen Xu <rosen.xu@intel.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-26 8:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-23 14:46 [PATCH] bus/ifpga: fix driver header dependency David Marchand
2023-10-23 15:05 ` Bruce Richardson
2023-10-24 0:23 ` Xu, Rosen
2023-10-26 8:41 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).